From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29CB633C187 for ; Tue, 17 Mar 2026 07:04:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773731063; cv=none; b=Sa+KYQLZSQOSDGM389/11LP4Ddp8yJhv4XhTN6pkYccsuW25bJbJxti/PMS5moXhJ6gFsq5wXZsdmMTU/fuOsQcOydyFaFYDF5R+nDba9OI6DaJxVtFbZMoIxaCQhP22u+OPKGRz/PQo1Uql+8PZzl9In4ooSGZQJNOfaLeL8MI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773731063; c=relaxed/simple; bh=Pj0AescwKQKugE0oUPQYGMX8mPyxhjBvNONkzt4D0uE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=l6rKNSzVgJZEEPSv6wjsoy+c4l8xieKivGUelEdC5NubPNHU+4t24M3V5qfJ84zsO7xAOb/BLCj9hExtF8FAq68alLla4wvCa1SMQRPE++efDqBzARlMH4luiBg17yYM4K9ZIQBq+Tfp4O6Wsam0vLS9D67ZXC9BSEg7zJ7o4MA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JUIixCwD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AaYxVNYa; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JUIixCwD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AaYxVNYa" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62H1wq504022265 for ; Tue, 17 Mar 2026 07:04:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= fQNtTToqGV4iqPYhKUIsqJXXPCuv1iHkfFdTRqxCiQo=; b=JUIixCwDas5DFYMy EDuIAFeBUMMY/9dhI2upXEXxoVyLDhxYr6ONiiqFQkmr4PHCjKApeEs0zs73bqNW pwanfaX6myV6EHZyNZR74IG/Pa/sLSeRIuGoobUcb8i4RX/HNkqyiv0W20IpAziF Ljonbkl47NZhzpXWzt1fjy8z3oUVQdm0FG3ObsH1ojJD+YnQITc5sPSoGAwyN+nP 7PYD6sIdin9L6f6ZXYEJ4JFi+DYnIr1kJme/c+6kNGC+9BvihX4zE0j0pAB1M8lg vwD3w5wlFGmRvlCPX7giByaVg6wGIbR9X5bR2L8W5RpVFpoOxF5GaoiqhKOkj2QY JFg0ag== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cxn3fjhra-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Mar 2026 07:04:20 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-358e425c261so6419888a91.3 for ; Tue, 17 Mar 2026 00:04:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773731060; x=1774335860; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fQNtTToqGV4iqPYhKUIsqJXXPCuv1iHkfFdTRqxCiQo=; b=AaYxVNYa4stq3qwaM/4kFjEi49URmJn9mC5zrNAWe2kAASn+joszKVnzuPhF6df0IJ JDV3SpsbGEvuqflHUSC8nTVxNXD1DW2h6NBpiOMmVWTBjCjOBoPQHla970RVak2gnWsP mCEaz8pu2hZpkKrNrNv8rdSK5tAj4bXLi5lCpKfCzMCpJBM6Z0sYkly8iUjhtB6VlXMA rTKzAjsFREIEWM3cazyg6iSD3ctjhmbkotqHOaWRFG4IqfA4i+jDZheSG09IJAPjPb1A p5TP98jzHcZjEBrAjgA8orsf/6XYN4kCSvKGyUuXoMbOdd8WTiMmBPpaNcrp7lobH6UC osSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773731060; x=1774335860; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fQNtTToqGV4iqPYhKUIsqJXXPCuv1iHkfFdTRqxCiQo=; b=hRP9ETdax9CTUG/NPh6A8LBOVjtJJiSERWENCjk7zV3ThwQ8NKPnxikGEbkQkpNgAW oE3+X0NLuf27v0MMfdLh2xAd6z7USTISthGIVNSwEqDXKxVFGOCnG4gydryfh82B+EkS GOxuXTyiFbVWjzacdjetbzpJo4lq+hXO1ATVV+1XPRYCJTViOTvicoyJLqC7+g/W4JzS mcsI5YLns88m174gs/AwmbnOBpIsieTbJioxypRAkZbFH2I7jrlk9Zo2A6I3pnypIzzI 9Bb5sIOwO3bTUyrbB/rg34JQcGCFNosZCTqU5xP01csie7rWr5SKbdDheZ1JhqfSRLmi R7rw== X-Forwarded-Encrypted: i=1; AJvYcCV05bcyf7eVI/DOHRhrVzsu/mCDe7VbBYIx/rt3IVQNhj7H6jNK4WkputoYfJawEJPUJqoHgfJNTijlC5M=@vger.kernel.org X-Gm-Message-State: AOJu0Yzv1W3KxI5R5xxeFc3XYx4E3foAlp0CWK10cWYZvUspoFFQX4H3 wiGymqZDet+qoN/DYckKk7sb1IttXSM8FJowirHsVU/ROK/jYgi/2IMJfVwK+yjroBx5hcfbvln ny5zmTPbKqyGgrNi9a48nHt3pbS+0Ybg1hlBqYxoGWKPMVu5f1Ve+i0j44QRl6BlVVnc= X-Gm-Gg: ATEYQzz6WwsEf7TXaSl5g7p6GHtIGP6L8XMEU6OAAUUHJgMMsU6v1apYn5FwDPux2rN xqaZ0QbP03PihKaO15kohGfgUh51g23nIdYqO0fwopE7KQTCGjh85f4UIRH6lyQ4CmwgqpyjTUM hXCH932v2mbLggwh0xV9muc7wxrai/2VJN/3io2C0OiY1oOwJTCo7Iogws1fQQh9a8ju7cuQQQG MKKfT23QLYhxM5SOO9h79WkFU9yfZUykV5pBRj/ZfEa608uNXA5vmtf7v8LAVjaFm3oZgusu2QX jV0X5U1uPVP49PHi7xm3zPphWur/T546gnhjuHv3RG+WcsCPEJlP4qD/gl/7eqnEtfVu0+SGzWg wQyA0du3Fj8nAsoJsHEEAO41LCGS4fJYDBDg3OYdGeiD25MTYkmwym9YhCG9shnJo/Uprq+D0v4 AJzE6fdwL8jA== X-Received: by 2002:a05:6a20:5499:b0:398:795c:26c7 with SMTP id adf61e73a8af0-398eca24ad9mr14692434637.3.1773731059913; Tue, 17 Mar 2026 00:04:19 -0700 (PDT) X-Received: by 2002:a05:6a20:5499:b0:398:795c:26c7 with SMTP id adf61e73a8af0-398eca24ad9mr14692405637.3.1773731059390; Tue, 17 Mar 2026 00:04:19 -0700 (PDT) Received: from [10.133.33.84] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c73ebb6336bsm12409470a12.21.2026.03.17.00.04.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Mar 2026 00:04:19 -0700 (PDT) Message-ID: Date: Tue, 17 Mar 2026 15:04:12 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 04/12] scsi: ufs: core: Add support for TX Equalization To: Bart Van Assche , avri.altman@wdc.com, beanhuo@micron.com, martin.petersen@oracle.com, mani@kernel.org Cc: linux-scsi@vger.kernel.org, Alim Akhtar , "James E.J. Bottomley" , Peter Wang , "Bao D. Nguyen" , Adrian Hunter , open list References: <20260308151409.3779137-1-can.guo@oss.qualcomm.com> <20260308151409.3779137-5-can.guo@oss.qualcomm.com> <6e07208c-a94b-44dc-8f7e-ccbb0ff8840e@oss.qualcomm.com> <16e4ee41-c156-4f09-80cb-e0e7918c87bf@acm.org> Content-Language: en-US From: Can Guo In-Reply-To: <16e4ee41-c156-4f09-80cb-e0e7918c87bf@acm.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=C5bkCAP+ c=1 sm=1 tr=0 ts=69b8fcf5 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=utLGG-T327fd-dhq7TkA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-GUID: FE2U0LKqeeBJzKIroU7sh9_oAE_2nd2Q X-Proofpoint-ORIG-GUID: FE2U0LKqeeBJzKIroU7sh9_oAE_2nd2Q X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE3MDA2MCBTYWx0ZWRfXzODs1/ov3J+I DRqGo3t9AXqP390hP6gCCjzvMehqYf90ptXq0gRVgAuj8OmP42AAyUgpiktnlbvzboHHGOOmXfb 8YXfirxccXnDOv6MsBalGLCHWDBNVHJ6yYFHh3afsge5CrhyaEp7QcdPl7vjrrinjownki+jQC5 nK4r2INMew338ajP8WfLH5Q8QyWrSGpWyUuAMiCYgagPTeok6cuCX0/G64bvmG4zZiDTXAfTd0X eMUFdKmdGVx+GIcSLQA8JDAzG5O9KLLVr9lfW+fxADbM9JloNcRSsiViIqa6jxJuK94lC8R33qX 7uGDtNtHd6jj9X+I/LeCKjPd5mWuHCSjLKujWX6wg4u9FbBgCmM+iHWGQKgsLJfQOfGIiX/tqo/ p6LNaYCuWkq56oFtpJFYpZaKvr7fqcDBBiwc/+T+sIGhlITJz+5/1n1xaG5+elD4qYYEBhiRDrJ WBLrxQzaw0o2QP+EczQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-17_01,2026-03-16_06,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 priorityscore=1501 spamscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 impostorscore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603170060 On 3/17/2026 12:55 AM, Bart Van Assche wrote: > On 3/14/26 2:33 AM, Can Guo wrote: >> >> >> On 3/14/2026 4:19 PM, Can Guo wrote: >>> >>> >>> On 3/14/2026 6:19 AM, Bart Van Assche wrote: >>>> On 3/8/26 8:14 AM, Can Guo wrote: >>>>> +static int txeq_gear_set(const char *val, const struct >>>>> kernel_param *kp) >>>>> +{ >>>>> +    return param_set_uint_minmax(val, kp, UFS_HS_G1, UFS_HS_G6); >>>>> +} >>>> >>>> Why UFS_HS_G6 instead of UFS_HS_GEAR_MAX? >>> I will use 'UFS_HS_GEAR_MAX - 1' in next version. >> On second thought, to make the code more readable and scalable, I >> will use UFS_HS_GEAR_MAX >> here. To achieve so, I am going to tweak the code like below: >> >> enum ufs_hs_gear_tag { >>          UFS_HS_DONT_CHANGE,     /* Don't change Gear */ >>          UFS_HS_G1,              /* HS Gear 1 (default for reset) */ >>          UFS_HS_G2,              /* HS Gear 2 */ >>          UFS_HS_G3,              /* HS Gear 3 */ >>          UFS_HS_G4,              /* HS Gear 4 */ >>          UFS_HS_G5,              /* HS Gear 5 */ >> +      UFS_HS_G6,              /* HS Gear 6 */ >> +      UFS_HS_GEAR_MAX_INVALID, >> }; >> + >> + #define UFS_HS_GEAR_MAX         UFS_HS_GEAR_MAX_INVALID - 1 > Will UFS_HS_GEAR_MAX_INVALID be used anywhere? If not, please leave it > out and add the following past UFS_HS_G6 instead of just > "UFS_HS_GEAR_MAX": > >     UFS_HS_GEAR_MAX = UFS_HS_G6, OK. Thanks, Can Guo. > > Thanks, > > Bart.