From: Andrew Lunn <andrew@lunn.ch>
To: Dharanitharan R <dharanitharan725@gmail.com>
Cc: sammy@sammy.net, andrew+netdev@lunn.ch, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: i825xx: replace printk() with pr_*() macros for cleaner logging
Date: Tue, 28 Oct 2025 14:24:56 +0100 [thread overview]
Message-ID: <fcb18197-af45-4f7d-a435-39796c51c1e7@lunn.ch> (raw)
In-Reply-To: <20251028100127.14839-1-dharanitharan725@gmail.com>
On Tue, Oct 28, 2025 at 10:01:27AM +0000, Dharanitharan R wrote:
> This patch replaces printk() calls in sun3_82586.c with appropriate pr_*()
> macros (pr_err, pr_info, etc.) according to Linux kernel logging conventions.
You have a Sun3? I've not seen one in maybe 25 years.
https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
says:
1.6.6. Clean-up patches
Netdev discourages patches which perform simple clean-ups, which are
not in the context of other work. For example:
Addressing checkpatch.pl, and other trivial coding style warnings
Addressing Local variable ordering issues
Conversions to device-managed APIs (devm_ helpers)
This is because it is felt that the churn that such changes produce
comes at a greater cost than the value of such clean-ups.
Please state in the commit message if you have run these patches on
hardware, and plan to do other work on the Sun3 driver, new features
etc.
Andrew
---
pw-bot: cr
prev parent reply other threads:[~2025-10-28 13:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 10:01 Dharanitharan R
2025-10-28 13:24 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcb18197-af45-4f7d-a435-39796c51c1e7@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dharanitharan725@gmail.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sammy@sammy.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®