Re: [PATCH net] xsk: Fix error return code in __xp_assign_dev()

[Zhang Changzhong <zhangchangzhong@huawei.com>]

> 
> Good catch! My intention here by not setting err is that it should
> fall back to copy mode, which it does. The problem is that the
> force_zc flag is disregarded when err is not set (see exit code below)
> and your patch fixes that. If force_zc is set, we should exit out with
> an error, not fall back. Could you please write about this in your
> cover letter and send a v2?
> 

Thanks for the suggestion, I have sent the v2 patch, please take another look.

> BTW, what is the "Hulk Robot" that is in your Reported-by tag?

It's an auto tester, here is some information: https://lwn.net/Articles/804119/

> 
> Thank you: Magnus
> 
> err_unreg_xsk:
>         xp_disable_drv_zc(pool);
> err_unreg_pool:
>         if (!force_zc)
>                 err = 0; /* fallback to copy mode */
>         if (err)
>                 xsk_clear_pool_at_qid(netdev, queue_id);
>         return err;
> 
>>                 goto err_unreg_xsk;
>>         }
>>         pool->umem->zc = true;
>> --
>> 2.9.5
>>
> .
>