From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DF303B0AE6 for ; Mon, 27 Apr 2026 09:18:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777281533; cv=none; b=JRW4+jNNEmr6marDj9zdUg8hWm/mDOsta1kPe05uy60MP20VY1aqO0+3kZMjxhvrd7Xz8tKUkeAiIYhxz7j3mMwpsBXDb+Bkf2hOHwhg7G/qRgxFmRQgUJm9UCAQHoU05CFzjbPoU7s+OnQoKW5vbQguWRJsirr2mzSynRPS/4M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777281533; c=relaxed/simple; bh=iaihpzmQLJaEJXDgYPIIeQD9PzsxKMVKLHW33rYRxrY=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=HEIFg13nWr0YiVhHxSqNHL8uhIH53YqyyeuopntoNeWSUZ0LNfUh9v+G3Z26TqicGVwP6+IFPTROZFwDuriBzsjne0bkCQzHF2aLtRSajWkoA+PE27abUZPKCQv22oEGK5z9/CU+/rphRqJwzHwfadP9hK0V5wpMSxo8MngIsRU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OXivKJ4X; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PDj4a3Lq; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OXivKJ4X"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PDj4a3Lq" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63R8T7cf2913796 for ; Mon, 27 Apr 2026 09:18:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Z+NhQmVODRKthYAjn4FjHgsGJoSWaHBLQ4E9hxLiPbk=; b=OXivKJ4XkkXaxrPd NCq9XPIVlvABrqfc8xHO+CvO98Pr+FwOfAPHhGhfTQpdjbo2EctfkKDwr1UmSjZ1 GBnQ8LHQEbBxIJ5Pe7vD0VKQDZh/u4umFuMNsXFxC16G1oKvJjqShWGQDhisG8e1 zVCtpCdbDleuT1WcUc5Vd/s8bOC5ctfnr1kiSFE6wuj0cg+aWWqV4XtDPOm470kD OyDsU0q4fsLCI601eluPgGDyhl3IxlD+n7a3UjVkrTlZBF0hcIf8akNkR9oWBYHc VlDva07vjAsrBEJmXMlFc214tNPjlHB5VC3kB1zm7tmW+rAeP78MkJum6iDwiRHH NdvP7Q== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dt26xgsmg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 27 Apr 2026 09:18:49 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-35d9278587bso12024984a91.2 for ; Mon, 27 Apr 2026 02:18:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777281529; x=1777886329; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=Z+NhQmVODRKthYAjn4FjHgsGJoSWaHBLQ4E9hxLiPbk=; b=PDj4a3LqDwoXUXCwQAfP5HM+Vqwl2laKaJ/JLB6FzHLYOlfpy6QDSNvSsm/miOk6HL Zj5XbDAP+Weu0wErnex8BafpX3l9d5eZfMRJJInGzgfi8b1EZlRIFmwptFHLTFlSnfii 0GhSMmr0tlVd2l6o33YoJSh7nHcGhCmaJFe/W8YGKh9fr0a8QpgwI+i/dSx29B6Xy+Ok BVs7oS1Sp1AoC7brF4ttY7Vd0ygX8Cc9ffMV2EB7xuENY/nT+3zCFGRGH032u8GfWUtC AnYnvnwXnEeJgdM+sVsFuCgX74OZsMPhlfhpYud4RrtPY19YyOEEfC5bSt7V9iJ689ns W1uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777281529; x=1777886329; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Z+NhQmVODRKthYAjn4FjHgsGJoSWaHBLQ4E9hxLiPbk=; b=l+dPtN6YlPjEsgtmpvH07cpN05sBXtgqtBK/GEDrCME+Fr4JmkwCaDIOCJO1B5cCeP WkWTTwI9EJV4V6gKC1G0DCu9f9x3Fh+LV7HPbloo2ZsQVxl6mHVdTqo+hxXB0wsbR3OS f3Xo8O+V6Rc/XOzFjNn3LDlMLUUbeFuWYKleiFegLJ52hXqkBK187oUUm/YEvCZ2VDyj abYaooQubIa0wEZB7sWNlAFpRK18IspvF0aZEKiUWBEp5Lcsbm4zlAgTkW4enFPfWGxo +i9q3dJ4m0D2eou2i0v0StWgjMRi+ONGXTN0a/4dz8LLc7iTDaJ4Jzuozu9TKwW73gCy /uTA== X-Forwarded-Encrypted: i=1; AFNElJ9ET4bVCyI0+PTKC8KIIuJL4E6D/y36R/TFGNEMLvkjEDfgpWFugSEZA341E8CyvOWsbwTjMYg9BpcOKDw=@vger.kernel.org X-Gm-Message-State: AOJu0Yxedm38vXeTAWkxjatBrjLpE6Bjg/ERITBSJuZlSvECsVdXxcVf b0u4BZBvVQJTaVBBeNgH/lTH34NpERkNq2FVrIzukCAFf38XR/6aTCioPGsQYQ1fBWktcGVrqIq ZktpJKyq0em1MROI/sXdfmgV1CToc+31KgeZpSev5YySXgIfdyi73IJG6mRdwPkcX8mc= X-Gm-Gg: AeBDiesQBac6Apko54+lvvHGL67vlvTl5/qMnJukw1hAeUawX/PHKfKpG0phDIpDK2D P3pMhfmCA0+ozbJFTTf1kYRQ37HFDATgvOiUnBFI7VNwi4qdgX9NJTuTXh30AisWp9cR3WUJ2QU QtSE17PXL9v4pnBbtE2YaWWrbcAyaJvr8tiVCSkr+z+GFpKG37yFUEGGNDcubBuDWCOJ5XX3OJI X4vv9hutyWf1TBIpZWh387xiFZfILp9Dl4YvYgDNWVdgA1uJzDBB7PY9XnvmEQ2aqHPGp6CK2HR v0V2OYzse/lkZCJYzw/UpcA546Qpf0BdSIwJWYPrezgP8QhtAp3CJsW7x7MJZP8LNJPZ1jQQXBP JNiUp5epS46id9nlMXtRL2j58e2X/CBIrhRJ6Ej26Nn77Hcp/8xUgydGU7oFEzns= X-Received: by 2002:a17:90b:37cb:b0:35f:d56d:1c45 with SMTP id 98e67ed59e1d1-3614041bc7cmr38625191a91.12.1777281528902; Mon, 27 Apr 2026 02:18:48 -0700 (PDT) X-Received: by 2002:a17:90b:37cb:b0:35f:d56d:1c45 with SMTP id 98e67ed59e1d1-3614041bc7cmr38625158a91.12.1777281528337; Mon, 27 Apr 2026 02:18:48 -0700 (PDT) Received: from [10.218.14.97] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3613f56ecbesm11810292a91.0.2026.04.27.02.18.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Apr 2026 02:18:47 -0700 (PDT) Message-ID: Date: Mon, 27 Apr 2026 14:48:42 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] serial: qcom-geni: Avoid probing debug console UART without console support To: Aniket Randive , gregkh@linuxfoundation.org, jirislaby@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, anup.kulkarni@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com, viken.dadhaniya@oss.qualcomm.com References: <20260413072501.263871-1-aniket.randive@oss.qualcomm.com> Content-Language: en-US From: Praveen Talari In-Reply-To: <20260413072501.263871-1-aniket.randive@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: luTitlghc18lL2Ulp9bGgUcc4VrR9wLJ X-Proofpoint-ORIG-GUID: luTitlghc18lL2Ulp9bGgUcc4VrR9wLJ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI3MDA5OCBTYWx0ZWRfX2k3HbBP3bq/W tNq+fZqguuw2mPiG8dSp5Vq6cgAJz4tZRoQU3OhVYJEepbgPuBWJhNQI6Eq4s5vrO/Z0UR4wORT l0PC2ZUqSf2+1gQ7UlgNt2Myuj8MyzCRwT96c6KObBrH6Y9Fmba49BqQW+SVfCApfpDoCKKtq3Y P0qHikRmJitOgLN6E2BUmyK0SpR6CXzzLKco+OPHhkjchcBRxqloki0SU2cW7KV4M5uJOzs6GwI neOwmDksOY3sM16ap98ba6ileUQj5AHHoQb8DTds9mlVgjHpNabhjJ5WxifovQBchZ0aM87auXX ToNAE2AxgwbihRBukJB+EjxrdyUXC/eLx4u+pdaH4ZlXjLuiScFtwyVDjGklvsuhoI9y6rCX7yy jxsTw9aRd9fa0kCNwzSVAWOIbuUqIBaOO0/aApy64je7Aa2UuV30NUbbjyVio5WCa1lMXJawSw3 h+xqHSU9WASY/Zv67dQ== X-Authority-Analysis: v=2.4 cv=FM8rAeos c=1 sm=1 tr=0 ts=69ef29f9 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=8N2UbNoKPs7AJDuX-gEA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-27_02,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 adultscore=0 bulkscore=0 phishscore=0 spamscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604270098 On 13-04-2026 12:55, Aniket Randive wrote: > When CONFIG_SERIAL_QCOM_GENI_CONSOLE is disabled, the driver still > advertises the debug UART compatible strings ("qcom,geni-debug-uart" > and "qcom,sa8255p-geni-debug-uart") in its of_match table. This lets the > driver match and probe console UART DT nodes even though console > support is not built. As a result, the console port is never registered > with the UART core and uart_add_one_port() fails with -EINVAL. > > Fix this by only including the debug UART compatible entries in the > match table when CONFIG_SERIAL_QCOM_GENI_CONSOLE is enabled, preventing > the driver from probing console UART nodes when console support is > absent. > > Signed-off-by: Aniket Randive > --- > drivers/tty/serial/qcom_geni_serial.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c > index 9854bb2406e3..b756e0c07c16 100644 > --- a/drivers/tty/serial/qcom_geni_serial.c > +++ b/drivers/tty/serial/qcom_geni_serial.c > @@ -2039,6 +2039,7 @@ static const struct dev_pm_ops qcom_geni_serial_pm_ops = { > }; > > static const struct of_device_id qcom_geni_serial_match_table[] = { > +#if IS_ENABLED(CONFIG_SERIAL_QCOM_GENI_CONSOLE) > { > .compatible = "qcom,geni-debug-uart", > .data = &qcom_geni_console_data, > @@ -2047,6 +2048,7 @@ static const struct of_device_id qcom_geni_serial_match_table[] = { > .compatible = "qcom,sa8255p-geni-debug-uart", > .data = &sa8255p_qcom_geni_console_data, > }, > +#endif > { > .compatible = "qcom,geni-uart", > .data = &qcom_geni_uart_data, Reviewed-by: Praveen Talari Thanks, Praveen Talari