From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57FECECDFB8 for ; Wed, 18 Jul 2018 15:28:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1D2F92075C for ; Wed, 18 Jul 2018 15:28:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D2F92075C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731258AbeGRQG2 (ORCPT ); Wed, 18 Jul 2018 12:06:28 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:35874 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731193AbeGRQG1 (ORCPT ); Wed, 18 Jul 2018 12:06:27 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 430E5ED1; Wed, 18 Jul 2018 08:28:02 -0700 (PDT) Received: from [10.1.206.75] (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 086873FAA1; Wed, 18 Jul 2018 08:27:58 -0700 (PDT) Subject: Re: NULL pointer dereference in msi_set_mask_bit To: Paul Menzel , Thomas Gleixner , Bjorn Helgaas Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Hiraku Toyooka , Zou Cao , Lorenzo Pieralisi References: <20180718140636.GD128988@bhelgaas-glaptop.roam.corp.google.com> <6339fdef-a335-b833-4022-23725fd86d9e@molgen.mpg.de> From: Marc Zyngier Organization: ARM Ltd Message-ID: Date: Wed, 18 Jul 2018 16:27:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <6339fdef-a335-b833-4022-23725fd86d9e@molgen.mpg.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/07/18 16:12, Paul Menzel wrote: > Dear Thomas, dear Bjorn, > > > Thank you for your quick responses. > > > On 07/18/18 17:02, Thomas Gleixner wrote: >> On Wed, 18 Jul 2018, Bjorn Helgaas wrote: >>> [+cc Marc, Thomas] >> >> Uurgh. That's definitely what I need right now ... :) >> >>> On Wed, Jul 18, 2018 at 03:28:15PM +0200, Paul Menzel wrote: >>>> >>>> 93.885: [ 23.020572] BUG: unable to handle kernel NULL pointer dereference at 000000000000003c >>>> 93.885: [ 23.029011] PGD 0 P4D 0 >>>> 93.885: [ 23.031670] Oops: 0000 [#1] SMP NOPTI >>>> 93.885: [ 23.035455] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.18.0-rc5+ #1 >>>> 93.885: [ 23.042079] Hardware name: MSI MS-7A37/B350M MORTAR (MS-7A37), BIOS 1.G1 05/17/2018 >>>> 93.886: [ 23.049868] RIP: 0010:msi_set_mask_bit+0xe/0x70 >> >>>> 93.913: [ 23.049868] Code: 00 53 48 89 fb e8 12 f8 ff ff 48 89 df 5b e9 c9 fe ff ff 66 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 53 48 8b 47 10 48 8b 58 10 43 3c 01 74 3c 8b 15 2e 85 21 01 31 c0 85 d2 75 25 8b 43 38 48 >> >> f6 43 3c 01 testb $0x1,0x3c(%rbx) >> >> That's: >> >> if (desc->msi_attrib.is_msix) > > Is there a tool to translate that? > >>>> 93.957: [ 23.049880] RSP: 0018:ffff9e8e5e803f78 EFLAGS: 00010046 >>>> 93.957: [ 23.049881] RAX: ffff9e8e45919000 RBX: 0000000000000000 RCX: 0000000000000000 >>>> 93.958: [ 23.049882] RDX: ffff9e8e45919000 RSI: 0000000000000001 RDI: ffff9e8e45919098 >>>> 93.958: [ 23.049882] RBP: ffff9e8e45919098 R08: 0000000000000000 R09: 0000000000000000 >>>> 93.958: [ 23.049882] R10: 0000000000000000 R11: 0000000000000000 R12: ffff9e8e45919000 >>>> 93.958: [ 23.049883] R13: 0000000000000027 R14: 0000000000000000 R15: 0000000000000000 >>>> 93.959: [ 23.049884] FS: 0000000000000000(0000) GS:ffff9e8e5e800000(0000) knlGS:0000000000000000 >>>> 93.959: [ 23.049884] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 >>>> 93.959: [ 23.049885] CR2: 000000000000003c CR3: 00000003fc5a4000 CR4: 00000000003406f0 >>>> 93.959: [ 23.049885] Call Trace: >>>> 93.959: [ 23.049887] >>>> 93.960: [ 23.049889] __irq_move_irq+0x3c/0x70 >>>> 93.960: [ 23.049892] apic_ack_irq+0x2b/0x30 >>>> 93.960: [ 23.049893] handle_edge_irq+0x7d/0x1d0 >>>> 93.960: [ 23.049895] handle_irq+0x1f/0x30 >>>> 93.960: [ 23.049898] do_IRQ+0x41/0xc0 >>>> 93.960: [ 23.049899] common_interrupt+0xf/0xf >>>> 93.961: [ 23.049900] >> >> and desc comes from irq_data->common->msi_desc >> >> I have no idea how that can happen for an MSI interrupt. >> >> Paul, is this reproducible? > > No, unfortunately not. I only hit this once, since I attached the serial > console. > > But I found others having the same(?) problem [1][2]. > > > Kind regards, > > Paul > > > [1]: https://lkml.org/lkml/2018/1/16/122 > "[PATCH 0/1] PCI/MSI: add NULL check before use of msi_desc" > [2]: https://marc.info/?l=linux-kernel&m=151321815226439&w=2 > "[PATCH] PCI: designware: add a check of msi_desc in irqchip" > This seems to be a very different issue. These PCI host controllers pre-allocate a bunch of irqdescs which are not bound to any MSI yet (this occurs much later, when the interrupt is actually allocated to a device). But the kexec code tries to mask all interrupts, including some of these half baked interrupts, and bad things happen. This is very much a case of "don't do that". Unless I'm grossly mistaken, this isn't what happens in your case (the interrupt is very much active, but the msi_desc pointer has vanished). M. -- Jazz is not dead. It just smells funny...