From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FF781EEA4C for ; Wed, 15 Jan 2025 09:55:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736934959; cv=none; b=CtwCKYQIHOKQzF7lvsaiRwVPyu1tMNrRNdboaOU96gbC2s1MdBRy1tjIdq5ahCppeTpCn6JZLhGRaIOZsAMkiuX1mzODmeuRMpJK1Q42EfhDFoZmdbLBemHw+8uAkZQiOdOC5dGSAf+FqocIQGKU2G7T6Lw2ht84VcWXLAvbDm0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736934959; c=relaxed/simple; bh=We43O5rrPUW/jR0XpmrifDmF9C2pqWHCM/vGuU/YcDI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FEZOSSHIVgrkJhiuzM01MZ7Zd5OhmvLfzpItVJYj/IxG3FH43SB6+vhvCaxwg1eHbpPpkGbmVMe9zZQ+RiLQzKnQi21tHYDLkc/Xtx6zkTYIOrEmuLaMC1EG+zp6q0BVOB81ZgsjPRly79OtszOzzj9CC+2JHgebqJ+80on9wps= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=rup4ZTWO; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=KlpMRZEp; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=rup4ZTWO; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=KlpMRZEp; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="rup4ZTWO"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="KlpMRZEp"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="rup4ZTWO"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="KlpMRZEp" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8E4562122A; Wed, 15 Jan 2025 09:55:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1736934955; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=weD20aehtOjo/bZftakV2RdUJ+MSvWHGdrEZIJAk29w=; b=rup4ZTWOd+qLCGeOgLUQHWA+oyUzPPWwSF48XoVUf9gxBqi3F6pFWJSFskPWazAzVMNAML IGAgXUHMSSCY3OXuO2Qvm9LKPPQWxoqpWNJDIJIfpx4uhpEPoqlpxz9j919AGnISxYFWJ7 xxgtImfG0O3zm4UExp1I85X4HGrsrZY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1736934955; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=weD20aehtOjo/bZftakV2RdUJ+MSvWHGdrEZIJAk29w=; b=KlpMRZEprZ4RF62gB3mQivxxXlUledsAnFFsZzBWPqlebAijOLEAKm1KVzdTYRYSUWCllw Qz9TfzNJy8Pmc0DA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1736934955; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=weD20aehtOjo/bZftakV2RdUJ+MSvWHGdrEZIJAk29w=; b=rup4ZTWOd+qLCGeOgLUQHWA+oyUzPPWwSF48XoVUf9gxBqi3F6pFWJSFskPWazAzVMNAML IGAgXUHMSSCY3OXuO2Qvm9LKPPQWxoqpWNJDIJIfpx4uhpEPoqlpxz9j919AGnISxYFWJ7 xxgtImfG0O3zm4UExp1I85X4HGrsrZY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1736934955; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=weD20aehtOjo/bZftakV2RdUJ+MSvWHGdrEZIJAk29w=; b=KlpMRZEprZ4RF62gB3mQivxxXlUledsAnFFsZzBWPqlebAijOLEAKm1KVzdTYRYSUWCllw Qz9TfzNJy8Pmc0DA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 57196139CB; Wed, 15 Jan 2025 09:55:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id CYbgEyuGh2fDHwAAD6G6ig (envelope-from ); Wed, 15 Jan 2025 09:55:55 +0000 Message-ID: Date: Wed, 15 Jan 2025 10:55:54 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/panel-edp: Add BOE NV140FHM-N4Z panel entry To: Doug Anderson , Andy Yan Cc: quic_jesszhan@quicinc.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, neil.armstrong@linaro.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20250113085956.2150207-1-andyshrk@163.com> <34a1058f.9829.1945f2b448c.Coremail.andyshrk@163.com> <341c653.7fa6.194640f0f37.Coremail.andyshrk@163.com> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Level: X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.997]; MIME_GOOD(-0.10)[text/plain]; FREEMAIL_TO(0.00)[chromium.org,163.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RCPT_COUNT_SEVEN(0.00)[8]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; FREEMAIL_ENVRCPT(0.00)[163.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FUZZY_BLOCKED(0.00)[rspamd.com]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid] X-Spam-Score: -4.30 X-Spam-Flag: NO Hi Am 14.01.25 um 17:44 schrieb Doug Anderson: > > FWIW it's good that Thomas replied to your patch, since that was the > only thing that showed up in my inbox. Your initial patch showed up as > spam for me. :( Not sure why, though... FTR, my R-b was for the code itself. I did not verify if the values are meaningful/correct. Best regards Thomas > > >>>> diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c >>>> index 94a46241dece..a3402b76aa3e 100644 >>>> --- a/drivers/gpu/drm/panel/panel-edp.c >>>> +++ b/drivers/gpu/drm/panel/panel-edp.c >>>> @@ -1909,6 +1909,7 @@ static const struct edp_panel_entry edp_panels[] = { >>>> EDP_PANEL_ENTRY('B', 'O', 'E', 0x0ac5, &delay_200_500_e50, "NV116WHM-N4C"), >>>> EDP_PANEL_ENTRY('B', 'O', 'E', 0x0ae8, &delay_200_500_e50_p2e80, "NV140WUM-N41"), >>>> EDP_PANEL_ENTRY('B', 'O', 'E', 0x0b34, &delay_200_500_e80, "NV122WUM-N41"), >>>> + EDP_PANEL_ENTRY('B', 'O', 'E', 0x0b09, &delay_200_500_e50_p2e200, "NV140FHM-NZ"), >>>> EDP_PANEL_ENTRY('B', 'O', 'E', 0x0b43, &delay_200_500_e200, "NV140FHM-T09"), > This is mis-sorted. 0xb09 should be _before_ 0x0b34. I'll often fix > this up when applying (though it's more work for me), but since I had > a question above about delay_200_500_e50_p2e200 vs. > delay_200_500_e50_p2e80 maybe you can answer and also send a v2 with > the sort order fixed. > > -Doug -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)