From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f170.google.com (mail-vk1-f170.google.com [209.85.221.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 758D73D9DA8 for ; Thu, 6 Aug 2026 16:59:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786035582; cv=none; b=R5AGvf3iT2WGwKca54Y5b2eybmLPyEk4u3mZJbYJ6s108E5ki1ZujXHH9P9xIybTAqpkfBOs5gPMTv5aFUWL6vX7rJUA7f2k9LwCo7EDDZXp0rU2DIRVXymdXvnT1RbUzJi6dwzwX1Pm4H8h36qFfQQ1Wpe/JHxzdtvz99SESLo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786035582; c=relaxed/simple; bh=tpriWxWOl+J6JwWfTTr6TdF9jz0JsOXJvxWyKOuU9Fk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AVGKwzwsvspARZgjOcfz80U6rDV21mUtzSOcaXEzDC/SWZYXKftbYtKMPwzjjw/BCYsr7yi6izuvx8zUvwz00G8CY6g+AnRZe0DholPDxKb3qqp8NtIG2gmR28YegC4BXE97Tj/UB5676+ObzIExCazDAAzg70ZL26rBmLVdcx4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bo0d+42b; arc=none smtp.client-ip=209.85.221.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bo0d+42b" Received: by mail-vk1-f170.google.com with SMTP id 71dfb90a1353d-5c27e38ee18so1233968e0c.1 for ; Thu, 06 Aug 2026 09:59:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786035579; x=1786640379; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=duwKRHlWbKUb/BOL4rfzAJNO2P4dXrVaNM+8BQLZ4gY=; b=bo0d+42bvRuWcxvl9oRfa245IM6mXsp/UqtsZ81UG6HCbTeG1P+89qWhMg8tJj/TtC I2TEUZCbYsLqS/GjLCMj92lPj2KygZ+5Y5YGbsLsKmEqHGMQxRL8vkOYyPOronlXlGkk l3ZKvlAgM8OuXeMl3nxvjLosaZ00O6z7tkbSRPMkr7t0jhMVXfot1TXvK9W3RujchWgN i13gt9oN58lUIbPpUI2yLkX5chiNtH6AQOHtXPXSmw3KaGjNy5S3ICbPlSC731OCsTwb DGGIWgjIHseapbdUvrjtrpH5Gu9gNUSmiI9YqVOlazDSLSF8anKVNDTHLkKgu8hBZUnt WUaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786035579; x=1786640379; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=duwKRHlWbKUb/BOL4rfzAJNO2P4dXrVaNM+8BQLZ4gY=; b=Eaodikif3dYV2mA7Q5keo/EptJtQcpZ8VmkFGWhG2KwqGagG3Lu3nlDYCFjLtFEys3 733MzwOKjgfI9SRZBZn6NC98GehjMVUfY8u3jRUzQ/CWsyFyOdVh+UevRcKi/AEtz73j z7cNJHar43nqYgG4JRLkpJy6NVBOEVqusGPngBavU/VO3IdP1CvbKvNuXi3ZWIG+NPf3 kFiQ2F9Jr7RUfn8SraFUaSaOe5Mj57PB4I8hUGoEcHRoCRrA9V2YBVfye7Kxa0uuprOi y7ir0iCDH/6w0sfuDaJ7zac5Du3Qx74VA8ka0Orf/jZ/fiTsTZWdRZgOI2ElNAlidXXX AvaQ== X-Forwarded-Encrypted: i=1; AHgh+RpbqsHgxmAgQGD0SGMedGSuPwqNyLIeSubfeHxY9U8UWxTtQx2Vt1sqR6xjI09fw9tFgtnIETqJZsuw/dY=@vger.kernel.org X-Gm-Message-State: AOJu0YwD49q8v47N9FzMB7q0Pgjl6H6ozT7DrOs8lVC9Rq1lSHwuyKfC NMlbs8Lvs+QwT+3ZgEHnnfB9aYxfSO73gBdviINJ2Y3Zdn8Cw91Ot5FU X-Gm-Gg: AR+sD10B8Pgr+HVBxe61wyForIN+VRcGZy5RAojsBzCli1qP9yR8JShnyVG3juLVomI FamlxUxuaJ/xgKKMpj7Afa2X/X9W/JJFXhxamel3GI1qH7jBcwcBq3QXDKhdql+G+X1mXP61wDB Evod4pFje45VZ+QVkA02uN/WMr7qf2lq8oJjSZHJwYh15Q65MZUYJwa7ZfftW8qkr9nys9KVGPI 8cFgd2VpxO+Z6XkUSSR50AbJ+SXgGILsQ6EJFgfWmlfPAeco/LyfSw9TyvQpYNgqqamdUcv6QHn /VY17V4cAU0YP3koyKpxKhw/IaRA+oODJYUgPcR/Gfn7o95A/xoE1X4xO1EoEv8q9tFEslCTH1b kl08KBVrStiaN39VkJ9+ZOXUOeb+oy+XWx0jveFQ0x/v19euyPysi+5+LOiMKLkOxQpl99SLf7X XuV5HGcVAsjxwiEkcS1GMVcd/sZRJmsrvyYh7jHbu7/J0uLcWbj/2wlz1oB2pgp8G2WXykA9ji+ FH6i1D4FgEaBIfrHg== X-Received: by 2002:a05:6122:3d0e:b0:5bd:b27c:bace with SMTP id 71dfb90a1353d-5c3d926476emr2526056e0c.14.1786035579340; Thu, 06 Aug 2026 09:59:39 -0700 (PDT) Received: from syssplab.cs.fiu.edu (nat1.cs.fiu.edu. [131.94.134.89]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-5c3d05c594fsm3706321e0c.8.2026.08.06.09.59.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Aug 2026 09:59:38 -0700 (PDT) From: Chao Shi To: Jan Kara , Christian Brauner , Alexander Viro , Matthew Wilcox , linux-fsdevel@vger.kernel.org Cc: Theodore Ts'o , Andreas Dilger , Baokun Li , Ojaswin Mujoo , Ritesh Harjani , Zhang Yi , Zhang Yi , Bob Copeland , Namjae Jeon , Sungjong Seo , Yuezhang Mo , OGAWA Hirofumi , Mark Fasheh , Joel Becker , Joseph Qi , Andreas Gruenbacher , linux-ext4@vger.kernel.org, ocfs2-devel@lists.linux.dev, gfs2@lists.linux.dev, linux-kernel@vger.kernel.org, Chao Shi , Weidong Zhu Subject: [PATCH v2 09/21] ext2: check for an xattr block write error with buffer_write_io_error() Date: Thu, 6 Aug 2026 12:58:32 -0400 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ext2_xattr_set2() spots a failed synchronous write by testing BH_Req together with !BH_Uptodate. That relies on the write completion handler clearing BH_Uptodate on error, which this series removes: a buffer whose write failed still holds the data the filesystem asked to be written, so declaring it not up to date is wrong and makes callers re-read it. BH_Write_EIO says exactly what this code wants to know, and it implies BH_Req, so the pair collapses into one test. No behaviour change today - a failed write sets BH_Write_EIO and clears BH_Uptodate together. It stops being a no-op at the end of the series, where the new test is the one that still works. Acked-by: Weidong Zhu Signed-off-by: Chao Shi Reviewed-by: Jan Kara --- fs/ext2/xattr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext2/xattr.c b/fs/ext2/xattr.c index be63f89402a3..39005ec23fe5 100644 --- a/fs/ext2/xattr.c +++ b/fs/ext2/xattr.c @@ -769,7 +769,7 @@ ext2_xattr_set2(struct inode *inode, struct buffer_head *old_bh, if (IS_SYNC(inode)) { sync_dirty_buffer(new_bh); error = -EIO; - if (buffer_req(new_bh) && !buffer_uptodate(new_bh)) + if (buffer_write_io_error(new_bh)) goto cleanup; } } -- 2.43.0