From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC6F3C433F5 for ; Tue, 18 Jan 2022 04:25:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233113AbiAREZZ (ORCPT ); Mon, 17 Jan 2022 23:25:25 -0500 Received: from relay027.a.hostedemail.com ([64.99.140.27]:15689 "EHLO relay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S233044AbiAREZR (ORCPT ); Mon, 17 Jan 2022 23:25:17 -0500 Received: from omf16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2DCB320475; Tue, 18 Jan 2022 04:25:16 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf16.hostedemail.com (Postfix) with ESMTPA id E7F432001C; Tue, 18 Jan 2022 04:24:59 +0000 (UTC) Message-ID: Subject: Re: list iterator spacing: clang-format vs checkpatch From: Joe Perches To: Miguel Ojeda Cc: "Jason A. Donenfeld" , Andrew Lunn , LKML Date: Mon, 17 Jan 2022 20:25:14 -0800 In-Reply-To: References: <3cbaf145ee577f017cf7aea953c9dd1eb88ed4b4.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.4-1ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E7F432001C X-Stat-Signature: qi4ktfquwo79jr8fu3z4ogbpuxg67bdp X-Rspamd-Server: rspamout02 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX18BhtU6qcDvG3gHGdeUH/1IdGuOT3+Qt/c= X-HE-Tag: 1642479899-135833 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2022-01-17 at 22:41 +0100, Miguel Ojeda wrote: > Yeah, for `clang-format` I tried to be conservative having only > `include/`, but we could change that. There are more #defines outside of include/ than inside: $ git grep -P '^\s*#\s*define\s+\w*for_each\w*\(' -- '*.[ch]' | \ grep -P -v '^(?:include|tools)/' | wc -l 613 $ git grep -P '^\s*#\s*define\s+\w*for_each\w*\(' -- 'include/*.[ch]' | \ wc -l 469