From: Hans de Goede <hansg@kernel.org>
To: "Nickolay Goppen" <setotau@mainlining.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: dell-lis3lv02d: Add Latitude E6530
Date: Sat, 20 Sep 2025 22:15:12 +0200 [thread overview]
Message-ID: <fcd107c9-ff59-464f-aead-7b2bcc05dce9@kernel.org> (raw)
In-Reply-To: <20250917-dell-lis3lv02d-latitude-e6530-v1-1-8a6dec4e51e9@mainlining.org>
Hi,
On 17-Sep-25 9:10 PM, Nickolay Goppen wrote:
> Add 0x29 as the accelerometer address for the Dell Latitude E6530 to
> lis3lv02d_devices[].
>
> The address was verified as below:
>
> $ cd /sys/bus/pci/drivers/i801_smbus/0000:00:1f.3
> $ ls -d i2c-*
> i2c-20
> $ sudo modprobe i2c-dev
> $ sudo i2cdetect 20
> WARNING! This program can confuse your I2C bus, cause data loss and worse!
> I will probe file /dev/i2c-20.
> I will probe address range 0x08-0x77.
> Continue? [Y/n] Y
> 0 1 2 3 4 5 6 7 8 9 a b c d e f
> 00: 08 -- -- -- -- -- -- --
> 10: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
> 20: -- -- -- -- -- -- -- -- -- UU -- 2b -- -- -- --
> 30: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
> 40: -- -- -- -- 44 -- -- -- -- -- -- -- -- -- -- --
> 50: UU -- 52 -- -- -- -- -- -- -- -- -- -- -- -- --
> 60: -- 61 -- -- -- -- -- -- -- -- -- -- -- -- -- --
> 70: -- -- -- -- -- -- -- --
> $ cat /proc/cmdline
> BOOT_IMAGE=/vmlinuz-linux-cachyos-bore root=UUID=<redacted> rw loglevel=3 quiet dell_lis3lv02d.probe_i2c_addr=1
> $ sudo dmesg
> [ 0.000000] Linux version 6.16.6-2-cachyos-bore (linux-cachyos-bore@cachyos) (gcc (GCC) 15.2.1 20250813, GNU ld (GNU Binutils) 2.45.0) #1 SMP PREEMPT_DYNAMIC Thu, 11 Sep 2025 16:01:12 +0000
> […]
> [ 0.000000] DMI: Dell Inc. Latitude E6530/07Y85M, BIOS A22 11/30/2018
> […]
> [ 5.166442] i2c i2c-20: Probing for lis3lv02d on address 0x29
> [ 5.167854] i2c i2c-20: Detected lis3lv02d on address 0x29, please report this upstream to platform-driver-x86@vger.kernel.org so that a quirk can be added
>
> Signed-off-by: Nickolay Goppen <setotau@mainlining.org>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hansg@kernel.org>
Regards,
Hans
> ---
> Add 0x29 as the accelerometer address for the Dell Latitude E6530 to
> lis3lv02d_devices[].
> ---
> drivers/platform/x86/dell/dell-lis3lv02d.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/dell/dell-lis3lv02d.c b/drivers/platform/x86/dell/dell-lis3lv02d.c
> index 732de5f556f83b4f91fbf174986331c02c2a5c79..77905a9ddde9dd5d44a3193d053fb3d4e319ceb8 100644
> --- a/drivers/platform/x86/dell/dell-lis3lv02d.c
> +++ b/drivers/platform/x86/dell/dell-lis3lv02d.c
> @@ -48,6 +48,7 @@ static const struct dmi_system_id lis3lv02d_devices[] __initconst = {
> DELL_LIS3LV02D_DMI_ENTRY("Latitude 5500", 0x29),
> DELL_LIS3LV02D_DMI_ENTRY("Latitude E6330", 0x29),
> DELL_LIS3LV02D_DMI_ENTRY("Latitude E6430", 0x29),
> + DELL_LIS3LV02D_DMI_ENTRY("Latitude E6530", 0x29),
> DELL_LIS3LV02D_DMI_ENTRY("Precision 3540", 0x29),
> DELL_LIS3LV02D_DMI_ENTRY("Precision 3551", 0x29),
> DELL_LIS3LV02D_DMI_ENTRY("Precision M6800", 0x29),
>
> ---
> base-commit: 038d61fd642278bab63ee8ef722c50d10ab01e8f
> change-id: 20250917-dell-lis3lv02d-latitude-e6530-7c389cca4893
>
> Best regards,
next prev parent reply other threads:[~2025-09-20 20:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-17 19:10 Nickolay Goppen
2025-09-20 20:15 ` Hans de Goede [this message]
2025-09-23 9:27 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcd107c9-ff59-464f-aead-7b2bcc05dce9@kernel.org \
--to=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=setotau@mainlining.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®