From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01997335067 for ; Fri, 16 Oct 2026 02:17:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.134.164.83 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792117069; cv=none; b=uVaYBMcz2aUageI1RyUK2KcrIP1uNx3JncmRtB/VkID6mJHDyiTx1TCJACoPWzeYdiXSwp/KltynVDRDEQOYJJdrIUasYZ1WuHF4HKBJWA1TFxa01FjkaJ2kHGxBIygdgZEoi56RTazRVnFmUiWBoECaE7En/GMABw8zwJK59O0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792117069; c=relaxed/simple; bh=8CVjULxw1Qae8Qz6Vwp8+Ozk2dvMPLfvrgZOdhJxKdQ=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=nhUusQEXDh8aQBNRmMTG6P2bTaStHr5kteHpk8XMTGQZZgPf5gfTx/VL7PCmFI/L18p/Ckreix/5Lmv/Y3WSipEFrDRlR3Z+sYExIpwp5WRRvYpDJMKHXM4fm9yoyMyu5Fs35bzM3xNPYFmP45SXcMBuzEUHz5mrz2k3XiDjbyU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inria.fr; spf=pass smtp.mailfrom=inria.fr; dkim=pass (1024-bit key) header.d=inria.fr header.i=@inria.fr header.b=lhH97SQU; arc=none smtp.client-ip=192.134.164.83 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inria.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=inria.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=inria.fr header.i=@inria.fr header.b="lhH97SQU" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=qSKq1SQxgrg3nMP6/wpK9hSRG2aMAkgSMQurDxr0tnM=; b=lhH97SQUvly31jMdMdb5xenP2oszSt1WN89c81icY9eK1LqI20gkX1em ETSZAoPtjJ1LYC0tZpWfi3T2TUpFYGEHbLQFfuilb4fJeLweC0GlifUYH mREPzND9ajFVFPn7jeYosabFvbOcRDm072sj0wgToS0P6YYQ8zfhokqyl s=; X-CSE-ConnectionGUID: DEb1+WoYT0mGWeFYXLSQ5A== X-CSE-MsgGUID: PINxWsyBR3maTnnRMwdIuw== Authentication-Results: mail2-relais-roc.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=julia.lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="6.27,161,1787004000"; d="scan'208";a="300457787" Received: from static.host-68-71-1-178.nrbn.ca (HELO hadrien) ([68.71.18.178]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2026 04:17:37 +0200 Date: Thu, 15 Oct 2026 22:17:35 -0400 (EDT) From: Julia Lawall To: Okhuomon Ajayi cc: outreachy@lists.linux.dev, Johan Hovold , Alex Elder , Greg Kroah-Hartman , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: greybus: add blank lines after struct definitions in gbphy.h In-Reply-To: <20261015222735.89251-1-okhuomonajayi54@gmail.com> Message-ID: References: <20261015222735.89251-1-okhuomonajayi54@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 15 Oct 2026, Okhuomon Ajayi wrote: > Add blank lines between the structure definitions and the > to_gbphy_dev() and to_gbphy_driver() macros to improve > readability. This fixes the following checkpatch warning: Thanks for the patch. But I suspect that the lack of a newline was intentional, to show that the #define is closely associated with the previous structure declaration. julia > > CHECK: Please use a blank line after function/struct/union/enum > declarations > > Signed-off-by: Okhuomon Ajayi > --- > drivers/staging/greybus/gbphy.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/staging/greybus/gbphy.h b/drivers/staging/greybus/gbphy.h > index d4a225b76338..1de510499480 100644 > --- a/drivers/staging/greybus/gbphy.h > +++ b/drivers/staging/greybus/gbphy.h > @@ -15,6 +15,7 @@ struct gbphy_device { > struct list_head list; > struct device dev; > }; > + > #define to_gbphy_dev(d) container_of(d, struct gbphy_device, dev) > > static inline void *gb_gbphy_get_data(struct gbphy_device *gdev) > @@ -43,6 +44,7 @@ struct gbphy_driver { > > struct device_driver driver; > }; > + > #define to_gbphy_driver(d) container_of(d, struct gbphy_driver, driver) > > int gb_gbphy_register_driver(struct gbphy_driver *driver, > -- > 2.43.0 > > >