From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752477AbdHKDEf (ORCPT <rfc822;w@1wt.eu>);
        Thu, 10 Aug 2017 23:04:35 -0400
Received: from szxga04-in.huawei.com ([45.249.212.190]:3506 "EHLO
        szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752133AbdHKDEe (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 10 Aug 2017 23:04:34 -0400
Subject: Re: [PATCH -next] zram: fix compr_data_size stat
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
References: <1502413832-13560-1-git-send-email-xieyisheng1@huawei.com>
 <20170811013553.GB520@jagdpanzerIV.localdomain>
 <20170811013839.GC520@jagdpanzerIV.localdomain>
 <d0ef1425-ef1b-f92e-4b51-2432aac570c4@huawei.com>
CC: <akpm@linux-foundation.org>, <minchan@kernel.org>, <ngupta@vflare.org>,
        <linux-kernel@vger.kernel.org>
From: Yisheng Xie <xieyisheng1@huawei.com>
Message-ID: <fce532a8-eef7-22c1-e60d-e02901299d39@huawei.com>
Date: Fri, 11 Aug 2017 11:00:49 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.1.0
MIME-Version: 1.0
In-Reply-To: <d0ef1425-ef1b-f92e-4b51-2432aac570c4@huawei.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.177.29.40]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
        refid=str=0001.0A020205.598D1E00.0105,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
        ip=0.0.0.0,
        so=2014-11-16 11:51:01,
        dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 2dde5897bbf7672041d0e1d31503cba4
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 2017/8/11 10:07, Yisheng Xie wrote:
> 
> 
> On 2017/8/11 9:38, Sergey Senozhatsky wrote:
>> On (08/11/17 10:35), Sergey Senozhatsky wrote:
>>> On (08/11/17 09:10), Yisheng Xie wrote:
>>>> The compr_data_size is a stat for compressed size of pages stored, which
>>>> should add comp_len when we compresse a page.
>>>>
>>>> Meanwhile fix typos in comment:
>>>> * ZRAM_SAME means page consists the same element not the entirely zero page
>>>> * read_from_bdev_async() return 1 to avoid call page_endio() in zram_rw_page()
>>>>
>>>> Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
>>>
>>> Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
>>
>> seems that some of the changes can be folded into the existing -next patches.
> 
> Yes, feel free to fold it :)
> 
> I find Minchan is removing zram_rw_page(), so maybe the return value of
> read_from_bdev_async and write_to_bdev can be re-writed, it seems we need to
I mean no need to (sorry for typo.)
> call page_endio() depend these return value anymore, after delete zram_rw_page().
> 
> Thanks
> Yisheng Xie
> 
> 
> .
>