mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Joshua Crofts <joshua.crofts1@gmail.com>,
	Juerg Haefliger <juergh@proton.me>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: (dme1737) Replace ternary operators with str_yes_no()
Date: Sun, 12 Jul 2026 11:17:10 -0700	[thread overview]
Message-ID: <fceb5317-8dca-4aeb-bd01-e7e1c9a65ab1@roeck-us.net> (raw)
In-Reply-To: <20260712-add-string-choices-dme1737-v1-1-9c2b1f31db28@gmail.com>

On 7/12/26 10:58, Joshua Crofts wrote:
> Remove the ternary operators and use str_yes_no() from string_choices.h
> instead.
> 
> No functional change.
> 
> Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>

This is an extremely old driver which does not support the latest
hardware monitoring API.

Please refrain from making non-functional changes in such drivers.

NACK

Thanks,
Guenter


  reply	other threads:[~2026-07-12 18:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-12 17:58 Joshua Crofts
2026-07-12 18:17 ` Guenter Roeck [this message]
2026-07-12 18:26   ` Joshua Crofts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fceb5317-8dca-4aeb-bd01-e7e1c9a65ab1@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=joshua.crofts1@gmail.com \
    --cc=juergh@proton.me \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®