From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753554AbcHQRQ4 (ORCPT ); Wed, 17 Aug 2016 13:16:56 -0400 Received: from us01smtprelay-2.synopsys.com ([198.182.60.111]:43711 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753483AbcHQRQz (ORCPT ); Wed, 17 Aug 2016 13:16:55 -0400 Subject: Re: [PATCH] ARC: Change ld.as instruction to regular ld. To: Liav Rehana References: <1471415037-14544-1-git-send-email-liavr@mellanox.com> CC: "noamca@mellanox.com" , "linux-snps-arc@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "eladkan@mellanox.com" From: Vineet Gupta Message-ID: Date: Wed, 17 Aug 2016 10:16:44 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1471415037-14544-1-git-send-email-liavr@mellanox.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.9.130.119] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/16/2016 11:24 PM, Liav Rehana wrote: > From: Liav Rehana > > User mode callee regs are explicitly collected before signal delivery > or breakpoint trap. r25 is special for kernel as it serves as task > pointer, so user mode value is clobbered very early. It is saved in > pt_regs where generally only scratch (caller saved) res are saved. > The code to access the corresponding pt_regs location had a subtle bug > as it was using load/store with scaling of offset, whereas the offset > was already byte wise correct. So fix this by replacing LD.AS with a > standard LD > > Signed-off-by: Liav Rehana Thx for the fix Liv. I added it to my for-curr. -Vineet