From: "Yang, Weijiang" <weijiang.yang@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "likexu@tencent.com" <likexu@tencent.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH] KVM: selftests: x86: Skip unsupported test when Arch LBR is available
Date: Wed, 11 May 2022 08:26:53 +0800 [thread overview]
Message-ID: <fcec0903-69ed-078a-5abd-c9d4198eca4b@intel.com> (raw)
In-Reply-To: <20220510150637.1774645-1-pbonzini@redhat.com>
On 5/10/2022 11:06 PM, Paolo Bonzini wrote:
> Hi,
>
>> - ret = _vcpu_set_msr(vm, 0, MSR_IA32_PERF_CAPABILITIES, PMU_CAP_LBR_FMT);
>> - TEST_ASSERT(ret == 0, "Bad PERF_CAPABILITIES didn't fail.");
>> + /* Note, on Arch LBR capable platforms, LBR_FMT in perf capability msr is 0x3f,
>> + * so skip below test if running on these platforms. */
>> + if (host_cap.lbr_format != PMU_CAP_LBR_FMT) {
>> + ret = _vcpu_set_msr(vm, 0, MSR_IA32_PERF_CAPABILITIES, PMU_CAP_LBR_FMT);
>> + TEST_ASSERT(ret == 0, "Bad PERF_CAPABILITIES didn't fail.");
>> + }
> Why not try a different value?
OK, I'll select a "real" invalid format and re-post the patch, thanks!
>
> Paolo
>
>
prev parent reply other threads:[~2022-05-11 0:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 3:50 Yang Weijiang
2022-05-10 15:06 ` Paolo Bonzini
2022-05-11 0:26 ` Yang, Weijiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcec0903-69ed-078a-5abd-c9d4198eca4b@intel.com \
--to=weijiang.yang@intel.com \
--cc=kvm@vger.kernel.org \
--cc=likexu@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome