From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02CEF1487F9 for ; Thu, 22 Aug 2024 16:12:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724343124; cv=none; b=Zu2KT3sLdFnDaCyy6rBCR9kYn5CdmDhw536A7v0040IEcE3XSCyLQHoHNBOq7SJbq22y5+36Ztv3iQi6iXgcDu4O7KGepLDiSC9Rodes8L2u6sXytnk4j7SsHUPzleTk6YnqNZqUz8gpgR1n72DUCNu0Ialw+ml6MbRRgXcPhHM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724343124; c=relaxed/simple; bh=DUFIzbM49ayGk8TDuaa+D9IjNb2QVa5H15QNOTPC7ek=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ouLrpVMREhcjpjn00vv5TrnMe1VPEgLTPluZPmX+yP6ixri7UaUYNAJU5O7y+2By+YjtsIfl0vj6XlfGnQ4ZS9qIT3kql43JkctXh5rL2mL0XYBjoDqOQ3pwJAGuWQ4Hc6WL4WmehL9vZ41iSTxS9a5ayQBv4dT7PSsOrUZE3nc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=SGr/Vlk8; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SGr/Vlk8" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-42816ca782dso7400725e9.2 for ; Thu, 22 Aug 2024 09:12:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1724343121; x=1724947921; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pSDYqJH1si4MkbMiG6MIY0frUysj56sL53IfastzRmk=; b=SGr/Vlk8Vb1hoCOEQAF5TYL9pcf45giAf3G5SZCYq72aVs2Zjeh4aazVQu8WZrnGmo /fn1L7s6jpR8+ZRIoSzMqjzTPqhlK8bwWW1jO4/2Mj3YDxhDP0g99+EE7dQ1XtYNTzLn xQp6AfjkeFTGToQys2TvIEg+tHkCdeUAnAVrc6VkveRc25omM7aD5ch+91C/2QKZkRQM FfEQCIOXDBc+/aVhinO4ZgMnBclVaBKsKbICE9NDbnr/Do+J43hGcbfRW7WSfjhPlZFy 7/gI64zPm96I89dIBwZWE8L5mau6pzlp9KBrcyYEgk7zXONb2Guiyk1kviNs6xcdRV4L GXPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724343121; x=1724947921; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pSDYqJH1si4MkbMiG6MIY0frUysj56sL53IfastzRmk=; b=QmfLlL/zMOyVs7Hb1G+S22MX3mN766maP/PgusaMEJTCD6pmGKTsMBwmQOwXZy3+re r5mnzJWQh2QgacIsenOHdv43MW22TAR4UC1S+sZF33dBFc66tEQ9cioosb9e4oTCG3gt fAQJuYTx8adhB8XppK3mJ591AHYDzhco70xiCFABT+yajSCM/MM8OWs/2/iVEZFZnoJW GzRBV4f657SPbh6Z2rgaBktpk7ku2bIPkASNZEswuVHbQMkAJkWIQxoLZi4S76X7+Bin 8CAbS34HXmGgyAmxEo64K5lBG7N5HiVwSwKE0z9cuF+s64o9DGd5N7XlcJpqB/FppoA0 vfAQ== X-Forwarded-Encrypted: i=1; AJvYcCVtKV7eCDi5AjU0OWw2GHIQD4rZeyXux1yy/GH9OlhQwrGs3ltG1ul8GtNGMb/RInLq84oG5Mv9bWhL+Co=@vger.kernel.org X-Gm-Message-State: AOJu0YzfIj1yPAcvimfy4apYOWL34H6gxJQWYxH4RXzxP4mZUbLYVOzY RXIjE/zdEXL4zi/lWI2m6A5CiftWCKDH+ZDcBnkt4x+uQ519dXlnIXOoWgIHDpM= X-Google-Smtp-Source: AGHT+IFZqDsp1CF3lOTkEOu7V8psQXqYpLsfhY0Xkrzat3bAfnpj+viOdmLGRiF/xSCPjrHM9qzCAQ== X-Received: by 2002:a05:600c:5114:b0:426:60bc:8f4e with SMTP id 5b1f17b1804b1-42abd21f5e8mr42160345e9.5.1724343120777; Thu, 22 Aug 2024 09:12:00 -0700 (PDT) Received: from [192.168.10.46] (146725694.box.freepro.com. [130.180.211.218]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-42ac5159555sm28976255e9.18.2024.08.22.09.12.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Aug 2024 09:12:00 -0700 (PDT) Message-ID: Date: Thu, 22 Aug 2024 18:11:59 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] thermal: of: Fix OF node leak in of_thermal_zone_find() error paths To: Krzysztof Kozlowski , "Rafael J. Wysocki" , Zhang Rui , Lukasz Luba , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org References: <20240814195823.437597-1-krzysztof.kozlowski@linaro.org> <20240814195823.437597-3-krzysztof.kozlowski@linaro.org> Content-Language: en-US From: Daniel Lezcano In-Reply-To: <20240814195823.437597-3-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 14/08/2024 21:58, Krzysztof Kozlowski wrote: > Terminating for_each_available_child_of_node() loop requires dropping OF > node reference, so bailing out on errors misses this. Solve the OF node > reference leak with scoped for_each_available_child_of_node_scoped(). > > Fixes: 3fd6d6e2b4e8 ("thermal/of: Rework the thermal device tree initialization") > Cc: > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Daniel Lezcano -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog