From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8790DC28CC0 for ; Wed, 29 May 2019 12:23:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 63BC821670 for ; Wed, 29 May 2019 12:23:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726932AbfE2MX5 (ORCPT ); Wed, 29 May 2019 08:23:57 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:35942 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725894AbfE2MX5 (ORCPT ); Wed, 29 May 2019 08:23:57 -0400 Received: by mail-pg1-f196.google.com with SMTP id a3so1287892pgb.3 for ; Wed, 29 May 2019 05:23:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=rxy6f9sl7ikW/ApsyD3MIdMjQRls/RXr9QjpSHSk8IA=; b=jDzxhqIYLFb0yi7Z6BGzA4wmQ6Whxjw5kkQKeB6DThnM7UZnTeRkrJIRvZe46P8UO8 HmAWw83CmNxyh6bcZoSCt5vEJyyRLVMxepExSStk6DCIYiP49TJ7nhMXn2xiEltBr7MA WvNr1foWeUyFa/CzI7y3TPKBZXnRQhHdRX3e/6l4gXtkfD/NEmu1Hrodjxgp0y+pO2Uh vK+8gIb45pKcu/nEFkmuC2jEUDhfbsieLgGQ/sNgNR1XAtP0k/FMnTRWb+6IFb492v2/ NGA70XZin1NNXdRIGTY8zewXQ2M6Pw207vhxDROvMARTPwc9/rO1znAA0a9v3eB02P58 Fclg== X-Gm-Message-State: APjAAAXs5D02KuWU3AMEDjPUOz+0QXgEqtjweZVfMpWCTMvcvhqy8IU/ fyGzV0yHZiCyQZoAEpJ0z7WyMGek X-Google-Smtp-Source: APXvYqw3gtP9GYIe9PKp/7Bwfo/J4hxf31+bvFoTQDtU0F9p+8zHqc+Inc7h1cd1ACTxH/qzERMEvw== X-Received: by 2002:a17:90a:778b:: with SMTP id v11mr12193208pjk.132.1559132635974; Wed, 29 May 2019 05:23:55 -0700 (PDT) Received: from asus.site (c-67-188-93-131.hsd1.ca.comcast.net. [67.188.93.131]) by smtp.gmail.com with ESMTPSA id e16sm5619309pjp.16.2019.05.29.05.23.54 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Wed, 29 May 2019 05:23:55 -0700 (PDT) Subject: Re: [dm-devel] [PATCH] dm-init: fix 2 incorrect use of kstrndup() To: Gen Zhang , agk@redhat.com, snitzer@redhat.com, dm-devel@redhat.com Cc: linux-kernel@vger.kernel.org References: <20190529013320.GA3307@zhanggen-UX430UQ> From: Bart Van Assche Openpgp: preference=signencrypt Autocrypt: addr=bvanassche@acm.org; prefer-encrypt=mutual; keydata= mQENBFSOu4oBCADcRWxVUvkkvRmmwTwIjIJvZOu6wNm+dz5AF4z0FHW2KNZL3oheO3P8UZWr LQOrCfRcK8e/sIs2Y2D3Lg/SL7qqbMehGEYcJptu6mKkywBfoYbtBkVoJ/jQsi2H0vBiiCOy fmxMHIPcYxaJdXxrOG2UO4B60Y/BzE6OrPDT44w4cZA9DH5xialliWU447Bts8TJNa3lZKS1 AvW1ZklbvJfAJJAwzDih35LxU2fcWbmhPa7EO2DCv/LM1B10GBB/oQB5kvlq4aA2PSIWkqz4 3SI5kCPSsygD6wKnbRsvNn2mIACva6VHdm62A7xel5dJRfpQjXj2snd1F/YNoNc66UUTABEB AAG0JEJhcnQgVmFuIEFzc2NoZSA8YnZhbmFzc2NoZUBhY20ub3JnPokBOQQTAQIAIwUCVI67 igIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEHFcPTXFzhAJ8QkH/1AdXblKL65M Y1Zk1bYKnkAb4a98LxCPm/pJBilvci6boefwlBDZ2NZuuYWYgyrehMB5H+q+Kq4P0IBbTqTa jTPAANn62A6jwJ0FnCn6YaM9TZQjM1F7LoDX3v+oAkaoXuq0dQ4hnxQNu792bi6QyVdZUvKc macVFVgfK9n04mL7RzjO3f+X4midKt/s+G+IPr4DGlrq+WH27eDbpUR3aYRk8EgbgGKvQFdD CEBFJi+5ZKOArmJVBSk21RHDpqyz6Vit3rjep7c1SN8s7NhVi9cjkKmMDM7KYhXkWc10lKx2 RTkFI30rkDm4U+JpdAd2+tP3tjGf9AyGGinpzE2XY1K5AQ0EVI67igEIAKiSyd0nECrgz+H5 PcFDGYQpGDMTl8MOPCKw/F3diXPuj2eql4xSbAdbUCJzk2ETif5s3twT2ER8cUTEVOaCEUY3 eOiaFgQ+nGLx4BXqqGewikPJCe+UBjFnH1m2/IFn4T9jPZkV8xlkKmDUqMK5EV9n3eQLkn5g lco+FepTtmbkSCCjd91EfThVbNYpVQ5ZjdBCXN66CKyJDMJ85HVr5rmXG/nqriTh6cv1l1Js T7AFvvPjUPknS6d+BETMhTkbGzoyS+sywEsQAgA+BMCxBH4LvUmHYhpS+W6CiZ3ZMxjO8Hgc ++w1mLeRUvda3i4/U8wDT3SWuHcB3DWlcppECLkAEQEAAYkBHwQYAQIACQUCVI67igIbDAAK CRBxXD01xc4QCZ4dB/0QrnEasxjM0PGeXK5hcZMT9Eo998alUfn5XU0RQDYdwp6/kMEXMdmT oH0F0xB3SQ8WVSXA9rrc4EBvZruWQ+5/zjVrhhfUAx12CzL4oQ9Ro2k45daYaonKTANYG22y //x8dLe2Fv1By4SKGhmzwH87uXxbTJAUxiWIi1np0z3/RDnoVyfmfbbL1DY7zf2hYXLLzsJR mSsED/1nlJ9Oq5fALdNEPgDyPUerqHxcmIub+pF0AzJoYHK5punqpqfGmqPbjxrJLPJfHVKy goMj5DlBMoYqEgpbwdUYkH6QdizJJCur4icy8GUNbisFYABeoJ91pnD4IGei3MTdvINSZI5e Message-ID: Date: Wed, 29 May 2019 05:23:53 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190529013320.GA3307@zhanggen-UX430UQ> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/28/19 6:33 PM, Gen Zhang wrote: > In drivers/md/dm-init.c, kstrndup() is incorrectly used twice. > > It should be: char *kstrndup(const char *s, size_t max, gfp_t gfp); Should the following be added to this patch? Fixes: 6bbc923dfcf5 ("dm: add support to directly boot to a mapped device") # v5.1. Cc: stable Thanks, Bart.