From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1CCB3DE436 for ; Mon, 18 May 2026 07:33:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779089606; cv=none; b=FkjW81W+R5y1N7eDvOw9hbKVz1XEF7HCrV4l4j9QYNxKSgpFOneJfDgCZuFCqatVtoKt6rX/GH8a0bLHInUB27c77YVcoGbIUjG/EG9D+sAV9TZL9x+njJ25JFMHzsSDyHBAKjzxr+3lrbWI7MbwgJCxjPpsxitXoeTtdiikhZs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779089606; c=relaxed/simple; bh=/JNfde5mdHiSGSpMzP/oSsfMy0pc4LJ61vF+9SM49Tk=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=hLE8UfplWTjcmwBDsX11+sDBKd0p5j75S2liQXsmihHETW9jCdevZ8U4oYyYI3MKOtPUzGAFFD6UCdHB5Vco7bFRPKgoc/T6Ww8u3K6tKsJ0JMlc6XKpf0ATdWWv8p9aoir6RYM9AblxUrE5CjlAfFk3EcSztSV15DoqnABq5E0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Q1EaNd7Q; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Q1EaNd7Q" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-488d2079582so17536505e9.2 for ; Mon, 18 May 2026 00:33:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1779089603; x=1779694403; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=clpT2YharvcVfa0IwFBAz/k89nyFUXl+DAfU0fPRXA8=; b=Q1EaNd7Qmhze/6wb3Qw54OhJkTnu36u7hjaaDppo24fKze5O3i0VN+KxEJWOwJ8hSX deKL0TyhmsYsgk4yjEn+gpHtxK/2wEqhbKYeEOppXb7zEIO+sZhKcdxWA4KGtLCqKZkC Cj3HfEcvV3zVa+7tKn1OAsSO3lTMSZ16Uq5MpmzGGGV/Luwl1NKV8c3HCQAKEyn9lH2p g/Ytrsybl4fDn1TExuSmhTDula4aXLU/hYvEvlzit4hw5GYhP64wgEMd8zjS3OJVOEcv zLyOUw8nEr8S9ZaUTBfsHs7wwGuNtPnbuy6rNCMGhMupCLf3pa9HjG0lT1hC0Jy4g7QD TaFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779089603; x=1779694403; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=clpT2YharvcVfa0IwFBAz/k89nyFUXl+DAfU0fPRXA8=; b=A66RBT0Vin6iWPmw0oRiWCj4sgk6Ha4m1aUKF3hJyrXWPt7xNOhxA5TH9JBI8dlW+j qNoZNX6LzsySC/eJgeIVaqo8FbnLOoBA0+MvyNOw7b204TOGwLFB0IueWv2usmBAXLZa 8SHzDieWw+3hhPRk8BseveRFoKu/sWOrDkxw6XVzaS4+THHHwIkwnAUlf/TGWdX6RvJo upipAnvLWOQwZeKxeQTshdqLVbOjzcluCZJ6Cc3RxRu1NOkk6X8ao3T76bYrOZOj2qZt PnQRxS86Vm3WgsTJ9zn8oVUYFzqzqrtlM2C03lheIc6pdOba3iLoiCjJrp1H3joX8mm6 q5ew== X-Forwarded-Encrypted: i=1; AFNElJ8+BVWXhzFKryo0ZhPGVNbtH4BAzUSmQZMaM8tTztUmi7w827iLQLFy/OhigxYnsDpDJkRTF+sHut6FblE=@vger.kernel.org X-Gm-Message-State: AOJu0YxedAvPjS5JCAEPn8g9AGY/kvFMIhHSqfzC3dNLFjcWe2j6luMb BVDIMLEljnwc8ZJLaXRh3mV8eVSgoxn1YLXV7qa3DVnMYqdwIpqij3nUCHPKHFA3aM8= X-Gm-Gg: Acq92OFjykVIRZZkvxoa3um+CMWOd9kE9y36vwl81xPSWr61fQv8jV807neNOUejyfd gdwveI4FE60d1tLBvez7QytuJnlrrF6aN/rvYwShKpKv+Dalq5TAjEcVViBbBRvSOd74ikl2AFZ RNMHi7GKD+D1JifXkP8/hpsYONtzslSibTZcCmqH0g4s96xef7/jTGWOlqW5IYlMTd5aGWiTdOY 2hToovJF3Kb7RINAXC7nmybLkAUrSw4pFVq5PiqOa4R8KbYIMWeKJZTQE+ED0J6Hy0rNW/kINb/ D35RWBxj1lbNs9/fOVkPTL9T6SWjHhgz7Zi8pAsRx+4+fOwWm/OUQQbXRTk+6sM4aDMKfpvSmmO DVMi/ye9mrnJCtXkYyQasE96SQPDub1iFySY+0xFen5ZZku+lR69njutRPI5+Aahqehk0QmDeMj puq5h0NWJfDxL0gZqaXXOAJSSXQNa2iSLioSq+GlUinWLYJ9jNAbMxX/izST6NU9hQCwPw3ToIJ WtG X-Received: by 2002:a05:600c:848c:b0:48f:d0f1:ed28 with SMTP id 5b1f17b1804b1-48fe60e4e32mr210022875e9.1.1779089603090; Mon, 18 May 2026 00:33:23 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:64e2:72b:b9ed:6dcf? ([2a01:e0a:106d:1080:64e2:72b:b9ed:6dcf]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fe5cab882sm241034035e9.13.2026.05.18.00.33.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 May 2026 00:33:22 -0700 (PDT) Message-ID: Date: Mon, 18 May 2026 09:33:22 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH v3 4/6] media: qcom: iris: vdec: update size and stride calculations for 10bit formats To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260511-topic-sm8x50-iris-10bit-decoding-v3-0-7fc049b93042@linaro.org> <20260511-topic-sm8x50-iris-10bit-decoding-v3-4-7fc049b93042@linaro.org> <8ee8e01e-fc55-4786-9c28-48fb17bf2a44@oss.qualcomm.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <8ee8e01e-fc55-4786-9c28-48fb17bf2a44@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 5/13/26 21:05, Vikash Garodia wrote: > > > On 5/11/2026 2:50 PM, Neil Armstrong wrote: >> Update the gen2 response and vdec s_fmt code to take in account >> the P010 and QC010 when calculating the width, height and stride. >> >> Signed-off-by: Neil Armstrong >> --- >>   .../platform/qcom/iris/iris_hfi_gen2_response.c    | 21 ++++++++++++++++--- >>   drivers/media/platform/qcom/iris/iris_vdec.c       | 24 +++++++++++++++++++--- >>   2 files changed, 39 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c >> index 8e19f61bbbf9..0541e02d7507 100644 >> --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c >> +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c >> @@ -542,9 +542,24 @@ static void iris_hfi_gen2_read_input_subcr_params(struct iris_inst *inst) >>       pixmp_ip->width = width; >>       pixmp_ip->height = height; >> -    pixmp_op->width = ALIGN(width, 128); >> -    pixmp_op->height = ALIGN(height, 32); >> -    pixmp_op->plane_fmt[0].bytesperline = ALIGN(width, 128); >> +    switch (pixmp_op->pixelformat) { >> +    case V4L2_PIX_FMT_P010: >> +        pixmp_op->width = ALIGN(width, 128); >> +        pixmp_op->height = ALIGN(height, 32); >> +        pixmp_op->plane_fmt[0].bytesperline = ALIGN(width * 2, 256); >> +        break; >> +    case V4L2_PIX_FMT_QC10C: >> +        pixmp_op->width = roundup(width, 192); >> +        pixmp_op->height = ALIGN(height, 16); >> +        pixmp_op->plane_fmt[0].bytesperline = ALIGN(pixmp_op->width * 4 / 3, 256); >> +        break; >> +    case V4L2_PIX_FMT_NV12: >> +    case V4L2_PIX_FMT_QC08C: >> +        pixmp_op->width = ALIGN(width, 128); >> +        pixmp_op->height = ALIGN(height, 32); >> +        pixmp_op->plane_fmt[0].bytesperline = pixmp_op->width; >> +        break; > > client facing api, good to have a default here > >> +    } >>       pixmp_op->plane_fmt[0].sizeimage = iris_get_buffer_size(inst, BUF_OUTPUT); >>       matrix_coeff = subsc_params.color_info & 0xFF; >> diff --git a/drivers/media/platform/qcom/iris/iris_vdec.c b/drivers/media/platform/qcom/iris/iris_vdec.c >> index 99d544e2af4f..eea69f937147 100644 >> --- a/drivers/media/platform/qcom/iris/iris_vdec.c >> +++ b/drivers/media/platform/qcom/iris/iris_vdec.c >> @@ -266,10 +266,28 @@ int iris_vdec_s_fmt(struct iris_inst *inst, struct v4l2_format *f) >>           fmt = inst->fmt_dst; >>           fmt->type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE; >>           fmt->fmt.pix_mp.pixelformat = f->fmt.pix_mp.pixelformat; >> -        fmt->fmt.pix_mp.width = ALIGN(f->fmt.pix_mp.width, 128); >> -        fmt->fmt.pix_mp.height = ALIGN(f->fmt.pix_mp.height, 32); >>           fmt->fmt.pix_mp.num_planes = 1; >> -        fmt->fmt.pix_mp.plane_fmt[0].bytesperline = ALIGN(f->fmt.pix_mp.width, 128); >> +        switch (f->fmt.pix_mp.pixelformat) { >> +        case V4L2_PIX_FMT_P010: >> +            fmt->fmt.pix_mp.width = ALIGN(f->fmt.pix_mp.width, 128); >> +            fmt->fmt.pix_mp.height = ALIGN(f->fmt.pix_mp.height, 32); >> +            fmt->fmt.pix_mp.plane_fmt[0].bytesperline = >> +                ALIGN(f->fmt.pix_mp.width * 2, 256); >> +            break; >> +        case V4L2_PIX_FMT_QC10C: >> +            fmt->fmt.pix_mp.width = roundup(f->fmt.pix_mp.width, 192); > > ALIGN ? ALIGN only works with Power-Of-Two numbers, so we can't use ALIGN here. > >> +            fmt->fmt.pix_mp.height = ALIGN(f->fmt.pix_mp.height, 16); >> +            fmt->fmt.pix_mp.plane_fmt[0].bytesperline = >> +                ALIGN(f->fmt.pix_mp.width * 4 / 3, 256); >> +            break; >> +        case V4L2_PIX_FMT_NV12: >> +        case V4L2_PIX_FMT_QC08C: >> +            fmt->fmt.pix_mp.width = ALIGN(f->fmt.pix_mp.width, 128); >> +            fmt->fmt.pix_mp.height = ALIGN(f->fmt.pix_mp.height, 32); >> +            fmt->fmt.pix_mp.plane_fmt[0].bytesperline = >> +                ALIGN(f->fmt.pix_mp.width, 128); >> +            break; >> +        } >>           fmt->fmt.pix_mp.plane_fmt[0].sizeimage = iris_get_buffer_size(inst, BUF_OUTPUT); >>           inst->buffers[BUF_OUTPUT].min_count = iris_vpu_buf_count(inst, BUF_OUTPUT); >>           inst->buffers[BUF_OUTPUT].size = fmt->fmt.pix_mp.plane_fmt[0].sizeimage; >> >