From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763125AbdJRJO3 (ORCPT ); Wed, 18 Oct 2017 05:14:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43708 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763096AbdJRJOX (ORCPT ); Wed, 18 Oct 2017 05:14:23 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com ED1E95D68C Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=hdegoede@redhat.com Subject: Re: [PATCH v3 10/14] extcon: intel-int3496: Add support for controlling the USB-role mux To: Chanwoo Choi , MyungJoo Ham , Guenter Roeck , Heikki Krogerus , Darren Hart , Andy Shevchenko , Peter Rosin , Mathias Nyman Cc: linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, devel@driverdev.osuosl.org, Kuppuswamy Sathyanarayanan , Sathyanarayanan Kuppuswamy Natarajan , Greg Kroah-Hartman , linux-usb@vger.kernel.org References: <20170922183803.10701-1-hdegoede@redhat.com> <20170922183803.10701-10-hdegoede@redhat.com> <59E6BD6A.4020101@samsung.com> From: Hans de Goede Message-ID: Date: Wed, 18 Oct 2017 11:14:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <59E6BD6A.4020101@samsung.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 18 Oct 2017 09:14:23 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 18-10-17 04:33, Chanwoo Choi wrote: > Hi Hans, > > On 2017년 09월 23일 03:37, Hans de Goede wrote: >> Cherry Trail SoCs have a built-in USB-role mux for switching between >> the host and device controllers, rather then using an external mux >> controller by a GPIO. >> >> There is a driver using the mux-subsys to control this mux, this >> commit adds support to the intel-int3496 driver to get a mux_controller >> handle for the mux and set the mux through the mux-subsys rather then >> through a GPIO. >> >> Signed-off-by: Hans de Goede >> --- >> Changes in v2: >> -Drop || COMPILE_TEST from Kconfig depends on, as we will now fail to >> compile on !X86 >> -Minor code style tweaks >> --- >> drivers/extcon/Kconfig | 3 +- >> drivers/extcon/extcon-intel-int3496.c | 59 +++++++++++++++++++++++++++++++++++ >> 2 files changed, 61 insertions(+), 1 deletion(-) > > Acked-by: Chanwoo Choi Note that there have been some comments on this series, and it is not sure yet how we are going to end up handling this. So please do not merge this yet, as we may end up with another solution. Regards, Hans