From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 687A2237A38 for ; Mon, 13 Jan 2025 13:58:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736776735; cv=none; b=t72zs5ZBKg5HOuY87Y2KR25l1yNv/Ms6+HxBREbGGDjkgdKfny3tg0ciB8RLmhtGc+NPthSgIYDC/K+BQQ1aE4T56AQl2odVucNooz94zmyfsAZNPFqb+ILkjP0Q+x3NpEAvoFGvknSP6M5vE0Y66xJqEzSCmE5l7taQLr5Gv6g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736776735; c=relaxed/simple; bh=Fxot0/yllsfFV5MpcU+4oD888BMjMbr6+B9CyzdSk2A=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=r9hg1N9LNtsEeFW/Yhd3uheGAucUG4ttOcg588OIINO5uFnntLLARTGr1UblyTGRhwro43vp5m/owRu7e4P8nsjXcNbAxbDUdvEjBSL1lE+gP1V66jqMXL4cXL/+s+S73r+gPl341oS1dxZ4wLGqZuUHVhpMKivAMLhBZCqyN28= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=dGb0uA4y; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="dGb0uA4y" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1736776731; bh=Fxot0/yllsfFV5MpcU+4oD888BMjMbr6+B9CyzdSk2A=; h=Date:Subject:To:References:From:In-Reply-To:From; b=dGb0uA4y3MK0iODtk5hcPqliinJfUVu12AvzbkKAuD8ezo4OmZyvS7IqIolui1RMS fHnjAGS1j66g3CZbVWjyVxp1QVMlb+ZsFnQGBdKql1h6Z9IJVcHciM8fwUQm1GikTs r+upWgRknwrFxnxkrjvsybcMpVV17TJs4oBAR330FbfX3hZefckL0goxO/nJNV0u0t 2BHDmKYRr1Y87xF9ohjzRcuhH/0AZU6kCVfqU5u0jzDHi14GEV1IzcQjx2Fcv4ESTs jGQg6mJ2XTwxzklEDB8arc/sIy5aDexGFU7rypzRxKmf61eSpHaVt/O73ylf+98xlI oz1oKPUYaFQJg== Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id E245117E0E64; Mon, 13 Jan 2025 14:58:50 +0100 (CET) Message-ID: Date: Mon, 13 Jan 2025 14:58:50 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] drm/mediatek/hdmi: Use syscon_regmap_lookup_by_phandle_args To: Krzysztof Kozlowski , Chun-Kuang Hu , Philipp Zabel , David Airlie , Simona Vetter , Matthias Brugger , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20250112134708.46100-1-krzysztof.kozlowski@linaro.org> <516d16e3-6fc6-49ba-a0ce-f451b65a6c1a@collabora.com> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Il 13/01/25 14:05, Krzysztof Kozlowski ha scritto: > On 13/01/2025 13:41, AngeloGioacchino Del Regno wrote: >> Il 12/01/25 14:47, Krzysztof Kozlowski ha scritto: >>> Use syscon_regmap_lookup_by_phandle_args() which is a wrapper over >>> syscon_regmap_lookup_by_phandle() combined with getting the syscon >>> argument. Except simpler code this annotates within one line that given >>> phandle has arguments, so grepping for code would be easier. >>> >>> There is also no real benefit in printing errors on missing syscon >>> argument, because this is done just too late: runtime check on >>> static/build-time data. Dtschema and Devicetree bindings offer the >>> static/build-time check for this already. >>> >> >> I agree with this change but can you please rebase it over [1]? >> >> The same code got migrated to mtk_hdmi_common.c instead :-) >> >> [1]: >> https://lore.kernel.org/r/20250108112744.64686-1-angelogioacchino.delregno@collabora.com > My is 2-patch cleanup, your is 34 patch rework and new features with > existing build reports, so rebase is not reasonable. It would make this > 2-patch cleanup wait for many cycles. > If adding the `#include ` line to a file would take *many cycles*, that'd be a bit weird, wouldn't it? :-) Regards, Angelo