From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8ED8EC83F01 for ; Sat, 26 Aug 2023 13:38:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232675AbjHZNiU (ORCPT ); Sat, 26 Aug 2023 09:38:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231960AbjHZNiR (ORCPT ); Sat, 26 Aug 2023 09:38:17 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FF702115 for ; Sat, 26 Aug 2023 06:38:15 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-500aed06ffcso1201667e87.0 for ; Sat, 26 Aug 2023 06:38:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693057093; x=1693661893; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=G9SgFDv7E50+Hpq3nmjKvqF8IQ9dgI58NUkPjP5JpyY=; b=Bv6/6wDWhD8YabIZkVDDIT4xOSLkR+SqRA/51bt56W+8k0L6XZjKivwQfd+cmhSchQ YfQlwmE89P5JBitroJRAPyV5g0sIpaKYf9rmKxTvdV4vK4JmVcYNF5llsmhiOLs0sOzt 6oEQVOIeiueSmldFz4fXOMlu03J5+Tf10XDvUkhLIwjlFzWALqlC28rYYuYU2Veb4W4q X7d52oWkKXQnAJFMFULMOOjp4LZAV/FO26zwhLrJJlxPa1tfsGmtoHpDUuMr85hqLCyc jpGWQ2DX09YT0hw1FlvqNXhLohp5V8YiTyc1eeu7e/2OaHPFM21Dnikxfv3DU6yRirF8 4faw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693057093; x=1693661893; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=G9SgFDv7E50+Hpq3nmjKvqF8IQ9dgI58NUkPjP5JpyY=; b=iCYkirMTDT0YZWmswDLJpp7AI2H6343hzDmZIyy8opRM1LbQPP4kR4Xm4pk9I3KhKx zxGV/pF6XMmXFn+0CbZ0wSnVQOlBkk7QXYELKWRmxrH5I3W4o7N930RProdMQnQwGQJZ 1b0g5u6OlVzYbfgunY9vJiWLApA9+E2icofC0OrAj4j9updm/l8j0CoKcnjoeIVoSezG rvCsBQBwbq2rs0pvZ+UhYFNc4Xo60TQaOl+LKWF+nJA4CPTJzTQ9GkqmtTxkNtLI4oWY HgcOAmONRKdEirAuV8lPJWgzUjIoDhUkQhyKnv/xG7BZdW/wuKd/vqQC6LgdEe3+9h9k tdIA== X-Gm-Message-State: AOJu0Ywb+1/ysT/I8+SXB7TDoHu6m/WoOU7XO3CqQnOABX1IgV1Y8ojV T3xlhn+7y1rLjZ4/WQFE698Qwg== X-Google-Smtp-Source: AGHT+IGOOe4NRVVciDOLuPW6zZbQIteqXBz8Yh+SmQkl8iB5eV4JI2+u5ly9aQKtcUeyZkQTpITxEQ== X-Received: by 2002:a05:6512:11e3:b0:4fb:ca59:42d7 with SMTP id p3-20020a05651211e300b004fbca5942d7mr14104758lfs.33.1693057093505; Sat, 26 Aug 2023 06:38:13 -0700 (PDT) Received: from [192.168.1.101] (abyl74.neoplus.adsl.tpnet.pl. [83.9.31.74]) by smtp.gmail.com with ESMTPSA id e5-20020ac25465000000b005008cd93961sm714187lfn.192.2023.08.26.06.38.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 26 Aug 2023 06:38:13 -0700 (PDT) Message-ID: Date: Sat, 26 Aug 2023 15:38:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/6] media: platform: venus: Add optional LLCC path Content-Language: en-US To: Bryan O'Donoghue , Stanimir Varbanov , Vikash Garodia , Andy Gross , Bjorn Andersson , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Marijn Suijten , Konrad Dybcio , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230731-topic-8280_venus-v1-0-8c8bbe1983a5@linaro.org> <20230731-topic-8280_venus-v1-4-8c8bbe1983a5@linaro.org> <78d2fd56-804d-827b-d074-b139cf62a498@linaro.org> From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: <78d2fd56-804d-827b-d074-b139cf62a498@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4.08.2023 23:04, Bryan O'Donoghue wrote: > On 04/08/2023 21:09, Konrad Dybcio wrote: >> Some newer SoCs (such as SM8350) have a third interconnect path. Add >> it and make it optional. >> >> Signed-off-by: Konrad Dybcio >> --- [...] > I would scream if someone left me this comment but... > > In probe we have > > video_path = > cpu_cfgpath = > > llc_path = > > suspend > > icc_set_bw(cpu_cfgpath,); > icc_set_bw(llc_path,); > icc_set_bw(video_path,); > > resume > icc_set_bw(video_path,); > icc_set_bw(llc_path,); > icc_set_bw(cpu_cfgpath,); suspend == resume[::-1] is totally the right thing, but I'll reorder things in probe for your viewing pleasure Konrad