From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1030490AbcIXTvF (ORCPT <rfc822;w@1wt.eu>);
        Sat, 24 Sep 2016 15:51:05 -0400
Received: from mout.web.de ([217.72.192.78]:64378 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S965050AbcIXTvD (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 24 Sep 2016 15:51:03 -0400
Subject: Re: Input-gameport: Replace some printk() calls by pr_info() in
 joydump_connect()
To: Joe Perches <joe@perches.com>
References: <d8da8333-d83a-ca61-b887-7fd7528c63a4@users.sourceforge.net>
 <f486d64d-0759-9cd6-1e4e-df723acb6fea@users.sourceforge.net>
 <1474733610.23838.2.camel@perches.com>
 <8164eb48-e3fa-fa9d-6351-f14b595a6dc3@users.sourceforge.net>
 <1474735656.23838.6.camel@perches.com>
Cc: linux-input@vger.kernel.org,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org,
        Julia Lawall <julia.lawall@lip6.fr>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <fd0413a5-d181-8ee1-37bb-f47cc8a7ac45@users.sourceforge.net>
Date: Sat, 24 Sep 2016 21:50:54 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <1474735656.23838.6.camel@perches.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:FWLn/XCKedAVBbEhYbWP0eyfZlyhUN3kN1Zw2gNxpOG+jmAfbMv
 o3V4qs4snFuZvAKfg2M1GtEs3YNpaFboziSKG+UYGZu/gJDncBGeDvGLPHPMB8pIll1hm2C
 4fvvN9tHipOsPxYIrURSAarjZ3e264dVa62mQ0GvKVHbVFz5Gle6FQRDAih+AT8QXWUeG7s
 OmBLgYN4zZzCGoQPYnP7Q==
X-UI-Out-Filterresults: notjunk:1;V01:K0:kaN+UbQIz1M=:T16/X+bR4hTFr3LKyI5U4B
 LaqmRjjUtvydBUhgftTlElcYvT+ogrbtssrEXBbeDZac8A7AZP/0ZcsuGMypby8MnMRoE3Azm
 jVXD19YQ0D2O3g26ApHuKdHS1I402yWctCK+9tXcgV4C8RYaZKfLQ2J6oIM5dPQX+zAGwEYqG
 hPTQOc/8bKOmanlnkiuZgGsSWxghEs4XrRfg6rjx8F5rgamZIsSOY8EQ0jq+mhzh5AIK5xRBF
 akYY/4bTDiEaMbc4s3XVi5xdaWUAwFUcux9+MZjgbn36K4OClxPVkRnJTsptSaNtTYLgaYm4w
 xHRMuyzumNdiSHHcHR0T4Zczb/u2wXRaFs/8VIV4KzigPW5kIkKfyTVvWR+Rj+AD+PPs6BhwS
 XIpHK/4/buKamIVpfEJmn6xOD5jHuJ8RJ9onDHJ2BfSo3C+CKDcp5WBEwJTdu/CmWFA1MQpPW
 SmD49o7geZBnicnJ4gwXykbOX0K8qNcLyrQDQAtLyd4oqukwYVL5WzQJiHUASjbyZlDz6360Y
 6U5DtOH2dD5mDUa+xCHuI+EX/Jwt6+nvJVX2zPsnkJ6qvN1Hc16Vwcul8i2l4z8iSRzoTWTxw
 WKdPFDl7J8vcUYu6hLki6C+H2XM26BdB7rDgDI4169u77yayItXA69JglZi/jCatWHVUwevko
 8nGQhKO82htV5OzyAn9091Say4e84mmJNqWG6ONqs+yZzA2nDShI955D+wB0rNdMSZg1DP7U2
 7ZG5HS0ISlWDg2ExbZq7ov/HhyFmWJDjyNaSUDoKPPRXcZOUR1odR98yXHcGaf2zqGU7w6ta3
 aVc5El9
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> Should the desired output be the same when the relevant data are passed by a single function call
>> (instead of three as before)?
> 
> Adding a singleton for a pr_fmt #define constant string and
> updating the printk subsystem to prepend that constant string
> to each use of a pr_<level> at runtime would be an improvement
> as it could reduce constant data used by the format strings.

Thanks for for this constructive feedback.


> That would be a _real_ improvement.

This sounds interesting for me too.


> Please try to implement something like that before submitting
> more of these incorrect patches.

Nice wish!

Did any other software developer try to implement such enhanced
logging functionality already?

Regards,
Markus