mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: "Toralf Förster" <toralf.foerster@gmx.de>,
	netdev@vger.kernel.org, "Kees Cook" <kees.cook@canonical.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: may I ignore "net/core/rtnetlink.c:3156:1: warning: the frame size of 1280 bytes ..."?
Date: Sun, 04 Nov 2018 09:15:45 -0800	[thread overview]
Message-ID: <fd0ac892e8a290d808adb4ee025778660539afc6.camel@perches.com> (raw)
In-Reply-To: <0cfb892c-b358-4bd6-f7c9-071a0039bc71@gmx.de>

On Sun, 2018-11-04 at 17:14 +0100, Toralf Förster wrote:
> compiling recent kernel (4.18.x, 4.19.1) at my server I do still get :
> 
> 
> net/core/rtnetlink.c: In function ‘rtnl_newlink’:
> net/core/rtnetlink.c:3156:1: warning: the frame size of 1280 bytes is larger than 1024 bytes [-Wframe-larger-than=]
> 
> 
> with "gcc version 7.3.0 (Gentoo Hardened 7.3.0-r3 p1.4) " and do wonder whether it is safe to ignore it?
> 

This was introduce by a desire to eliminate variable length array
declarations by

commit ccf8dbcd062a930e64741c939ca784d15316aa0c
Author: Kees Cook <
keescook@chromium.org>
Date:   Wed May 30 15:20:52 2018 -0700

    rtnetlink: Remove VLA usage

It does make the stack use here unfortunately obviously large, but
it could have been this large, just unreported.

Perhaps no obvious solution here as an alloc instead of stack use
may be costly.


  reply	other threads:[~2018-11-04 17:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-04 16:14 Toralf Förster
2018-11-04 17:15 ` Joe Perches [this message]
2018-11-05 19:57 ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fd0ac892e8a290d808adb4ee025778660539afc6.camel@perches.com \
    --to=joe@perches.com \
    --cc=kees.cook@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=toralf.foerster@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®