From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752508AbdKHSmj (ORCPT ); Wed, 8 Nov 2017 13:42:39 -0500 Received: from mout.web.de ([217.72.192.78]:52725 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751856AbdKHSmh (ORCPT ); Wed, 8 Nov 2017 13:42:37 -0500 Subject: [PATCH 2/3] net: sched: cls_fw: Improve two size determinations in fw_change() From: SF Markus Elfring To: netdev@vger.kernel.org, Cong Wang , "David S. Miller" , Jamal Hadi Salim , Jiri Pirko Cc: LKML , kernel-janitors@vger.kernel.org References: <32efa965-896f-f24a-4d30-586e10c54a5b@users.sourceforge.net> Message-ID: Date: Wed, 8 Nov 2017 19:42:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <32efa965-896f-f24a-4d30-586e10c54a5b@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:ZtK4/zxx+YM2aymD6bUNaNqXb5i8i1Wt4IRZJfq+7XcojHBwN4U K5vi6ZdXxvu+wsxUa0gZzSqZBuk3SFT0IWll3xPQy1c6Lv7LGpCuWxv5v7qyRIHSZIIp2K7 KV/q+0qzRjh2V7zrB73hJbQRspi8bcfDTVXWktdN+nFLUhgcYU0mHFEzdgvHWoX9wozQI3r yh29AcgChPSE8SWSKJK+g== X-UI-Out-Filterresults: notjunk:1;V01:K0:G7uzPgX5IRc=:pF0E7HRfLYB+A8vf0hDkgy xaBO+eXn8LBEw3F85vfVxvraR+piKo47+WbQB6u99oLCjpJns/aY72QM/Hi8wPS34Fez/R1bi X8Vb5O7dLkD5943E9MhrF1GYhO5EG5lMP0d9IefojN1ZTLUrYAnCZV3FHO/JY7N63jsXasvD7 b5Mj9QYr14tbd2ySnwN7NlO6asiMYL1BEPWOs/no2E7aLF15F0skc6yCGMuDhQDAgfFnDSXLG OsbfpOzsPoJFOIKQ2W6gXoQkGHM7tFJXjWkkS5s1Tbv82SizRON4DzG55rclcTj15beW9TBMh k9Piw4of8el/8SNNQWvQhaAGLTFpiugUcQl4XZUxbzIEjiz7Upl10GySjWwGu78GkWXce0Lqn Gm0xRf1jiNVFfx1zK8WxGjxqEDWDfloiyHL8ORWTbjwZpNwL/StFt6qDpQdiJcbro1UPKJkct QhwxKDfNIktXm0InTxR4HpzoV2pu1x8Fk5mENviUeOdroRN+qMnrqcLvHP9zGJjrBvBWhMaCB 46ZpNdPpT7aJ07oFMvjITbjwTTPStsemuInAuo9ZYrjA6T+DLV7SibHuZEqj9r8Z6xtJ/fciR 6YJlc0xEahmsqrmsUhn8sf5scsFDUlcxbUMNUa7iI+cRscm9iCB0Ps6K1xbXZaJyz0EyXX2gS OoXMglIeh8lb3mKKGOa//Kt5cm/eNxjuDfO/QJ5MHZb8Y+TQlYxwIHl6IUzHwgXwBVFp/NF/0 S9idqQHQv0UkPGjIztdkgXjA8IIrGI3KpL2tk7W+Ig4MoCMs5iwnGKvueCjiUmM8zW2350E4Z QnxG7OQNl2gyDQn+xyHHbwhgvHdvoepTbGmtu1S0heboAMtBws= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 8 Nov 2017 19:19:10 +0100 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- net/sched/cls_fw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/sched/cls_fw.c b/net/sched/cls_fw.c index 567db4d2349f..53c1c8ae3e00 100644 --- a/net/sched/cls_fw.c +++ b/net/sched/cls_fw.c @@ -269,7 +269,7 @@ static int fw_change(struct net *net, struct sk_buff *in_skb, if (f->id != handle && handle) return -EINVAL; - fnew = kzalloc(sizeof(struct fw_filter), GFP_KERNEL); + fnew = kzalloc(sizeof(*fnew), GFP_KERNEL); if (!fnew) return -ENOBUFS; @@ -323,7 +323,7 @@ static int fw_change(struct net *net, struct sk_buff *in_skb, rcu_assign_pointer(tp->root, head); } - f = kzalloc(sizeof(struct fw_filter), GFP_KERNEL); + f = kzalloc(sizeof(*f), GFP_KERNEL); if (f == NULL) return -ENOBUFS; -- 2.15.0