From: Jeff Layton <jlayton@kernel.org>
To: Ilya Dryomov <idryomov@gmail.com>,
Max Kellermann <max.kellermann@ionos.com>
Cc: Xiubo Li <xiubli@redhat.com>,
ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
Lorenzo Bianconi <lorenzo@kernel.org>
Subject: Re: [PATCH 1/2] fs/ceph/debugfs: make all files world-readable
Date: Mon, 25 Sep 2023 07:29:43 -0400 [thread overview]
Message-ID: <fd19d9585b29952fcd727c1a6c47289f66ab96b7.camel@kernel.org> (raw)
In-Reply-To: <CAOi1vP80WvQhuXgzhvzupQP=4K2ckgu_WpUCtUSy5M+QdDycqw@mail.gmail.com>
On Mon, 2023-09-25 at 12:41 +0200, Ilya Dryomov wrote:
> On Fri, Sep 22, 2023 at 8:26 AM Max Kellermann <max.kellermann@ionos.com> wrote:
> >
> > I'd like to be able to run metrics collector processes without special
> > privileges
>
> Hi Max,
>
> A word of caution about building metrics collectors based on debugfs
> output: there are no stability guarantees. While the format won't be
> changed just for the sake of change of course, expect zero effort to
> preserve backwards compatibility.
>
> The latency metrics in particular are sent to the MDS in binary form
> and are intended to be consumed through commands like "ceph fs top".
> debugfs stuff is there just for an occasional sneak peek (apart from
> actual debugging).
>
FWIW, I wish we had gone with netlink for this functionality instead of
a seqfile. Lorenzo has been working with netlink for some similar
functionality with nfsd[1], and it's much nicer for this sort of thing.
[1]: https://lore.kernel.org/linux-nfs/ZQTM6l7NrsVHFoR5@lore-desk/T/#t
--
Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2023-09-25 11:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 6:25 Max Kellermann
2023-09-22 6:25 ` [PATCH 2/2] fs/ceph/debugfs: expose raw metric counters Max Kellermann
2023-09-25 5:18 ` [PATCH 1/2] fs/ceph/debugfs: make all files world-readable Xiubo Li
2023-09-25 10:24 ` Jeff Layton
2023-09-26 6:09 ` Max Kellermann
2023-09-25 10:41 ` Ilya Dryomov
2023-09-25 11:29 ` Jeff Layton [this message]
2023-09-26 6:16 ` Max Kellermann
2023-09-26 8:45 ` Ilya Dryomov
2023-09-26 9:09 ` Max Kellermann
2023-09-27 10:53 ` Ilya Dryomov
2023-09-27 11:22 ` Max Kellermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd19d9585b29952fcd727c1a6c47289f66ab96b7.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=max.kellermann@ionos.com \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome