From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D04842D5418 for ; Thu, 24 Jul 2025 13:11:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753362709; cv=none; b=Jrnjn31fgVYozJdyUO8hUlq4iFxeSU0CgJ6h2u2KkEuLJry9j15eFAEFkiTfQIRJvKsOHHRwGf1zaC/dqVfIsnGsnC2c8BTepPnmtJKgPXV8y36N/eNJQ+rdJqSfCZV8GhxOEy1OJ85y0fylO/wbl++ExRDjSTXCjchR4JfEsak= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753362709; c=relaxed/simple; bh=sQUVRr+DIVouijZAUFnKBN8/lKBzUmdx7Plm5JfcaAI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VSmJHen8RZh47ogTZeGbmAGUWQLmQz3fFRzHps/FzFNmkkl8aHC5vlxJDkA4x80C16URSWl+gtDbJcGni7IooizKIcJ3E55QXNNPWgxrtRynoqK+0OHQ6cGYcX0mETVR+4AxpvVPeh2i6ULNDnZ2NS0mcSRITCqT2mF+HTfCIHc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hL8bEBJb; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hL8bEBJb" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56O9W0fJ011445 for ; Thu, 24 Jul 2025 13:11:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= v0K+e7rJgZSq6tnIWJuJWStOUGslGM+UG4V9oh+SiyA=; b=hL8bEBJb9b/BllZ8 aQnP/jxfONoTZRAnJGQ2vpAuLPjsqxxiw+ZtjFgVQTHVWPnDxPmxsDBsHj2pr2O6 YENWv4fGKLpGFlWU98MQVkiLkfM3vR5gJvt9RDy8NnHdPdyjGNQUKlvSLUyIVD0f fiLEay8KUaiMqsQ/h0FE7HNmLHeHAnqvBBduZbkzsQVsjaQvwME0QLRwj+67THfh eU8fI96lT/J/ZyGAoTEUIDEQBjE3xF9p3RpRJV2t21Tv68t2vP9SDfqF11Bi2aWy luummD2nGvB/bNuh9+pdHkWd1uizbV0OaJSiIH/6J9H8+TcFu9IgRA0IeJqLzOH2 ioa4tw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 481t6w9yrf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 24 Jul 2025 13:11:46 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7e33e133f42so29281385a.3 for ; Thu, 24 Jul 2025 06:11:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753362705; x=1753967505; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=v0K+e7rJgZSq6tnIWJuJWStOUGslGM+UG4V9oh+SiyA=; b=NFkPbCJWa5lFJ2qkz9M1g4PteA/5HzBuUQmpXYbURzPXLF1XfCceNgte+E3FhWUFh0 zECOiig8y/C6S34FPwHk1Ejkpy57znOYqrFly5jK7/opGiIeEup+WIpXkpR3SSrHTjjP gai7jioGBjUxYuN07X8TdBm3QZJgRu+e0LZJiSUVJPG74kzkwDhwEww7NX/gzXLmFlFY JMKRjjxPu4xvhzCx+r0Ytq86X+jfkTyQs1zXzBA/C6pc8LjyMNh1mK5Jtc/feljfvT2H mG+YsFJNJkTTL1H03D5llvARt4L1C1ZZ+HOgfjr3Ov8DbeH7w6wf6HaXjkHe9yxKbR0h Qhtg== X-Forwarded-Encrypted: i=1; AJvYcCWc+YZHMRbDtHZfPBKhOfiIbPCUNOcI0MzwHvdsXh+tRkxyd56ZsD8dn+GuBpoudtcd0t6FHrT9b4iBZOY=@vger.kernel.org X-Gm-Message-State: AOJu0Yxe7Palf5QrRkFDnIC76jADHmOvjv94lzD7uR3n4vEz0wfn4GSv u2K/oMo1/4UWLXkemsyxWCDnb8yE0QxM/VS5PXtABJoBTctNpALbXh4+HgcFTVBY1apB39xKzhq jjlBBYxsrvnZdnS1VH045qwnILj9g5gH8Tlb9w45z62is2rLxpC990rkPGwnJS9vIlvgU02mBHg Q= X-Gm-Gg: ASbGncs+oVvtxx+Pv6qrLVwcO77PgcHw/jft5wYALOBlRR128WeRjLIH+lZ9t1g6y8j Vhuv1dTZ+/PuabIA0Oa8NcwKbaTy0rxyxRbIbVe+Y965+gGPNQrjRlXS6dGN09qw2AUNabHFz8G itZQ8OfWqKuu3ByBDZEBkjLTI2A98+uXv3Os3R0slIxtSv13JG1AAsQ2HQJ8SiUf0UVpNoNRDaS 1AyB/s6MWvav7LuLFAwjjC4fhZoE6hhm4EprOyK43XYAr8IEgr2MUdQVNn5issmcJhCgmj8kAf1 hWDOxV7saLW62MUaHYjSgUjmCxzi0hzfWdSdZLDSQ6vr/Pl6vfDEbcE+NVHrWKjsDaeq0bf0x5n QJTdfOvbFjxj5OiA1sA== X-Received: by 2002:a05:620a:8327:b0:7c3:bae4:2339 with SMTP id af79cd13be357-7e62a172a3emr267903985a.11.1753362704553; Thu, 24 Jul 2025 06:11:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEhYGn9CGeMn27MIN0M023g3aUqmiruI7RPJTYq02Iu137ror6Y5i+xclq2UWbIHAg9Q45Jxg== X-Received: by 2002:a05:620a:8327:b0:7c3:bae4:2339 with SMTP id af79cd13be357-7e62a172a3emr267897485a.11.1753362702795; Thu, 24 Jul 2025 06:11:42 -0700 (PDT) Received: from [192.168.43.16] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-614cd0d1297sm843086a12.1.2025.07.24.06.11.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Jul 2025 06:11:42 -0700 (PDT) Message-ID: Date: Thu, 24 Jul 2025 15:11:39 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/7] arm64: dts: qcom: Rename sa8775p SoC to "lemans" To: Krzysztof Kozlowski , Wasim Nazir Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, kernel@oss.qualcomm.com References: <20250722144926.995064-1-wasim.nazir@oss.qualcomm.com> <20250722144926.995064-2-wasim.nazir@oss.qualcomm.com> <20250723-swinging-chirpy-hornet-eed2f2@kuoka> <159eb27b-fca8-4f7e-b604-ba19d6f9ada7@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=SPpCVPvH c=1 sm=1 tr=0 ts=68823113 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=EUspDBNiAAAA:8 a=93qQf8JY70_oINAjwcAA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzI0MDA5OSBTYWx0ZWRfX93eTC5dXNAx5 XV01ZuHjPaiJR/DeYmrLd5I0XDMnGmqopEhobf4fR7JdpKLiyDQrulLkWYShYNrYi8roCMlqave SQET9p8koDgr9BNIaCoe3UTarhNAWhOOcIZkSF5bi+Nos/1aBbT+mKqJtLg+FmSPAL/PfsuXofP 0Jr8tETKjwqqrtbFxMWVGVdHyNQPdHmXaczMv+VNIzhFhIgIaHY2wd6Mhp1hICVYT5BdXx9pSvZ 3suf/1mJh3JytBo7ZUUc01YMIz2bGHt4DAjuHvqdtR9keJbzdTs7vxyNpdR5udCnGUbARp/Eu6a Z4qhd90RH2fus4d8QgDexurFEmSiu22CwldYGJsCk0QfIlNUxYSLxrJqG8rCdfSRLtPXMYsM0Rz JtgWyw2kSPfszKZSB6Ncdj/pMk42zTNIU1JyBletyL4/jXX78kWQu3+82lZ+0XPveKxIEHwj X-Proofpoint-ORIG-GUID: mVhmWQwxMOdKDMcTYCTTXifVCV3u_T1w X-Proofpoint-GUID: mVhmWQwxMOdKDMcTYCTTXifVCV3u_T1w X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-24_02,2025-07-24_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 adultscore=0 phishscore=0 malwarescore=0 mlxscore=0 bulkscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 lowpriorityscore=0 mlxlogscore=999 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507240099 On 7/24/25 2:51 PM, Krzysztof Kozlowski wrote: > On 24/07/2025 14:47, Konrad Dybcio wrote: >> On 7/23/25 10:29 AM, 'Krzysztof Kozlowski' via kernel wrote: >>> On Tue, Jul 22, 2025 at 08:19:20PM +0530, Wasim Nazir wrote: >>>> SA8775P, QCS9100 and QCS9075 are all variants of the same die, >>>> collectively referred to as lemans. Most notably, the last of them >>>> has the SAIL (Safety Island) fused off, but remains identical >>>> otherwise. >>>> >>>> In an effort to streamline the codebase, rename the SoC DTSI, moving >>>> away from less meaningful numerical model identifiers. >>>> >>>> Signed-off-by: Wasim Nazir >>>> --- >>>> arch/arm64/boot/dts/qcom/{sa8775p.dtsi => lemans.dtsi} | 0 >>>> arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 2 +- >>> >>> No, stop with this rename. >>> >>> There is no policy of renaming existing files. >> >> There's no policy against renaming existing files either. > > There is, because you break all the users. All the distros, bootloaders > using this DTS, people's scripts. Renames happen every now and then, when new variants are added or discovered (-oled/lcd, -rev-xyz etc.) and they break things as well. Same way as (non-uapi) headers move around and break compilation for external projects as well. > >> >>> It's ridicilous. Just >>> because you introduced a new naming model for NEW SOC, does not mean you >>> now going to rename all boards which you already upstreamed. >> >> This is a genuine improvement, trying to untangle the mess that you >> expressed vast discontent about.. >> >> There will be new boards based on this family of SoCs submitted either >> way, so I really think it makes sense to solve it once and for all, >> instead of bikeshedding over it again and again each time you get a new >> dt-bindings change in your inbox. >> >> I understand you're unhappy about patch 6, but the others are >> basically code janitoring. > > Renaming already accepted DTS is not improvement and not untangling > anything. These names were discussed (for very long time) and agreed on. We did not have clearance to use the real name of the silicon back then, so this wasn't an option. > What is the point of spending DT maintainers time to discuss the sa8775p > earlier when year later you come and start reversing things (like in > patch 6). It's quite obviously a huge mess.. but we have a choice between sitting on it and complaining, or moving on. I don't really see the need for patch 6, but I think the filename changes are truly required for sanity going forward. We don't want to spawn meaningless .dts files NUM_SKUS * NUM_BOARDS times. So far these are basically Qualcomm-internal boards, or at the very least there was zero interest shown from people that weren't contracted to work on them. Konrad