From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BD88C04EB9 for ; Tue, 4 Dec 2018 01:07:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5B9D42146D for ; Tue, 4 Dec 2018 01:07:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B9D42146D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726058AbeLDBHV (ORCPT ); Mon, 3 Dec 2018 20:07:21 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:45421 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725943AbeLDBHU (ORCPT ); Mon, 3 Dec 2018 20:07:20 -0500 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 0C0905C853305; Tue, 4 Dec 2018 09:07:17 +0800 (CST) Received: from [127.0.0.1] (10.142.63.192) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.408.0; Tue, 4 Dec 2018 09:07:09 +0800 CC: , , , , , , Greg Kroah-Hartman , Hans de Goede , "Andy Shevchenko" , John Stultz Subject: Re: [PATCH v1 08/12] usb: roles: Add usb role switch notifier. To: Heikki Krogerus References: <20181203034515.91412-1-chenyu56@huawei.com> <20181203034515.91412-9-chenyu56@huawei.com> <20181203123824.GE24338@kuha.fi.intel.com> From: Chen Yu Message-ID: Date: Tue, 4 Dec 2018 09:07:08 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20181203123824.GE24338@kuha.fi.intel.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.142.63.192] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018/12/3 20:38, Heikki Krogerus wrote: > On Mon, Dec 03, 2018 at 11:45:11AM +0800, Yu Chen wrote: >> This patch adds notifier for drivers want to be informed of the usb role switch. > > I think in this case it would be good to explain a little for what we > need the notifier for. > >> Cc: Greg Kroah-Hartman >> Cc: Heikki Krogerus >> Cc: Hans de Goede >> Cc: Andy Shevchenko >> Cc: John Stultz >> Signed-off-by: Heikki Krogerus >> Signed-off-by: Yu Chen >> >> -- >> v0: >> The patch is provided by Heikki Krogerus. I modified and test it >> on Hikey960 platform. > > I don't think I actually made a "patch" for this. The "diff" I made > showing the idea does not count, so you should not sign off the patch > with my address. > > In this case I believe something like "Suggested-by" should be used > instead of SoB tag: > > Suggested-by: Heikki Krogerus > > Side note: If this was from me, then there should be "from" line with > my address as well. > OK. Thanks！ >> -- >> --- >> drivers/usb/common/roles.c | 20 +++++++++++++++++++- >> include/linux/usb/role.h | 46 ++++++++++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 65 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/usb/common/roles.c b/drivers/usb/common/roles.c >> index 0f48090c5c30..bfd7a988b64c 100644 >> --- a/drivers/usb/common/roles.c >> +++ b/drivers/usb/common/roles.c >> @@ -21,6 +21,7 @@ struct usb_role_switch { >> struct device dev; >> struct mutex lock; /* device lock*/ >> enum usb_role role; >> + struct blocking_notifier_head nh; >> >> /* From descriptor */ >> struct device *usb2_port; >> @@ -50,8 +51,10 @@ int usb_role_switch_set_role(struct usb_role_switch *sw, enum usb_role role) >> mutex_lock(&sw->lock); >> >> ret = sw->set(sw->dev.parent, role); >> - if (!ret) >> + if (!ret) { >> sw->role = role; >> + blocking_notifier_call_chain(&sw->nh, role, NULL); >> + } >> >> mutex_unlock(&sw->lock); >> >> @@ -59,6 +62,20 @@ int usb_role_switch_set_role(struct usb_role_switch *sw, enum usb_role role) >> } >> EXPORT_SYMBOL_GPL(usb_role_switch_set_role); >> >> +int usb_role_switch_register_notifier(struct usb_role_switch *sw, >> + struct notifier_block *nb) >> +{ >> + return blocking_notifier_chain_register(&sw->nh, nb); >> +} >> +EXPORT_SYMBOL_GPL(usb_role_switch_register_notifier); >> + >> +int usb_role_switch_unregister_notifier(struct usb_role_switch *sw, >> + struct notifier_block *nb) >> +{ >> + return blocking_notifier_chain_unregister(&sw->nh, nb); >> +} >> +EXPORT_SYMBOL_GPL(usb_role_switch_unregister_notifier); >> + >> /** >> * usb_role_switch_get_role - Get the USB role for a switch >> * @sw: USB role switch >> @@ -297,6 +314,7 @@ usb_role_switch_register(struct device *parent, >> return ERR_PTR(-ENOMEM); >> >> mutex_init(&sw->lock); >> + BLOCKING_INIT_NOTIFIER_HEAD(&sw->nh); >> >> sw->allow_userspace_control = desc->allow_userspace_control; >> sw->usb2_port = desc->usb2_port; >> diff --git a/include/linux/usb/role.h b/include/linux/usb/role.h >> index edc51be4a77c..c97d4be91ada 100644 >> --- a/include/linux/usb/role.h >> +++ b/include/linux/usb/role.h >> @@ -40,6 +40,8 @@ struct usb_role_switch_desc { >> bool allow_userspace_control; >> }; >> >> + >> +#if IS_ENABLED(CONFIG_USB_ROLE_SWITCH) >> int usb_role_switch_set_role(struct usb_role_switch *sw, enum usb_role role); >> enum usb_role usb_role_switch_get_role(struct usb_role_switch *sw); >> struct usb_role_switch *usb_role_switch_get(struct device *dev); >> @@ -49,5 +51,49 @@ struct usb_role_switch * >> usb_role_switch_register(struct device *parent, >> const struct usb_role_switch_desc *desc); >> void usb_role_switch_unregister(struct usb_role_switch *sw); >> +int usb_role_switch_register_notifier(struct usb_role_switch *sw, >> + struct notifier_block *nb); >> +int usb_role_switch_unregister_notifier(struct usb_role_switch *sw, >> + struct notifier_block *nb); >> +#else >> +static inline int usb_role_switch_set_role(struct usb_role_switch *sw, >> + enum usb_role role) >> +{ >> + return 0; >> +} >> + >> +static inline enum usb_role usb_role_switch_get_role(struct usb_role_switch *sw) >> +{ >> + return USB_ROLE_NONE; >> +} >> + >> +static inline struct usb_role_switch *usb_role_switch_get(struct device *dev) >> +{ >> + return ERR_PTR(-ENODEV); >> +} >> + >> +static inline void usb_role_switch_put(struct usb_role_switch *sw) { } >> + >> +static inline struct usb_role_switch * >> +usb_role_switch_register(struct device *parent, >> + const struct usb_role_switch_desc *desc) >> +{ >> + return ERR_PTR(-ENODEV); >> +} >> + >> +static inline void usb_role_switch_unregister(struct usb_role_switch *sw) { } >> + >> +static int usb_role_switch_register_notifier(struct usb_role_switch *sw, >> + struct notifier_block *nb) >> +{ >> + return -ENODEV; >> +} >> + >> +static int usb_role_switch_unregister_notifier(struct usb_role_switch *sw, >> + struct notifier_block *nb) >> +{ >> + return -ENODEV; >> +} >> +#endif >> >> #endif /* __LINUX_USB_ROLE_H */ >> -- >> 2.15.0-rc2 > > thanks, >