From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37D9F3E172D for ; Mon, 17 Aug 2026 13:47:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786974477; cv=none; b=GhQoJvi9F3RZfqC44puQBaA3sxwYQ26tgC32K0N9smUEeotVh1Q6BonMAT5aEUFH75LEq3wFhGsUlXNmFPBG6XrjLj099lHLwgqV/xh6npJv3WuaDneqe27BUAYFkOo2AU0E94T+US9RI0/00/rCXobswTuENMn32wdlUUHlNi4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786974477; c=relaxed/simple; bh=HYSkadIxfpprlI4mzPC4DdLx7RC2DW3C8xdieELRFXs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sueSt+TrPP22hAi0GmEvgZrO9Cklne9lXnlDtj9jvH1RbGTzghLEgSXkezxsYSdFceYRYvx/hUwVtdDe0X27iH25MG95vNvcx8MEFoz35MoE3lO3u0xvQoPqz1/WolBrXogk8iWhPTbCPeEyBUMWqzW52ZKrMkpxGaZAgoGVDQU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rowland.harvard.edu; spf=fail smtp.mailfrom=g.harvard.edu; dkim=pass (2048-bit key) header.d=rowland.harvard.edu header.i=@rowland.harvard.edu header.b=srtSSCTc; arc=none smtp.client-ip=209.85.222.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rowland.harvard.edu Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=g.harvard.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rowland.harvard.edu header.i=@rowland.harvard.edu header.b="srtSSCTc" Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-934956bee57so346086185a.2 for ; Mon, 17 Aug 2026 06:47:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rowland.harvard.edu; s=google; t=1786974468; x=1787579268; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=BxMusu65AdSSwszpaWr6OP5O8vIYQL78CVGuBd1AIao=; b=srtSSCTcdPRrMDYoBELFkkbNhgZD29N+2BlGZQi65FA07PJvQOwI1CIZArZQ8oKZ5N DksVhHBIMavl/hgPFIRB2qfiPoqgbhS1/9MLX3biH5yxdJwOEZz3yB76kbLv+kUGyMs/ belnxly1SHo7uj1OrZY5qayuAlVhKStQjQs4P3pNHagltUp8w+8zunYqcZ+NELdqxZsO u9++sdaETj52DGovrH3lA838P8OovNqweyRcX6KpeGc8RNzJVxeBim88W88EMEj3OMu3 EIc8L9hUzwzntuVzssmI0gC53NKoEF9fhYOd/CbpVqBpy2gRmon5krdo1HsLul26eQiu x/Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786974468; x=1787579268; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=BxMusu65AdSSwszpaWr6OP5O8vIYQL78CVGuBd1AIao=; b=FSoDyEEZ35D+ux5xIsBVKCxUzlKA9f4K75rMFjvyNnp4MwtGc1Jhzkcl331ynSF+Vg q5arKaPKASeNqt2Vvp/CACapwIOgNNy0VhLRFHKwV0TvX5symdyvbSYM5/TaY9QSvuVP xAxADgQ8LVs29G6fBtjYtxE8Jdfj1AFvdfrc05dkSS4EjKYl6CygliExa9GpcuN+Txy+ GSVleTNX/wQzEjkEtQPUm/STO0VY0QZi6G/wT4YpYIkEAoIfmLSfm5KiV2d15z3IJcAn 6WUUl1sDjlJJ+3k5nyG2qS/cJaHEiMaHXpE3dASlhBLKnu1T+c373GkYLs+uGVLttbZp fXcQ== X-Forwarded-Encrypted: i=1; AHgh+RqH1tb9NfGwG6KRXz+hp56T0XVQyN9Tt81T5n2bsUOGF5ChvEkls6hIOA3XQKtClpX01zrOyutqz6Kf+Ls=@vger.kernel.org X-Gm-Message-State: AOJu0YwSvCNCo6bO86bahebKggu8KM7ilMh+uZmZ3z1oXMo3IOayKEbu 77xxDS5CLTTCXUtYWodXcU4jSe7cr29oE9VSzmxfvc2BEQqRZ0PGtES1o5oJpyFgUobKl8K8cuF oePoMdQ== X-Gm-Gg: AR+sD11AuAsjeHhuiC9jCyg3vMk28HFEm0duk2TEcOI6Txd3+cyjlAIBVP+qR1/lPqF xJRMtxHiTxi9bE9KldR/XjthOJl8xOGsEXh+MSK8Nbmr0cskJw+GfXR5nEKYIQVyWgBmNrApK3l cr0PcG5x+isUUai5m+KXG+/MhIao7J9xc87KQ8qWCM0q9hw9B6yupxRYcumwf2kql+cvGbxmfXB PMc+MZ020J7MH1l8QxgpoVP9YR9KlDKkZxXQ7c2KgRoSxGkjrg63aAKhUZG1+W17lKkjWdaGHS/ puF+NXKpf7bLCgHRP51b/B6YKZ+nX70vPyeTLcPpV1EJsxBnVPG+agUZ/u7lz2dYNcoGxa2fGKP ZB1fBu/ZziVdb4Qj6FNZ6Ike6YsOtrcwmqkn2w3EtNbzLG1glw12UFX2yOWgxF1vQNto3uJ5EjW sSDovsgUR1l2js09863VyU7gHkqc9mzT5wiS7GRaqCqZzCbY3nOIAHIpNowqgx5HYkBMTY8mmBC LPDcGE= X-Received: by 2002:a05:620a:ac18:b0:936:bcd6:269d with SMTP id af79cd13be357-936d21427c8mr2394544585a.6.1786974468111; Mon, 17 Aug 2026 06:47:48 -0700 (PDT) Received: from rowland.harvard.edu ([140.247.181.15]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9370342b063sm49290385a.45.2026.08.17.06.47.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 06:47:47 -0700 (PDT) Date: Mon, 17 Aug 2026 09:47:45 -0400 From: Alan Stern To: Andy Shevchenko Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH v1 1/1] usb: f_mass_storage: Bump local buffer size in fsg_common_create_luns() Message-ID: References: <20260817104734.1031300-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260817104734.1031300-1-andriy.shevchenko@linux.intel.com> On Mon, Aug 17, 2026 at 12:47:34PM +0200, Andy Shevchenko wrote: > GCC is not happy about the buffer size: > > drivers/usb/gadget/function/f_mass_storage.c:2970:48: error: ā€˜%d’ directive output may be truncated writing between 1 and 9 bytes into a region of size 5 [-Werror=format-truncation=] > > Bump the size to get it enough for all possible values. > > Note, the existing comment is wrong as size 8 for the whole buffer doesn't > cover 100 mil numbers, hence drop it altogether. It seems highly unlikely that anyone would ever want to create 100 million LUNs. Why not limit the number of LUNs to some more reasonable value, like 1000? Alan Stern > Fixes: b27c08c953e9 ("usb: gadget: f_mass_storage: create lun creation helpers for use in fsg_common_init") > Signed-off-by: Andy Shevchenko > --- > drivers/usb/gadget/function/f_mass_storage.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/function/f_mass_storage.c b/drivers/usb/gadget/function/f_mass_storage.c > index b7b06cb79ff5..3d1823b74cd3 100644 > --- a/drivers/usb/gadget/function/f_mass_storage.c > +++ b/drivers/usb/gadget/function/f_mass_storage.c > @@ -2961,7 +2961,7 @@ EXPORT_SYMBOL_GPL(fsg_common_create_lun); > > int fsg_common_create_luns(struct fsg_common *common, struct fsg_config *cfg) > { > - char buf[8]; /* enough for 100000000 different numbers, decimal */ > + char buf[14]; > int i, rc; > > fsg_common_remove_luns(common); > -- > 2.50.1 > >