From: "Winiarska, Iwona" <iwona.winiarska@intel.com>
To: "ricardo@marliere.net" <ricardo@marliere.net>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] peci: Make peci_bus_type const
Date: Wed, 14 Feb 2024 13:58:42 +0000 [thread overview]
Message-ID: <fd2d505396378941784331ebb24f56b5dd839653.camel@intel.com> (raw)
In-Reply-To: <20240210-bus_cleanup-peci-v1-1-1e64bef6efc0@marliere.net>
On Sat, 2024-02-10 at 12:10 -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the peci_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
Reviewed-by: Iwona Winiarska <iwona.winiarska@intel.com>
Thanks
-Iwona
> ---
> drivers/peci/core.c | 2 +-
> drivers/peci/internal.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/peci/core.c b/drivers/peci/core.c
> index 0f83a9c6093b..b2f8db967e9b 100644
> --- a/drivers/peci/core.c
> +++ b/drivers/peci/core.c
> @@ -201,7 +201,7 @@ static void peci_bus_device_remove(struct device *dev)
> driver->remove(device);
> }
>
> -struct bus_type peci_bus_type = {
> +const struct bus_type peci_bus_type = {
> .name = "peci",
> .match = peci_bus_device_match,
> .probe = peci_bus_device_probe,
> diff --git a/drivers/peci/internal.h b/drivers/peci/internal.h
> index 9d75ea54504c..8a896c256c5f 100644
> --- a/drivers/peci/internal.h
> +++ b/drivers/peci/internal.h
> @@ -81,7 +81,7 @@ extern const struct attribute_group *peci_device_groups[];
> int peci_device_create(struct peci_controller *controller, u8 addr);
> void peci_device_destroy(struct peci_device *device);
>
> -extern struct bus_type peci_bus_type;
> +extern const struct bus_type peci_bus_type;
> extern const struct attribute_group *peci_bus_groups[];
>
> /**
>
> ---
> base-commit: 047371968ffc470769f541d6933e262dc7085456
> change-id: 20240210-bus_cleanup-peci-0933c629d58b
>
> Best regards,
prev parent reply other threads:[~2024-02-14 13:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-10 15:10 Ricardo B. Marliere
2024-02-14 13:58 ` Winiarska, Iwona [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd2d505396378941784331ebb24f56b5dd839653.camel@intel.com \
--to=iwona.winiarska@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=ricardo@marliere.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®