From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A245C433F5 for ; Sun, 3 Apr 2022 12:20:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357670AbiDCMV5 (ORCPT ); Sun, 3 Apr 2022 08:21:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236111AbiDCMVz (ORCPT ); Sun, 3 Apr 2022 08:21:55 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 729B83467E for ; Sun, 3 Apr 2022 05:20:01 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id e16so12478865lfc.13 for ; Sun, 03 Apr 2022 05:20:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language :from:to:cc:references:in-reply-to:content-transfer-encoding; bh=zbodHHrevjydH+zdP0lL/nnwlQQVq6AdfqnfCx0W7oU=; b=UHpjHkiDrYV/NBMUyc1gt5luZX4ad+7i18Zz3kJ/GsF5tO2qtEINyZvbs3zDob86D7 ATCHqS8X3g7xgOdfEHxR4j2a2D97tcS9/7owd+fqQQOdMajcP9OC4v7ODAQZaseYt3D2 UCmlB2ILmTQ7ei0QhtadNgNR9zY+gKamkVBTFZysVrUj0CyPUeoHkwnOkVPOHXABrUCV 9PCVpy4Zrfc9+e955iSSq2nOWi4aI+fql5ouwdqZRyaDzFPecdVUbFNkitC8+qvk2GgZ 9bAPqcDzYwwD27LSE354DRPDYLSSG9HwzImx5LfPVqMUC60yUGB/wC05ZqGXvchHJzIK 0BUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=zbodHHrevjydH+zdP0lL/nnwlQQVq6AdfqnfCx0W7oU=; b=EVSg3Yt33EQ5Vf2RpCYanwv15kj1+npQ7P7Qk4NGZYhjghiDHuwOzUDslZpA2/SnwO EI95nDw9+3mQo9UHzQIjMIi/eJozkkEy/O1RR6YuxoJkKGGNnVOpe9zQBzw4tjfGOyvI ouoIozXkY+2USRUDbxl2ebHUcBRjgWn81eDcG8GmUN3ye9JdexGbF/i3FIh5KVmOoVP4 UvR0kMRZIkfD2PCklVq3fuu9/FcPZCA1rBA2jiGqleBKkpgbCJZLRJqws+8h2GXWD5RL E3Y77cMfPMnkA87v0Aj3KMCtNF1Is+tkSNOIjs30HvH2QHr3NWaZf+KfMvTNqAlUB1Ne vT8g== X-Gm-Message-State: AOAM5314J/e4AL8Uy7C8/FeqLW/Ax88McPp5s3BCTb4Efra0/RYLi9LJ PRhiRzVQzXPQtL9as2mrlYg= X-Google-Smtp-Source: ABdhPJwVPiaFOsF8CF+UKJVFczY+Y6vkqwIPieZKR+4654dAF79RQZXMYcm0XT5ySNBn4AAVYu+aoQ== X-Received: by 2002:a19:6750:0:b0:44a:1fd7:530f with SMTP id e16-20020a196750000000b0044a1fd7530fmr19392379lfj.341.1648988399546; Sun, 03 Apr 2022 05:19:59 -0700 (PDT) Received: from [192.168.1.11] ([46.235.67.247]) by smtp.gmail.com with ESMTPSA id c20-20020a196554000000b0044a1181c527sm810298lfj.9.2022.04.03.05.19.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 03 Apr 2022 05:19:59 -0700 (PDT) Message-ID: Date: Sun, 3 Apr 2022 15:19:57 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: staging: r8188eu: how to handle nested mutex under spinlock Content-Language: en-US From: Pavel Skripkin To: Michael Straube , "Fabio M. De Francesco" Cc: Greg KH , Larry Finger , Phillip Potter , "open list:STAGING SUBSYSTEM" , Linux Kernel Mailing List References: <356c24cf-625b-eea2-2c04-ce132d881cac@gmail.com> <1813843.tdWV9SEqCh@leap> <942bbcb6-725d-9b47-5dfe-f105d30ea6b7@gmail.com> <7365301.EvYhyI6sBW@leap> <3fb13fee-a605-7f2e-81ad-45148082a733@gmail.com> In-Reply-To: <3fb13fee-a605-7f2e-81ad-45148082a733@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/3/22 14:48, Pavel Skripkin wrote: > On 4/3/22 14:41, Michael Straube wrote: >> >> Hi Fabio, >> >> wait.. >> >> rtw_set_802_11_disassociate() calls rtw_pwr_wakeup() only if >> check_fwstate(pmlmepriv, _FW_LINKED) is true. >> >> >> if (check_fwstate(pmlmepriv, _FW_LINKED)) { >> rtw_disassoc_cmd(padapter, 0, true); >> rtw_indicate_disconnect(padapter); >> rtw_free_assoc_resources(padapter, 1); >> rtw_pwr_wakeup(padapter); >> } >> > > msleep() cannot be called in atomic context: > > drivers/staging/r8188eu/core/rtw_pwrctrl.c:379 > > if (pwrpriv->ps_processing) { > while (pwrpriv->ps_processing && rtw_get_passing_time_ms(start) <= 3000) > msleep(10); > } > Hm, just wondering, shouldn't we annotate load from pwrpriv->ps_processing with READ_ONCE() inside while loop? IIUC compiler might want to cache first load into register and we will stuck here forever. Am I missing something? With regards, Pavel Skripkin