From: David Ahern <dsahern@gmail.com>
To: Michal Kubecek <mkubecek@suse.cz>,
Johannes Berg <johannes@sipsolutions.net>
Cc: "David S. Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 1/3] genetlink: do not validate dump requests if there is no policy
Date: Thu, 2 May 2019 07:36:37 -0600 [thread overview]
Message-ID: <fd3b0c89-2475-166d-e2b8-1479af7b79bc@gmail.com> (raw)
In-Reply-To: <20190502133231.GF21672@unicorn.suse.cz>
On 5/2/19 7:32 AM, Michal Kubecek wrote:
> Wouldn't it mean effecitvely ending up with only one command (in
> genetlink sense) and having to distinguish actual commands with
> atributes? Even if I wanted to have just "get" and "set" command, common
> policy wouldn't allow me to say which attributes are allowed for each of
> them.
yes, I have been stuck on that as well.
There are a number of RTA attributes that are only valid for GET
requests or only used in the response or only valid in NEW requests.
Right now there is no discriminator when validating policies and the
patch set to expose the policies to userspace
next prev parent reply other threads:[~2019-05-02 13:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-02 12:48 [PATCH net-next 0/3] netlink: strict attribute checking follow-up Michal Kubecek
2019-05-02 12:48 ` [PATCH net-next 2/3] netlink: set bad attribute also on maxtype check Michal Kubecek
2019-05-02 12:52 ` Johannes Berg
2019-05-02 13:37 ` David Ahern
2019-05-02 12:48 ` [PATCH net-next 3/3] netlink: add validation of NLA_F_NESTED flag Michal Kubecek
2019-05-02 12:54 ` Johannes Berg
2019-05-02 13:14 ` Michal Kubecek
2019-05-02 13:40 ` David Ahern
2019-05-02 15:07 ` Johannes Berg
2019-05-02 12:48 ` [PATCH net-next 1/3] genetlink: do not validate dump requests if there is no policy Michal Kubecek
2019-05-02 12:51 ` Johannes Berg
2019-05-02 13:10 ` Michal Kubecek
2019-05-02 13:13 ` Johannes Berg
2019-05-02 13:32 ` Michal Kubecek
2019-05-02 13:36 ` David Ahern [this message]
2019-05-02 15:28 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd3b0c89-2475-166d-e2b8-1479af7b79bc@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome