From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 005A8C7EE45 for ; Thu, 8 Jun 2023 16:02:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231302AbjFHQCX (ORCPT ); Thu, 8 Jun 2023 12:02:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232712AbjFHQBk (ORCPT ); Thu, 8 Jun 2023 12:01:40 -0400 Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D453130C6; Thu, 8 Jun 2023 09:01:16 -0700 (PDT) Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 358G0up0003457; Thu, 8 Jun 2023 11:00:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1686240056; bh=+044SB8JfSnWUwpBcTcNTtHlcD21RFEeVggm7URky6I=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=h6F3VYVpzCHuJGJXoig9h0xAF0hFY0eQE2iDczds3Jg/zWaPA0XFW6+uFuCu70HUU 4asgU2N6RcdUqzbTeZIw5TdCAA8JrTlKRk5mmiqDnJhhM8YfxE5MZRwb+l/G12U+Fv xTcpscwcCh79qtWd5okIrpa99306jP1dQ8hpOy6k= Received: from DFLE110.ent.ti.com (dfle110.ent.ti.com [10.64.6.31]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 358G0uDm091311 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 8 Jun 2023 11:00:56 -0500 Received: from DFLE111.ent.ti.com (10.64.6.32) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Thu, 8 Jun 2023 11:00:56 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Thu, 8 Jun 2023 11:00:56 -0500 Received: from [10.249.141.75] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 358G0qck023969; Thu, 8 Jun 2023 11:00:52 -0500 Message-ID: Date: Thu, 8 Jun 2023 21:30:51 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v3 5/5] arm64: dts: ti: k3-j7200-common-proc-board: Add uart pin mux in wkup_pmx0 To: Nishanth Menon CC: , , , , , , , , , References: <20230604045525.1889083-1-u-kumar1@ti.com> <20230604045525.1889083-6-u-kumar1@ti.com> <20230606120959.r4pnxuigknl7qkjr@outpour> Content-Language: en-US From: "Kumar, Udit" In-Reply-To: <20230606120959.r4pnxuigknl7qkjr@outpour> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks Nishanth On 6/6/2023 5:39 PM, Nishanth Menon wrote: > On 10:25-20230604, Udit Kumar wrote: >> Add uart pin mux of wkup domain into common board file. >> >> Signed-off-by: Udit Kumar >> --- >> .../dts/ti/k3-j7200-common-proc-board.dts | 22 ++++++++++++++++++- >> 1 file changed, 21 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts >> index e12d93f56c51..809d1c910015 100644 >> --- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts >> +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts >> @@ -79,6 +79,24 @@ vdd_sd_dv: gpio-regulator-TLV71033 { >> }; >> }; >> >> [..] > Could you add the pins to wkup_uart0 node as well? > >> + pinctrl-single,pins = < >> + J721E_WKUP_IOPAD(0xb0, PIN_INPUT, 0) /* (B14) WKUP_UART0_RXD */ >> + J721E_WKUP_IOPAD(0xb4, PIN_OUTPUT, 0) /* (A14) WKUP_UART0_TXD */ >> + >; >> + }; >> +}; > We are also missing pinmux for main_uart1 and main_uart2 I will address missing pin mux in next version > [..]