From: <Conor.Dooley@microchip.com>
To: <robh+dt@kernel.org>
Cc: <mail@conchuod.ie>, <ulf.hansson@linaro.org>,
<krzysztof.kozlowski+dt@linaro.org>,
<yamada.masahiro@socionext.com>, <piotrs@cadence.com>,
<linux-mmc@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-riscv@lists.infradead.org>
Subject: Re: [PATCH] dt-bindings: mmc: cdns: add card-detect-delay property
Date: Fri, 12 Aug 2022 16:43:24 +0000 [thread overview]
Message-ID: <fd3e5466-76e4-f678-5729-bfe9f2b0b811@microchip.com> (raw)
In-Reply-To: <CAL_JsqKZ2N7rTb0Fm0Y8CjN8XrTkBsu2uU_TFfhU0iwjSz5row@mail.gmail.com>
On 12/08/2022 17:38, Rob Herring wrote:
>>> No, the common property 'cd-debounce-delay-ms' should be used instead.
>>
>> So it's a case of "what's in the dts is wrong so it needs to change"?
>
> Yes.
>
>> For the future, where is the line drawn between "don't break the dts"
>> & "don't use bad properties"?
>
> Depends...
>
>> Only if the property has consumers?
>> I don't mind, just want to get it right next time ;)
>
> In this case, there shouldn't be any compatibility issues because the
> mmc core has supported the common property longer than the dts
> existed. If that was not the case, then we'd probably be stuck with
> the property in the dts file. That still depends on usage in the
> kernel or elsewhere, in dts files, stability of the platform support,
> etc.
Cool, thanks Rob!
next prev parent reply other threads:[~2022-08-12 16:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 20:31 Conor Dooley
2022-08-12 15:33 ` Rob Herring
2022-08-12 15:46 ` Conor.Dooley
2022-08-12 16:38 ` Rob Herring
2022-08-12 16:43 ` Conor.Dooley [this message]
2022-08-12 18:51 ` Conor.Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd3e5466-76e4-f678-5729-bfe9f2b0b811@microchip.com \
--to=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mail@conchuod.ie \
--cc=piotrs@cadence.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®