mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Hong <peter_hong@fintek.com.tw>
To: Johan Hovold <johan@kernel.org>
Cc: <gregkh@linuxfoundation.org>, <linux-usb@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <tom_tsai@fintek.com.tw>,
	<yu_chen@fintek.com.tw>
Subject: Re: [PATCH V2 1/1] USB: serial: f81232: fix incomplete serial port generation
Date: Tue, 2 Dec 2025 13:40:28 +0800	[thread overview]
Message-ID: <fd3e97cf-6f92-4921-9482-e0d6863a46b2@fintek.com.tw> (raw)
In-Reply-To: <aS2aQF_6ljhFtLI_@hovoldconsulting.com>

Hi,

Johan Hovold 於 2025/12/1 下午 09:38 寫道:
> On Fri, Nov 28, 2025 at 04:52:44PM +0800, Ji-Ze Hong (Peter Hong) wrote:
>> The Fintek F81532A/534A/535/536 family relies on the
>> F81534A_CTRL_CMD_ENABLE_PORT (116h) register during initialization to
>> both determine serial port status and control port creation. If the
>> driver experiences fast load/unload cycles, the device state may becomes
>> unstable, resulting in the incomplete generation of serial ports.
>>
>> Performing a dummy read operation on the register prior to the initial
>> write command resolves the issue. This clears the device's stale internal
>> state. Subsequent write operations will correctly generate all serial
>> ports.
>>
>> Tested on: HygonDM1SLT(Hygon C86 3250 8-core Processor)
>>
>> Signed-off-by: Ji-Ze Hong (Peter Hong) <peter_hong@fintek.com.tw>
>> ---
>> Changelog:
>> v2:
>> 	1. remove loop in accessor function.
> Thanks for verifying.
>
> Did you try removing the retry loop also in the set_register() helper?
> Perhaps that's no longer needed after the dummy read.

I will try removing the retry loop in set_register() helper.
If that worked, could I use the same patch file or series of patches?

Thanks,


-- 

*洪繼澤 **Peter Hong*

精拓科技股份有限公司

Feature Integration Technology

Address: 302新竹縣竹北市台元二街10號7樓

TEL: 03-5600168 #813

FAX: 03-5600166

E-Mail﹕peter_hong@fintek.com.tw





  reply	other threads:[~2025-12-02  5:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-28  8:52 Ji-Ze Hong (Peter Hong)
2025-12-01 13:38 ` Johan Hovold
2025-12-02  5:40   ` Peter Hong [this message]
2025-12-03 11:04     ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fd3e97cf-6f92-4921-9482-e0d6863a46b2@fintek.com.tw \
    --to=peter_hong@fintek.com.tw \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=tom_tsai@fintek.com.tw \
    --cc=yu_chen@fintek.com.tw \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®