From: Bart Van Assche <bvanassche@acm.org>
To: Yang Li <yang.lee@linux.alibaba.com>,
jejb@linux.ibm.com, martin.petersen@oracle.com,
satishkh@cisco.com, sebaddel@cisco.com, kartilak@cisco.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] scsi: fnic: Remove unused function fnic_scsi_host_start/end_tag()
Date: Wed, 30 Aug 2023 12:38:56 -0700 [thread overview]
Message-ID: <fd3f2d60-a0e4-4acf-ba1c-3506bc002f94@acm.org> (raw)
In-Reply-To: <20230829010222.33393-1-yang.lee@linux.alibaba.com>
On 8/28/23 18:02, Yang Li wrote:
> The function fnic_scsi_host_start_tag() and fnic_scsi_host_end_tag()
> are not used anywhere, so remove them.
Are you sure? I think the following output shows that these are being
used:
$ git grep -nHEw 'fnic_scsi_host_(start|end)_tag'
drivers/scsi/fnic/fnic_scsi.c:2171: * fnic_scsi_host_start_tag
drivers/scsi/fnic/fnic_scsi.c:2175:fnic_scsi_host_start_tag(struct fnic *fnic, struct scsi_cmnd *sc)
drivers/scsi/fnic/fnic_scsi.c:2192: * fnic_scsi_host_end_tag
drivers/scsi/fnic/fnic_scsi.c:2193: * frees tag allocated by fnic_scsi_host_start_tag.
drivers/scsi/fnic/fnic_scsi.c:2196:fnic_scsi_host_end_tag(struct fnic *fnic, struct scsi_cmnd *sc)
drivers/scsi/fnic/fnic_scsi.c:2262: tag = fnic_scsi_host_start_tag(fnic, sc);
drivers/scsi/fnic/fnic_scsi.c:2439: fnic_scsi_host_end_tag(fnic, sc);
Bart.
next prev parent reply other threads:[~2023-08-30 20:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 1:02 Yang Li
2023-08-29 2:42 ` Karan Tilak Kumar (kartilak)
2023-08-30 19:38 ` Bart Van Assche [this message]
2023-08-31 1:12 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd3f2d60-a0e4-4acf-ba1c-3506bc002f94@acm.org \
--to=bvanassche@acm.org \
--cc=jejb@linux.ibm.com \
--cc=kartilak@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=satishkh@cisco.com \
--cc=sebaddel@cisco.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®