From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 977B8B658 for ; Sun, 5 Jan 2025 17:57:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736099861; cv=none; b=jJH/VD3y2tRGfKPORZ9oj45sQq5qICQtiX40CWE6kLIgenIG2Hg+E9haSZ0JCS+RImUMgonCE84J+WvRZdZ/tKAicqatozk9QNmdCIHCQzB16sp1S+ultQuoqqW8OPz943khpoyKaB5XOa5QcNpgBaW13Y56Zj6TRSNhIwt4x+U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736099861; c=relaxed/simple; bh=kjdx8drPk2htg110kCICcS/Xr7XAEDzA1ho3So869ZU=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=dTv/kAxQ1YqHHTSsTVxE4/GkiBWYqCBaSMkWygHnQ3Xiy+v3CSvT9E39Qn4lTnr4UFIAEELPTldzNYss+maK/WHYXdb9OcjEeirU3zHNt+78dRVx2yiacK53Qt01Bnb1YtlZiIkRvX6bnk3+851tpcvIjuXqVZb6XG82zc134QA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com; spf=pass smtp.mailfrom=perches.com; arc=none smtp.client-ip=216.40.44.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=perches.com Received: from omf06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A4CE880E55; Sun, 5 Jan 2025 17:19:30 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf06.hostedemail.com (Postfix) with ESMTPA id AAA792000F; Sun, 5 Jan 2025 17:19:28 +0000 (UTC) Message-ID: Subject: Re: [RESEND PATCH] MAINTAINERS: Fix list entries with display names From: Joe Perches To: Rob Herring , Andrew Morton Cc: Arnd Bergmann , linux-kernel@vger.kernel.org Date: Sun, 05 Jan 2025 09:19:27 -0800 In-Reply-To: References: <20241231155415.186244-1-robh@kernel.org> <20250102154736.31706789db6a8999ca8415c4@linux-foundation.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.2 (3.54.2-1.fc41) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Rspamd-Queue-Id: AAA792000F X-Stat-Signature: sfacsecs7ffscf1tmhybjqr1bipnf6fp X-Rspamd-Server: rspamout02 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX18mUxrwPLirVbzLMgIA3cWnZeaFDJY/C4Q= X-HE-Tag: 1736097568-949302 X-HE-Meta: U2FsdGVkX19boG8quhyr1rcfi2rrq/fnQNj6HunHeKEF+oI5GezHulEdp24ypDizDGsUIqKdksipOeq4Q4quBHJumu85gTJSKBO0O2AWWjquQxc9dI1yUaeMpSd8zeSy+kiQHc/T6TEyN6k3kInb292VClPSbXxqu/TAKVxnL4hKNoAjEt67YicJS9h+cWnyzEACQ/YCo2wmgSz/lc14rQ4WkpKihzZXWAnwA5smGdP8yS0O/li2/b8SA56dVMJQx54AM8iWkvnkVL3ISUDmDF2KPFGUfZM7GGttDZ3r0zGaddX3aM9zti7Dm2W4CobPqiUV0hSBxspUEYCBsobIuCmokzhH/DeSWGC+m+gWo+07s4BKxPHYGbtUQk4eZRfa2jaPL22SHcIEvmFKDXzNMg== On Fri, 2025-01-03 at 08:08 -0600, Rob Herring wrote: > On Thu, Jan 2, 2025 at 5:47=E2=80=AFPM Andrew Morton <[akpm@linux-foundat= ion.org](mailto:akpm@linux-foundation.org)> wrote: > > On Tue, 31 Dec 2024 09:54:14 -0600 "Rob Herring (Arm)" <[robh@kernel.or= g](mailto:robh@kernel.org)> wrote: > > > get_maintainers.pl doesn't expect list entries to have a display name= . > > > Entries with a display name are omitted and print just the descriptio= n: > > >=20 > > > (open list:PIN CONTROLLER - FREESCALE) > > >=20 > > > These cases are pretty much aliases to a few people, not lists which > > > are archived and can be subscribed to. Change these cases to be revie= wers > > > instead. > >=20 > > Feels a bit wrong. Are you sure that *all* of the below "lists" are > > not really lists? If so then OK I suppose. Or perhaps we should have > > a new MAINTAINERS tag to cover this situation. > They certainly don't look like anything anyone outside those > organizations can subscribe to or would have public archives. Whether > they are lists or aliases internally doesn't matter to us. > > And shouldn't get_maintainer be made to be more friendly in its > > handling of these entries? Omitting the email address seems kinda dumb= . > >=20 [] > That's certainly an alternate or additional fix. I was hoping Joe > would know where to fix that rather than me trying to wade thru perl. > :) Maybe something like this: --- scripts/get_maintainer.pl | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index ee1aed7e090ca..c5486827c81b5 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -1332,6 +1332,7 @@ sub add_categories { my $ptype =3D $1; my $pvalue =3D $2; if ($ptype eq "L") { + my $list_name =3D ""; my $list_address =3D $pvalue; my $list_additional =3D ""; my $list_role =3D get_list_role($i); @@ -1339,10 +1340,16 @@ sub add_categories { if ($list_role ne "") { $list_role =3D ":" . $list_role; } - if ($list_address =3D~ m/([^\s]+)\s+(.*)$/) { + if ($list_address =3D~ m/^([^\<]+)\<(\S+@\S+)\>\s*(.*)$/) { + $list_name =3D $1; + $list_address =3D $2; + $list_additional =3D $3; + $list_name =3D~ s/^\s+|\s+$//g; #trim + } elsif ($list_address =3D~ m/([^\s]+)\s+(.*)$/) { $list_address =3D $1; $list_additional =3D $2; } + if ($list_additional =3D~ m/subscribers-only/) { if ($email_subscriber_list) { if (!$hash_list_to{lc($list_address)}) {