mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Geetha sowjanya <gakula@marvell.com>, netdev@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Hariprasad Kelam <hkelam@marvell.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>,
	Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
	Sunil Goutham <sgoutham@marvell.com>
Subject: Re: [net-next PATCH v9 05/11] octeontx2-af: Add packet path between representor and VF
Date: Fri, 12 Jul 2024 21:52:14 +0200	[thread overview]
Message-ID: <fd40e1b9-cb76-4617-b699-19f1f580fe98@web.de> (raw)
In-Reply-To: <20240712175520.7013-6-gakula@marvell.com>

> Current HW, do not support in-built switch which will forward pkts
…
              does?          built-in?

How do you think about to avoid any abbreviations for another improved change description?


…
> +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_rep.c
> +void rvu_rep_update_rules(struct rvu *rvu, u16 pcifunc, bool ena)
> +{
> +	rvu_switch_enable_lbk_link(rvu, pcifunc, ena);
> +	mutex_lock(&mcam->lock);
> +	for (entry = 0; entry < max; entry++) {
> +	}
> +	mutex_unlock(&mcam->lock);
> +}
…

Under which circumstances would you become interested to apply a construct
like “scoped_guard(mutex, &mcam->lock)”?
https://elixir.bootlin.com/linux/v6.10-rc7/source/include/linux/cleanup.h#L137

Regards,
Markus

  reply	other threads:[~2024-07-12 19:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-12 17:55 [net-next PATCH v9 00/11] Introduce RVU representors Geetha sowjanya
2024-07-12 17:55 ` [net-next PATCH v9 01/11] octeontx2-pf: Refactoring RVU driver Geetha sowjanya
2024-07-12 17:55 ` [net-next PATCH v9 02/11] octeontx2-pf: RVU representor driver Geetha sowjanya
2024-07-12 17:55 ` [net-next PATCH v9 03/11] octeontx2-pf: Create representor netdev Geetha sowjanya
2024-07-12 17:55 ` [net-next PATCH v9 04/11] octeontx2-pf: Add basic net_device_ops Geetha sowjanya
2024-07-12 17:55 ` [net-next PATCH v9 05/11] octeontx2-af: Add packet path between representor and VF Geetha sowjanya
2024-07-12 19:52   ` Markus Elfring [this message]
2024-07-12 17:55 ` [net-next PATCH v9 06/11] octeontx2-pf: Get VF stats via representor Geetha sowjanya
2024-07-12 17:55 ` [net-next PATCH v9 07/11] octeontx2-pf: Add support to sync link state between representor and VFs Geetha sowjanya
2024-07-12 17:55 ` [net-next PATCH v9 08/11] octeontx2-pf: Configure VF mtu via representor Geetha sowjanya
2024-07-12 17:55 ` [net-next PATCH v9 09/11] octeontx2-pf: Add representors for sdp MAC Geetha sowjanya
2024-07-12 17:55 ` [net-next PATCH v9 10/11] octeontx2-pf: Add devlink port support Geetha sowjanya
2024-07-12 17:55 ` [net-next PATCH v9 11/11] octeontx2-pf: Implement offload stats ndo for representors Geetha sowjanya
2024-07-13  5:06 ` [net-next PATCH v9 00/11] Introduce RVU representors Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fd40e1b9-cb76-4617-b699-19f1f580fe98@web.de \
    --to=markus.elfring@web.de \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gakula@marvell.com \
    --cc=hkelam@marvell.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sbhatta@marvell.com \
    --cc=sgoutham@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®