From: Damien Le Moal <dlemoal@kernel.org>
To: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>
Cc: kernel test robot <lkp@intel.com>,
oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
Hannes Reinecke <hare@suse.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Bart Van Assche <bvanassche@acm.org>
Subject: Re: block/blk-zoned.c:579:5-24: WARNING: atomic_dec_and_test variation before object free at line 583.
Date: Thu, 7 Nov 2024 07:53:04 +0900 [thread overview]
Message-ID: <fd494e1c-9d77-424c-b397-af7059ee1fe7@kernel.org> (raw)
In-Reply-To: <5b55417d-6b27-4186-bcfa-d6952624e99f@kernel.dk>
On 11/6/24 00:56, Jens Axboe wrote:
> On 11/5/24 8:37 AM, Christoph Hellwig wrote:
>> On Tue, Nov 05, 2024 at 08:36:33AM -0700, Jens Axboe wrote:
>>> On 11/5/24 8:34 AM, Christoph Hellwig wrote:
>>>> On Tue, Nov 05, 2024 at 06:52:25AM +0800, kernel test robot wrote:
>>>>>>> block/blk-zoned.c:579:5-24: WARNING: atomic_dec_and_test variation before object free at line 583.
>>>>
>>>> Does anyone know what this warning is supposed to mean?
>>>
>>> It's supposed to mean "use refcount_t for things like this".
>>
>> Have we finally resolved the performance problems with refcount_t for
>> fast path operations?
>
> I mean it's closer, but it's still slower. Will always be so. Does it
> matter for zoned devices? Probably not.
>
> I don't think it matters for this case. It's not like the ref itself is
> something that is user controllable in terms of being able to get
> anywhere near an overflow.
OK. Will work on a patch to switch to refcount.
--
Damien Le Moal
Western Digital Research
prev parent reply other threads:[~2024-11-06 22:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-04 22:52 kernel test robot
2024-11-05 15:34 ` Christoph Hellwig
2024-11-05 15:36 ` Jens Axboe
2024-11-05 15:37 ` Christoph Hellwig
2024-11-05 15:56 ` Jens Axboe
2024-11-06 22:53 ` Damien Le Moal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd494e1c-9d77-424c-b397-af7059ee1fe7@kernel.org \
--to=dlemoal@kernel.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=martin.petersen@oracle.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®