From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E1F7C05027 for ; Mon, 6 Feb 2023 06:52:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229734AbjBFGwq (ORCPT ); Mon, 6 Feb 2023 01:52:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229499AbjBFGwo (ORCPT ); Mon, 6 Feb 2023 01:52:44 -0500 Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FADFEB48; Sun, 5 Feb 2023 22:52:41 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R451e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046059;MF=tianruidong@linux.alibaba.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_---0VaylKZS_1675666353; Received: from 30.221.133.155(mailfrom:tianruidong@linux.alibaba.com fp:SMTPD_---0VaylKZS_1675666353) by smtp.aliyun-inc.com; Mon, 06 Feb 2023 14:52:39 +0800 Message-ID: Date: Mon, 6 Feb 2023 14:52:32 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] ACPICA: PCI: Undefined ACPI_ADR_SPACE_PCI_CONFIG when CONFIG_PCI is unset Content-Language: en-US To: "Rafael J. Wysocki" Cc: robert.moore@intel.com, rafael.j.wysocki@intel.com, lenb@kernel.org, linux-acpi@vger.kernel.org, acpica-devel@lists.linuxfoundation.org, linux-kernel@vger.kernel.org, baolin.wang@linux.alibaba.com, jkchen@linux.alibaba.com, xueshuai@linux.alibaba.com References: <20230202034821.25123-1-tianruidong@linux.alibaba.com> From: Ruidong Tian In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch depends on kernel-specific ACPICA configuration, can I submit it to ACPICA projects? On 2023/2/2 17:31, Rafael J. Wysocki wrote: > On Thu, Feb 2, 2023 at 4:48 AM Ruidong Tian > wrote: >> ACPI core subsystem initialization will fail when Kernel disabled PCI but >> ACPI tables still have PCI config address spaces. >> >> Enable ACPI_ADR_SPACE_PCI_CONFIG in acpi_gbl_default_address_spaces >> only when ACPI_PCI_CONFIGURED is defined. >> >> Signed-off-by: Ruidong Tian > As an ACPICA change, this should first be submitted (as a pull > request) to the upstream ACPICA project on GitHub. > > Having done that, please resubmit the patch with a Link tag pointing > to the corresponding upstream pull request. > > Thanks! > >> --- >> drivers/acpi/acpica/evhandler.c | 2 ++ >> include/acpi/acconfig.h | 4 ++++ >> 2 files changed, 6 insertions(+) >> >> diff --git a/drivers/acpi/acpica/evhandler.c b/drivers/acpi/acpica/evhandler.c >> index be9a05498adc..86057e39df8c 100644 >> --- a/drivers/acpi/acpica/evhandler.c >> +++ b/drivers/acpi/acpica/evhandler.c >> @@ -26,7 +26,9 @@ acpi_ev_install_handler(acpi_handle obj_handle, >> u8 acpi_gbl_default_address_spaces[ACPI_NUM_DEFAULT_SPACES] = { >> ACPI_ADR_SPACE_SYSTEM_MEMORY, >> ACPI_ADR_SPACE_SYSTEM_IO, >> +#ifdef ACPI_PCI_CONFIGURED >> ACPI_ADR_SPACE_PCI_CONFIG, >> +#endif >> ACPI_ADR_SPACE_DATA_TABLE >> }; >> >> diff --git a/include/acpi/acconfig.h b/include/acpi/acconfig.h >> index 151e40385673..28456120529f 100644 >> --- a/include/acpi/acconfig.h >> +++ b/include/acpi/acconfig.h >> @@ -162,7 +162,11 @@ >> /* Maximum space_ids for Operation Regions */ >> >> #define ACPI_MAX_ADDRESS_SPACE 255 >> +#ifdef ACPI_PCI_CONFIGURED >> #define ACPI_NUM_DEFAULT_SPACES 4 >> +#else >> +#define ACPI_NUM_DEFAULT_SPACES 3 >> +#endif >> >> /* Array sizes. Used for range checking also */ >> >> -- >> 2.33.1 >>