mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Yang Xiwen <forbidden405@outlook.com>, Rob Herring <robh@kernel.org>
Cc: Jakub Kicinski <kuba@kernel.org>,
	linux-kernel@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
	Conor Dooley <conor+dt@kernel.org>,
	Yisen Zhuang <yisen.zhuang@huawei.com>,
	netdev@vger.kernel.org, Salil Mehta <salil.mehta@huawei.com>,
	devicetree@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Andrew Lunn <andrew@lunn.ch>,
	Yang Xiwen <forbidden405@foxmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Eric Dumazet <edumazet@google.com>,
	Russell King <linux@armlinux.org.uk>
Subject: Re: [PATCH 4/6] dt-bindings: net: add hisilicon-femac
Date: Fri, 16 Feb 2024 08:20:11 +0100	[thread overview]
Message-ID: <fd4b58d4-5420-4605-8f44-7c4d53c7a094@linaro.org> (raw)
In-Reply-To: <SEZPR06MB6959E0F113C7C7CF2669E40D964C2@SEZPR06MB6959.apcprd06.prod.outlook.com>

On 16/02/2024 07:30, Yang Xiwen wrote:
> On 2/16/2024 10:09 AM, Rob Herring wrote:
>> On Fri, 16 Feb 2024 07:48:56 +0800, Yang Xiwen wrote:
>>> This binding gets rewritten. Compared to previous txt based binding doc,
>>> the following changes are made:
>>>
>>> - No "hisi-femac-v1/2" binding anymore
>>> - Remove unused Hi3516 SoC, add Hi3798MV200
>>> - add MDIO subnode
>>> - add phy clock and reset
>>>
>>> Signed-off-by: Yang Xiwen <forbidden405@outlook.com>
>>> ---
>>>   .../devicetree/bindings/net/hisilicon-femac.yaml   | 125 +++++++++++++++++++++
>>>   1 file changed, 125 insertions(+)
>>>
>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> Documentation/devicetree/bindings/net/hisilicon-femac.example.dtb: /example-0/ethernet@9c30000/mdio@1100: failed to match any schema with compatible: ['hisilicon,hisi-femac-mdio']
> it's fine. This compatible is documented in a plain text file 
> `./hisi-femac-mdio.txt`.

No, it is not fine. This must be fixed.

Best regards,
Krzysztof


  reply	other threads:[~2024-02-16  7:20 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-15 23:48 [PATCH 0/6] net: hisi-femac: add support for Hi3798MV200, remove unmaintained compatibles Yang Xiwen via B4 Relay
2024-02-15 23:48 ` [PATCH 1/6] net: hisilicon: add support for hisi_femac core on Hi3798MV200 Yang Xiwen via B4 Relay
2024-02-15 23:57   ` Andrew Lunn
2024-02-15 23:59     ` Yang Xiwen
2024-02-16 13:49       ` Andrew Lunn
2024-02-16 13:58         ` Yang Xiwen
2024-02-16 13:23   ` Andrew Lunn
2024-02-16 13:41     ` Yang Xiwen
2024-02-16 13:58       ` Andrew Lunn
2024-02-16 14:08         ` Yang Xiwen
2024-02-26  9:13   ` Dan Carpenter
2024-02-15 23:48 ` [PATCH 2/6] net: hisi_femac: remove unused compatible strings Yang Xiwen via B4 Relay
2024-02-16  7:20   ` Krzysztof Kozlowski
2024-02-16  8:21     ` Yang Xiwen
2024-02-16  8:26       ` Krzysztof Kozlowski
2024-02-16  8:39         ` Yang Xiwen
2024-02-16 13:01           ` Andrew Lunn
2024-02-16 20:05             ` Conor Dooley
2024-02-16 20:09               ` Yang Xiwen
2024-02-15 23:48 ` [PATCH 3/6] dt-bindings: net: remove outdated hisilicon-femac Yang Xiwen via B4 Relay
2024-02-16  7:21   ` Krzysztof Kozlowski
2024-02-16  8:03     ` Yang Xiwen
2024-02-16  8:23       ` Krzysztof Kozlowski
2024-02-15 23:48 ` [PATCH 4/6] dt-bindings: net: add hisilicon-femac Yang Xiwen via B4 Relay
2024-02-16  0:06   ` Andrew Lunn
2024-02-16  0:20     ` Yang Xiwen
2024-02-16  2:09   ` Rob Herring
2024-02-16  6:30     ` Yang Xiwen
2024-02-16  7:20       ` Krzysztof Kozlowski [this message]
2024-02-16  7:24   ` Krzysztof Kozlowski
2024-02-16  9:36     ` Yang Xiwen
2024-02-16  9:41       ` Krzysztof Kozlowski
2024-02-16  9:48         ` Yang Xiwen
2024-02-16 13:11   ` Andrew Lunn
2024-02-16 13:33     ` Yang Xiwen
2024-02-16 14:10       ` Andrew Lunn
2024-02-16 14:29         ` Yang Xiwen
2024-02-15 23:48 ` [PATCH 5/6] net: mdio: hisi-femac: make clock optional Yang Xiwen via B4 Relay
2024-02-15 23:48 ` [PATCH 6/6] dt-bindings: net: hisilicon-femac-mdio: " Yang Xiwen via B4 Relay
2024-02-16  7:25   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fd4b58d4-5420-4605-8f44-7c4d53c7a094@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=forbidden405@foxmail.com \
    --cc=forbidden405@outlook.com \
    --cc=hkallweit1@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=salil.mehta@huawei.com \
    --cc=yisen.zhuang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®