mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
To: Bjorn Andersson <andersson@kernel.org>
Cc: konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: monaco: extend fastrpc compute cb
Date: Thu, 26 Mar 2026 15:38:07 +0000	[thread overview]
Message-ID: <fd537c2e-3ae4-4c96-bad4-64f846f2f17b@oss.qualcomm.com> (raw)
In-Reply-To: <acUzKYUCbUOIOrw2@baldur>

On 3/26/26 1:24 PM, Bjorn Andersson wrote:
> On Thu, Mar 26, 2026 at 12:58:34PM +0000, Srinivas Kandagatla wrote:
>> diff --git a/arch/arm64/boot/dts/qcom/monaco.dtsi b/arch/arm64/boot/dts/qcom/monaco.dtsi
> [..]
>> +
>> +					compute-cb@b {
> 
> That doesn't match the patternProperties "(compute-)?cb@[0-9]*$".
> 
> Is the reg an index, or an "address"? Should we use base 10, or should
> we fix the yaml?

Ah.. sorry for this, will fix this in next spin,

--srini

> 
> Regards,
> Bjorn
> 
>> +						compatible = "qcom,fastrpc-compute-cb";
>> +						reg = <0xb>;
>> +						iommus = <&apps_smmu 0x19cb 0x0400>;
>> +						dma-coherent;
>> +					};
>> +
>> +					compute-cb@c {
>> +						compatible = "qcom,fastrpc-compute-cb";
>> +						reg = <0xc>;
>> +						iommus = <&apps_smmu 0x19cc 0x000>;
>> +						dma-coherent;
>> +					};
>>  				};
>>  			};
>>  		};
>> -- 
>> 2.47.3
>>


  reply	other threads:[~2026-03-26 15:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-26 12:58 Srinivas Kandagatla
2026-03-26 13:24 ` Bjorn Andersson
2026-03-26 15:38   ` Srinivas Kandagatla [this message]
2026-03-30 16:01 ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fd537c2e-3ae4-4c96-bad4-64f846f2f17b@oss.qualcomm.com \
    --to=srinivas.kandagatla@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®