From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934239AbcIFVsb (ORCPT <rfc822;w@1wt.eu>);
        Tue, 6 Sep 2016 17:48:31 -0400
Received: from bhuna.collabora.co.uk ([46.235.227.227]:56463 "EHLO
        bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932651AbcIFVsa (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 6 Sep 2016 17:48:30 -0400
Subject: Re: [PATCH v3 5/5] net: asix: autoneg will set WRITE_MEDIUM reg
To: Grant Grundler <grundler@google.com>,
        Eric Dumazet <eric.dumazet@gmail.com>
References: <cover.c702ef6af13be7c1282a2f2d3189281fdc327abe.1472155176.git-series.robert.foss@collabora.com>
 <9d5c5525f369f1c4098bda989d73886d11036bae.1472155176.git-series.robert.foss@collabora.com>
 <1472748216.5019.46.camel@edumazet-glaptop3.roam.corp.google.com>
 <18052c6d-2cb1-0927-7d33-92d4bd397aa4@collabora.com>
 <1472749350.5019.52.camel@edumazet-glaptop3.roam.corp.google.com>
 <CANEJEGtE7R_FhGJfw8hayuiQi1Wbo2cYFN9MbcYzm6+Whs=2Qw@mail.gmail.com>
Cc: Freddy Xin <freddy@asix.com.tw>, Dean_Jenkins@mentor.com,
        Mark_Craske@mentor.com, David Miller <davem@davemloft.net>,
        ivecera@redhat.com, john.stultz@linaro.org,
        Vincent Palatin <vpalatin@chromium.org>, stephen@networkplumber.org,
        Grant Grundler <grundler@chromium.org>,
        Chia-Sheng Chang <changchias@gmail.com>,
        Allan Chou <allan@asix.com.tw>, andrew@lunn.ch, tremyfr@gmail.com,
        colin.king@canonical.com,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        netdev <netdev@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        Vincent Palatin <vpalatin@google.com>
From: Robert Foss <robert.foss@collabora.com>
Message-ID: <fd5a0166-6b90-3992-448f-2c5f990b572c@collabora.com>
Date: Tue, 6 Sep 2016 17:48:12 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <CANEJEGtE7R_FhGJfw8hayuiQi1Wbo2cYFN9MbcYzm6+Whs=2Qw@mail.gmail.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 2016-09-06 12:41 PM, Grant Grundler wrote:
> On Thu, Sep 1, 2016 at 10:02 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>> On Thu, 2016-09-01 at 12:47 -0400, Robert Foss wrote:
>>
>>> I'm not quite sure how the first From line was added, it
>>> should not have been.
>>> Grant Grundler is most definitely the author.
>>>
>>> Would you like me to resubmit in v++ and make sure that it has been
>>> corrected?
>>
>> This is too late, patches are already merged in David Miller net-next
>> tree.
>>
>> These kinds of errors can not be fixed, we have to be very careful at
>> submission/review time.
>>
>> I guess Grant does not care, but some contributors, especially new ones
>> would like to get proper attribution.
>
> I do not mind. Robert will get email about bugs instead of me. :D

Thanks Grant, sorry about the mixup!


Rob.