From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755941AbcHBSw7 (ORCPT ); Tue, 2 Aug 2016 14:52:59 -0400 Received: from mail-cys01nam02on0058.outbound.protection.outlook.com ([104.47.37.58]:54591 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751549AbcHBSwk (ORCPT ); Tue, 2 Aug 2016 14:52:40 -0400 Authentication-Results: spf=pass (sender IP is 63.163.107.225) smtp.mailfrom=sandisk.com; mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=bestguesspass action=none header.from=sandisk.com;mellanox.com; dkim=none (message not signed) header.d=none; X-AuditID: ac160c71-20b1198000000e72-30-57a0b74b3414 Subject: Re: [PATCH 0269/1285] Replace numeric parameter like 0444 with macro To: Baole Ni , , , , References: <20160802105508.31682-1-baolex.ni@intel.com> CC: , , , , , , , , , , , From: Bart Van Assche Message-ID: Date: Tue, 2 Aug 2016 08:14:10 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <20160802105508.31682-1-baolex.ni@intel.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHIsWRmVeSWpSXmKPExsWyRoxnka739gXhBq/f6FqceXKU3eLzhn9s FtO/7GO2uP7tDaPFy/MfWC2+HYywOLD4EqPFqsNvWSyOL7W22Lh5IqPFlF9LmS0u75rDZvHs UC+Lxb8TN9gs3rx0sph+6zijRfP6DSwOgh7fW/tYPHbOusvusXjPSyaPTas62TyeXJnO5PFs +mEmj/f7rrJ5fN4kF8ARxWWTkpqTWZZapG+XwJXxZsZkpoIOgYo/P+6yNTDe4e1i5OSQEDCR uDJhG3sXIxeHkMBSJomJE5+yQjjbGSVONU9lh6nq2dXOAlXFKNHUOYsRJCEs4CsxdeVZMFtE oF7iyOXZbCC2kICFxJSjp5lAGpgFljFJdHa/B0uwCRhJfHs/kwXE5hWwk1j/ZDtYM4uAisTD hh9gNaICYRLT7r5lh6gRlDg58wlQPQcHp4ClxPQPPiAms4C9xIOtZSAVzALyEtvfzmGGuHMF m8S597wQJ6hLnFwyn2kCo/AsJINmIXTPQtK9gJF5FaNYbmZOcW56aoGhiV5xYl5KZnG2XnJ+ 7iZGSKwW7mB8fdv7EKMAB6MSD++PrPnhQqyJZcWVuYcYJTiYlUR42bcsCBfiTUmsrEotyo8v Ks1JLT7EKM3BoiTOezH6Y5iQQHpiSWp2ampBahFMlomDU6qBcbcMw7zU7Otq5kX8TmseCj1z +G+xP+SJ5G+FutfPxba+bf0lMNvEpaTx4OQS/vobFwvsdgbMYbcIY37suNTzemlzKeOrFyqJ pptvWzH1b+VaPfWiV8ci1T75EwlbGVf3dRx9u29KHZ/Sgs0CISn1bh1X9Go+fZ64uUPhi7Ls yjU3DPbEOfOmKbEUZyQaajEXFScCAIyzzu7RAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrKLMWRmVeSWpSXmKPExsXCtZEjRffojgXhBvf3KliceXKU3eLzhn9s FtO/7GO2uP7tDaPFy/MfWC2+HYywOLD4EqPFqsNvWSyOL7W22Lh5IqPFlF9LmS0u75rDZvHs UC+Lxb8TN9gs3rx0sph+6zijRfP6DSwOgh7fW/tYPHbOusvusXjPSyaPTas62TyeXJnO5PFs +mEmj/f7rrJ5fN4kF8ARxWWTkpqTWZZapG+XwJXxZsZkpoIOgYo/P+6yNTDe4e1i5OSQEDCR 6NnVztLFyMUhJLCYUWL9pw1sIAlhAV+JqSvPMoLYIgLlEutmXmMBsYUELCSmHD3NBGIzC/Qw SZzbEwxiswkYSXx7PxOshlfATmL9k+1gvSwCKhIPG36AzRQVCJOYdvctO0SNoMTJmU+A6jk4 OAUsJaZ/8IEYaStxZ+5uZghbXmL72znMExj5ZiHpmIWkbBaSsgWMzKsYxXIzc4pz0zMLDI30 ihPzUjKLs/WS83M3MYIjhjNqB+P1ieaHGJk4OKUaGIUKVbkZNPUeck9YXlR1v3/Wn1usa86L RxptD3HW6zL2zznqqPRCwXxBGUuRYaXKVqkST7m7dwWne84++5DpmuvnQ982C/0sfVwakXbU T5w3688Chx2Ch6LlG1R/8vvMZn+orLpy7ZN9HtMdLu6QeNycmbZs1rPbb258efvS6ATfG5uH E5LKJyuxFGckGmoxFxUnAgA0B164SAIAAA== X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:63.163.107.225;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(438002)(24454002)(377454003)(199003)(189002)(54356999)(47776003)(76176999)(87936001)(106466001)(2201001)(50986999)(31686004)(53416004)(92566002)(23746002)(33646002)(65806001)(7416002)(86362001)(2950100001)(2906002)(77096005)(2270400002)(356003)(7846002)(4326007)(4001350100001)(68736007)(305945005)(11100500001)(36756003)(5001770100001)(50466002)(7696003)(64126003)(189998001)(97736004)(81166006)(586003)(65956001)(19580395003)(83506001)(31696002)(8676002)(8936002)(81156014)(69596002)(230700001)(19580405001)(65826006);DIR:OUT;SFP:1101;SCL:1;SRVR:DM2PR02MB1308;H:milsmgep14.sandisk.com;FPR:;SPF:Pass;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11OLC015;1:H9T3k5a7kPyJHfNeXlvsG3b5ij7AJUqvlYzNTsaZciiVjCHpSj8q6IeN29+Ku6qw1EF2afSdyUuPHxU2QeMl8fZRexNGZF60290WfO0ljO0ZegRiO4ljGwx6/rly/RjmahyikRklL3skGjMjQG+IddU5D0fPQxj3GDAM7U/tSinZOC0I/oo1GK9S8nCuqbNOJefZ17ScTbUsOv+R2RN1S3qPD6TRg70Ac6Bimi5rDq40IZMIwCTQeQbWZrk6DK5olnJlQonet5To3xHreRs6nEgQSqZ2rwwHUUTeU2KcrXv7d4F/jCfpHSrerSJBdOHlewwXi/bAXfNmOPJ0MT8R6xrRnUSzyz7EvF8yjZWclcby23elZdR0b1zxB30wl+nqQz9bCsNAeBzz++kAE02fxwCGMD7lH6zogJEnZDRoA40ISCpUKWZidGUsYNsMnAcILpt3MWBd74oN8li8Uel8yDSRtuUKtTStUB7WmBOAj5ZgV3cz+8q1ihsAptFSwAIMKxgo1m8Eoz4oByYOGapdsL0J81/n9WMEcR9iAy9xa+2P4+bepA6weqMIZVyp8TFM X-MS-Office365-Filtering-Correlation-Id: c67331a3-b95e-40c0-55d4-08d3bae7abb0 X-Microsoft-Exchange-Diagnostics: 1;DM2PR02MB1308;2:uHf2ttSxYKk9XUJUysmG5vCrGdxPrCAkMaAVEm1bE5qxoGFCrgYsp+xxQyIqJxFGRLmRjwQ1wWI0RhZ8hf3wwuQ4jrz+pGxk3dHGJ1AZhmkLJ7P9kW5xpyVg2h1kyfOMi5B6CktUlJwABUY3BoDaP/tGKTA5SllwpPG1OcpzJq4clHWjEKD8wHlx6oQgsUMB;3:KeGc/eEnoiIFmNP9O1mo5hz2F5gUuvymIug5k2z/X/Y7aj5U7nP6HXoqgrEubjmoc+S7mFt/9lR1WZKXK7KijwVuPQYpiASpkpE1l4j+IiM/y8N2tTjBHPRQKloGB9yOw49ud5XGlQ6Vi4ch/pnBlf1LoIvdUu0BEzDaY7o3jlF9GqI6sNRqHkbKyJyTDGZK5x+HE3kqpXSyV6tbi67HnpxQv4BA47/WFArZtVCP3IVQi2yV4u44WGqTxHLqR0gufsMFA7HiZA0exB2mmtEBKA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:DM2PR02MB1308; X-Microsoft-Exchange-Diagnostics: 1;DM2PR02MB1308;25:8eoUiYdQBHy5guWvYL+ecgsQBwRq1uAo+grqokRw7OkKiBgwmc0Usjd99Nxgnb0x6ik1A+YGMW3C4kD7A2hFe+A0AGWvxeitWrdX1i2S6v03hAs16+7XM1xmPxogQuNWgb32Rl0iOL0xsdun7jC/7NaPLoxrqTz+qyDBPCCq/tzl2Me7M437ovFjZA5wotIs5mJWilqF+rKU6WL/DT2CiF3w5tKcjH9B1HHCduxnUmvPXGsur9htoaXGcRmeY8lHdMwVUNKTVGTnIccN6GWP/C8IsHC6H1RxmOe4N29KQwQVZ7h78ODdOTXbYB7Fpg9hcLWHe818A2cuqe/nxKJf03Ux6tYk2Z4tW3B+pdpB/rqo/8qJZeuCWJ/zqwcRou0Yt5bOnwOG+NfkhHBZbu+1pLuakBlCR+CpnyJRRtx4ZX+r2SR+/xLA5s7ePfB3ZqlSO6eJ7uAp+HDf0V16v3fQDJP4c/yArxSV/RoQVpAn8pJvePgZzJ0J572+fCNT1QOSIMPCFPFTlmUsxJaLJy5GpK0khz4gs7bV3hQCFo2rJ3RF53Tw6T9YAqmjFzoQet8gJf9ExI6vT3uP00s2BTgkqCQy0MS2XvKkkw89DyrqYX0i7Il+i40YQEiwmpbab5OQXjf651UslZTTkM6HeV8HFYimME4L/USsNhQehyEQU8ho8Qmyyk5URuM96EcaISwlJjYgcVir7gjTdgrkLooVQBrIwgc2RYRAQnALZFlVUpbZ3Stct62hzC/3lrd/6oJeBscO+afwxDW8SKkxy7o+7g== X-Microsoft-Exchange-Diagnostics: 1;DM2PR02MB1308;31:4H/YCOgOzYROKbCJiBZ0AtWHEbliL6xKtndNJSobDEvfZ/NsQncVbHNSHswH9aGMKxmh9wJRSemjYwskOzqt3HHouN7n/ZtbMHGcgimfMdyoODjZ6BCAqXgV8YMBao19PzrARfAlDDziFa7I/TcDylC8OL+982Re4qXcTyTFnd029kTQKUwPHrFOkiaYvVhbGOGW7bEu3OK2jfAFEwXlLhNQ682e051mhPDXNwJF/qg=;20:syUCq3V7wXZ9MOUvsXFx3xr3Zb+ybgvwPeasMJlXg4K7FGNGwQF0u3LNppgr1HmYvu4VWa3yQ/kb5nNT4LuGo+IZZpyvMEbLig9Ki3VbGSfWjcOp5axg9C0guFkvA/JkuyMXgu05xTjg9bzzywN4kA+iK8j9sOgE9o4qav04aTEBpSbuNo8CjMU+atjwcTjLr0AFZ6kcwVNEnQei+sNh0nLGbhGp1Ep2M4hL7OCK4TwrrmqLweK8rs4kENjQC07cE6AXdz1ICYGuDw6YAj3V50CcBKT+SsXK/bLmxkMXZGOYnJhixhqhnPR7wZQWDpdEdu/GUGZRIpZv1pp696GvMyeQpzwZmOk9d7Yd8RiDdR1y+wH2CGb9IpQvPSYPr9C/S164IFgzIFqgiFtbbVSFonsplhZwIPjLSDmHiKXWihwKFk/OtFVacOvgJQWoANEe0IKS35M68gFVWIsjmpql7fw1HYBXJGofTUejFF0JDLUrB7Tx+FrmWFTDHIojpU1q X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(788757137089)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13018025)(13016025)(5005006)(8121501046)(3002001)(10201501046)(6055026);SRVR:DM2PR02MB1308;BCL:0;PCL:0;RULEID:;SRVR:DM2PR02MB1308; X-Microsoft-Exchange-Diagnostics: 1;DM2PR02MB1308;4:xyFJb4cND6duDwKCpZ7I0LsosQskJewU+6GgBggIXde6tKDrK3+/IZw0pqCsACozaN10a9tEtrHo7SLgh9CuJ+HdBgwKIE7tqSSiER42y0IRiZh8wnlk9ZvJiyS8sUm6mqGDezRxkACl3Aej4hwsJbW22Ngyttzz5qqPS3mMZfQh4Wc22CwU6TeS/pIasr89OLL+81obvwusy+rlduskykY3LVtSwB7mDSm6tv4E4NkpHvXi8YTFSPhVTyRgQU+wUaXFzxz4NO3GEjQdFWxMPlARZQtvoTRMhPIyhexMnlZkxmWJLY1ME6KlfdELk53xjFvbqvdGXJuZGxYqRUgk0e0V7VHthEVyGyJoPN2JZ+UEke+0Tdbz3H6zF1uwDDtCITTb6uOU7R5VdpKH9y+evoDnw7U7qQiTLTVTM/SrJX/6n0xlIzBmJjepohAl8xviX4+yrH29SWSDBkmIMmMwbitNUIxmrcfYtOusClfT2/V6kSdYt0UtczKHt7KJysB+ X-Forefront-PRVS: 0022134A87 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DM2PR02MB1308;23:ETNWj4rnCFPsahf/9RVFTf1h3hn13WhqNfudd?= =?Windows-1252?Q?LUdmHYq5t3s/Me2UqsJjFVWITwf75Rd8AEp8/hs9lL0SpbTE47lOETvU?= =?Windows-1252?Q?xQ35yw1O4LWjaujfKq2HnLZDYYB3mpSwCCtTR/ICQORqHFcCvMB68uMW?= =?Windows-1252?Q?RDnOcI9YrQaEVE9ZDuTTCOTbCKkgcvfM4ZEmIpA+37belA1QGP9vKYIB?= =?Windows-1252?Q?2YJF45TE+xUr0UN3FFWQKe+PlT1cctrl+5ZGHSJva90G8UIuLQL3QCtd?= =?Windows-1252?Q?ZoQ3SnySAGqx6QZgxQZvjfDPKYtptTKNt5t94ZBn6mXmIcJiTbvKrZ0y?= =?Windows-1252?Q?Ppj6Kuyt50QKWKiGb23Oxl6eC/HteNm7bqHeMLSvAL8ppl6fD4s84N8U?= =?Windows-1252?Q?JVEBneSlmG0fb0WPWvvUW9QZCQ0WzK9XRZdO/dz8U9SZq2J2o8y2GXeT?= =?Windows-1252?Q?8CRxr3ITnHqN/gB+E7yOHo+VOzQVKVoZr3utC7JQfnBNjEwxeeIq2e5C?= =?Windows-1252?Q?0WpTiwjTtScTwebdWfaYTJZCcY78X2mTIsXZAQd2Ak0u1+ghbo7TDnAn?= =?Windows-1252?Q?Z/8mfi6j7NX1ueLZLqNQ/M2oK/2F47Zy1EUR8GxB5DC8xYkbIZ0EACgD?= =?Windows-1252?Q?wv4/yHelM5Y1x60nq/Xw0+3iClELOPTobOaIc+kScRKIpX800XLq1d4Q?= =?Windows-1252?Q?52jx7B1kUOLRlXxImFKUFix1Ag7bOwH28CQyua3Mi8jk1OMivDfcCf38?= =?Windows-1252?Q?ulav+az3J8pTJoX+WUbAodr2Vjab6UhRwVcVUZqAyf/iDmySzaT8kM9F?= =?Windows-1252?Q?QYoyCIs4VdauQ7C4ApVRObSSo6bLbb72bJpM8e766B9C7AQEwlVDOhDN?= =?Windows-1252?Q?gPZFHVvUuNevysM+6vDpCTilLV/PVQnj7CciRDRIQjNo07wnzNBJY//o?= =?Windows-1252?Q?tyrCChqXTr9SxmTk3I6dOY5h3UX3xhIyXWwFRB9NKw26po6yfSSssm0o?= =?Windows-1252?Q?W+Whohocz/aRdLfnkO6QLc5As/xlR3m/ZW7BMLcn+nhR8IHlPBO7msZq?= =?Windows-1252?Q?ntAjdk8FLADHsuo2bP80pTwsB/saknTFD52i7zRPi+4VeM02Mng+DTxl?= =?Windows-1252?Q?b2yMt749LclbKhWmf+O++N6houmC8LLI5vXvcRNNs2587nhTDvhX2Zge?= =?Windows-1252?Q?+wtLb21a1HjeRh4lVGH5HZJigkMylweUxO0wk6Oq+vHGS3X45EfJqZUh?= =?Windows-1252?Q?qisEN2HG1+4GuTv7dgT0xXH8bSUaIBW9O8eLr2+mqcmcjHc6rYPXgA3q?= =?Windows-1252?Q?Dg5ADKJG4Kbc6SmohLAil+lHiaAq1aaGnvIWhq+NFBwOlv1XM44cEVaG?= =?Windows-1252?Q?wntN4owU35cwiITDyGhXNcaLGU7c2LloQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM2PR02MB1308;6:ouF/NLCtJohvWYlhXVzpVmsdQ68n6lkZ/3bexWUkh6SwmJFkfMQIuJeC5/oJIglAnEsKsHnnPweECHfG7qPR6BXimvwnIoiZTbyOHlt4uZpf4DPR09Yr/QT0yY76xxd3JBm2MQ8+sHO8hGRhGb+ve/wVerBCNkd6i8CMqe4mYr/QG4PlqYLgsrWQtDkyQmvjmjqoxirsx8fVZcfIe55V4jdbq3amhglKatvOorl9jJv2bq5jvvuDl1q4iR+f6fN/b6dfUqi9eGuql0lvZvT3rl7cf9KtWME/aUGAU1HcSa+R/cCQTii/tvViqqEJxLRVaFhVFlGpDg+oSDLdUIWjCw==;5:5vyU9UO3nv2oi8cGQnGwr1SsyHQxfjjQ70NQuVsi6jAbe+A23REPoJveh2QVmAfHfNDzK/+ybR+mD7sDN7JAVTdMbUE8iP3b4WImegG7K/qboaB0mKkXi9cDh0pDfmIzMzB8Hfh5GGLtAZ/eAaK7ug==;24:mKD9kYSiqYAbhtAB0CRmi99fGnT+3zqNLgtSR4QODJQprG55m9w3yZthQ7iUdTNni6bmCSAGenswwGDeqitUrt7Y7vl4fjeGNrCgMnlHKPw=;7:Yf7R9qX9rAmii8EKV2CKOb8DIEqNXrMEsrgKa1Fw6QliWlE+6JYmNgAgJghoKnM+vbQoxEwlsKq8mjenKrPxqWVEdyYzUSdDXUND71MRohciQ+6raHLevtbTL6iHhD5hQFCDeUCHVhQue9mRKCBdeZyi+yHF0YzlsTWxG0xGhnY8SJLcJA0pkqpnQcSixc9E9zMvI2ohYlx0L+wiZJ3gt8g1tSIoacERwVLx8GaPQXp0Ovn41MJeKD0Unl+YUwnC SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM2PR02MB1308;20:h84TugX9IiXHNKq+AB1RPXbLJeuNVZxyrbQFbLRaNMWNUz/obEP3yAB4PZ8xtwIxSYQbGTst8EE0fRu5kC/CrFS4bRrxBr7Qkx6A9yFue9aEWOonypX6gQaeQcSomhQDzIlibcptvP8BycxC2w4nxmQvZ3M9khZhJ/Eivt53tjRtZtbSAYa/pBtVvPWKPBY53DRy2M8hLT/N4yjZVlMk/0r63RT3LuZUraEtgHZny4MCSn7nnIEDcwvkT3Vo6jD3 X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2016 15:14:16.8483 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.225];Helo=[milsmgep14.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR02MB1308 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/02/2016 03:55 AM, Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > > Signed-off-by: Chuansheng Liu > Signed-off-by: Baole Ni > --- > drivers/infiniband/ulp/ipoib/ipoib_main.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c > index 5f58c41..eed3e3c 100644 > --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c > +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c > @@ -65,15 +65,15 @@ MODULE_VERSION(DRV_VERSION); > int ipoib_sendq_size __read_mostly = IPOIB_TX_RING_SIZE; > int ipoib_recvq_size __read_mostly = IPOIB_RX_RING_SIZE; > > -module_param_named(send_queue_size, ipoib_sendq_size, int, 0444); > +module_param_named(send_queue_size, ipoib_sendq_size, int, S_IRUSR | S_IRGRP | S_IROTH); > MODULE_PARM_DESC(send_queue_size, "Number of descriptors in send queue"); > -module_param_named(recv_queue_size, ipoib_recvq_size, int, 0444); > +module_param_named(recv_queue_size, ipoib_recvq_size, int, S_IRUSR | S_IRGRP | S_IROTH); > MODULE_PARM_DESC(recv_queue_size, "Number of descriptors in receive queue"); > > #ifdef CONFIG_INFINIBAND_IPOIB_DEBUG > int ipoib_debug_level; > > -module_param_named(debug_level, ipoib_debug_level, int, 0644); > +module_param_named(debug_level, ipoib_debug_level, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); > MODULE_PARM_DESC(debug_level, "Enable debug tracing if > 0"); > #endif Hello Baole, Please change 0444 into S_IRUGO and 0644 into S_IRUGO | S_IWUSR. The latter form is more compact and hence makes the code easier to read. Thanks, Bart.