From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751415AbdKVOSy (ORCPT <rfc822;w@1wt.eu>);
        Wed, 22 Nov 2017 09:18:54 -0500
Received: from gateway22.websitewelcome.com ([192.185.47.179]:37252 "EHLO
        gateway22.websitewelcome.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1751260AbdKVOSx (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 22 Nov 2017 09:18:53 -0500
Subject: Re: [PATCH] scsi: ufs: ufshcd: fix potential NULL pointer dereference
 in ufshcd_config_vreg
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Vinayak Holikatti <vinholikatti@gmail.com>,
        "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20171120141229.GA2130@embeddedor.com>
 <yq1fu97klmc.fsf@oracle.com>
From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Message-ID: <fd650699-87a9-acd8-543b-b86064f04b84@embeddedor.com>
Date: Wed, 22 Nov 2017 08:18:45 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <yq1fu97klmc.fsf@oracle.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - gator4166.hostgator.com
X-AntiAbuse: Original Domain - vger.kernel.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - embeddedor.com
X-BWhitelist: no
X-Source-IP: 189.175.14.138
X-Source-L: No
X-Exim-ID: 1eHVrY-002lHK-4U
X-Source: 
X-Source-Args: 
X-Source-Dir: 
X-Source-Sender: ([192.168.1.69]) [189.175.14.138]:38418
X-Source-Auth: garsilva@embeddedor.com
X-Email-Count: 5
X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20=
X-Local-Domain: yes
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/21/2017 10:01 PM, Martin K. Petersen wrote:
> Gustavo A.,
>
>> _vreg_ is being dereferenced before it is null checked, hence there is a
>> potential null pointer dereference.
>>
>> Fix this by moving the pointer dereference after _vreg_ has been null
>> checked.
> Applied to 4.15/scsi-fixes, thank you!
>

Glad to help. :)

Thanks
--
Gustavo A. R. Silva