From: Suman Anna <s-anna@ti.com>
To: Miaoqian Lin <linmq006@gmail.com>
Cc: Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
<iommu@lists.linux-foundation.org>,
<linux-kernel@vger.kernel.org>, "Nagalla, Hari" <hnagalla@ti.com>
Subject: Re: [PATCH] iommu/omap: Fix missing put_device() call in omap_iommu_probe_device
Date: Mon, 10 Jan 2022 12:43:57 -0600 [thread overview]
Message-ID: <fd659736-2106-1be3-084b-7caddf2dc18e@ti.com> (raw)
In-Reply-To: <20220110022531.GA61@VICKYMQLIN-NB1.localdomain>
Hi Miaoqian,
On 1/9/22 8:43 PM, Miaoqian Lin wrote:
> Hi Suman Anna,
> On Fri, Jan 07, 2022 at 08:42:16AM -0600, Suman Anna wrote:
>> Hi Miaoqian,
>>
>>
>>> Add the corresponding 'put_device()' in the error handling paths.
>>
>> Also, need it in the regular path, not just in error handling path.
> I think after calling platform_get_drvdata() normally, the
> reference will be released in other functions, so don't need it in the
> regular path.
>
No, it's a local reference and is acquired within omap_iommu_probe_device() and
needs to be released within this function. What other function are you referring
to here?
regards
Suman
next prev parent reply other threads:[~2022-01-10 18:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 8:04 Miaoqian Lin
2022-01-07 14:42 ` Suman Anna
2022-01-10 2:43 ` Miaoqian Lin
2022-01-10 18:43 ` Suman Anna [this message]
2022-01-12 11:54 ` Miaoqian Lin
2022-03-01 6:33 ` [PATCH v2] " Miaoqian Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd659736-2106-1be3-084b-7caddf2dc18e@ti.com \
--to=s-anna@ti.com \
--cc=hnagalla@ti.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linmq006@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®