From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,UPPERCASE_50_75,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14EC8C433DB for ; Mon, 1 Feb 2021 14:25:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D20DF64DAE for ; Mon, 1 Feb 2021 14:25:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229763AbhBAOZO (ORCPT ); Mon, 1 Feb 2021 09:25:14 -0500 Received: from frasgout.his.huawei.com ([185.176.79.56]:2464 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229483AbhBAOY6 (ORCPT ); Mon, 1 Feb 2021 09:24:58 -0500 Received: from fraeml709-chm.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4DTqqM3D0Nz67jmg; Mon, 1 Feb 2021 22:20:47 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml709-chm.china.huawei.com (10.206.15.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 1 Feb 2021 15:24:14 +0100 Received: from [10.47.11.37] (10.47.11.37) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 1 Feb 2021 14:24:10 +0000 Subject: Re: [PATCH v4 2/4] perf vendor events: Add L2I_TLB, SVE, SIMD, and FP events To: Shunsuke Nakamura , , , , , , , , , , CC: , , References: <20210201111310.3231469-1-nakamura.shun@jp.fujitsu.com> <20210201111310.3231469-3-nakamura.shun@jp.fujitsu.com> From: John Garry Message-ID: Date: Mon, 1 Feb 2021 14:22:38 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <20210201111310.3231469-3-nakamura.shun@jp.fujitsu.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.11.37] X-ClientProxiedBy: lhreml754-chm.china.huawei.com (10.201.108.204) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/02/2021 11:13, Shunsuke Nakamura wrote: I think that you will need to fix the subject, like: perf vendor events arm64: Add more common and uarch events > Add the following events. It would be good to mention your reference document. > > Common architectural events: > - L2I_TLB_REFILL > - L2I_TLB > - SIMD_INST_RETIRED > - SVE_INST_RETIRED > > Common microarchitectural events: > - UOP_SPEC > - SVE_MATH_SPEC > - FP_SPEC > - FP_FMA_SPEC > - FP_RECPE_SPEC > - FP_CVT_SPEC > - ASE_SVE_INT_SPEC > - SVE_PRED_SPEC > - SVE_MOVPRFX_SPEC > - SVE_MOVPRFX_U_SPEC > - ASE_SVE_LD_SPEC > - ASE_SVE_ST_SPEC > - PRF_SPEC > - BASE_LD_REG_SPEC > - BASE_ST_REG_SPEC > - SVE_LDR_REG_SPEC > - SVE_STR_REG_SPEC > - SVE_LDR_PREG_SPEC > - SVE_STR_PREG_SPEC > - SVE_PRF_CONTIG_SPEC > - ASE_SVE_LD_MULTI_SPEC > - ASE_SVE_ST_MULTI_SPEC > - SVE_LD_GATHER_SPEC > - SVE_ST_SCATTER_SPEC > - SVE_PRF_GATHER_SPEC > - SVE_LDFF_SPEC > - FP_SCALE_OPS_SPEC > - FP_FIXED_OPS_SPEC > - FP_HP_SCALE_OPS_SPEC > - FP_HP_FIXED_OPS_SPEC > - FP_SP_SCALE_OPS_SPEC > - FP_SP_FIXED_OPS_SPEC > - FP_DP_SCALE_OPS_SPEC > - FP_DP_FIXED_OPS_SPEC > > Signed-off-by: Shunsuke Nakamura Apart from those, above: Reviewed-by: John Garry