From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B0BAC7618E for ; Fri, 21 Apr 2023 20:06:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233709AbjDUUGz (ORCPT ); Fri, 21 Apr 2023 16:06:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232177AbjDUUGx (ORCPT ); Fri, 21 Apr 2023 16:06:53 -0400 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7D602702; Fri, 21 Apr 2023 13:06:46 -0700 (PDT) Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-63b62d2f729so2208218b3a.1; Fri, 21 Apr 2023 13:06:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682107606; x=1684699606; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Dfyv5FN7xF6QzY/YKdeFbK9UZIryP5DcTEQcPzQtdzY=; b=AmHLZFnFgmuuJWoEkw91S44UBgXCSjD+Qw7TmX4o1f+ciiKZHzk5XcUKedkC4NBiqS 3Ha+qC+YWMaNvleXgeH+GdM8b4dQ3qhqZIGudHJXi3tHXbjbR237EJi1bve7PxaSPUi1 1wo9Vf8tdui9AKOdb1WWkYicltqvqhytspQH9AoNI0aergwkfCU4wfGn7UcKTSpE/vSM QtTl5ETDT2G/gHNsfD3TyB6llAybAsctN/0G1oyaluvb9CRdr6NX6B4ydRlzflAofo+D fvXx8AjYHqLeSmad1rueDVkIu/1UsOiYklet2YkiRkBxUfZJfLega5L0+6UhDmo9SrFZ TXvQ== X-Gm-Message-State: AAQBX9d6tv1Ng+0UATux4Oe4cLpFiOUri/iUml0NgJi0itCHoETmPbxJ GNI3WY0KBgHoRWCJcp5XIjE= X-Google-Smtp-Source: AKy350ZXdc4qGBNAbdHsNqr7fR3Yeo/NPEkEskreo/KMkEW84H+StzQOr19IbrV3KCX8h/loRQwoLw== X-Received: by 2002:a05:6a00:2e8f:b0:626:1523:b10d with SMTP id fd15-20020a056a002e8f00b006261523b10dmr7418054pfb.4.1682107606102; Fri, 21 Apr 2023 13:06:46 -0700 (PDT) Received: from [192.168.3.219] ([98.51.102.78]) by smtp.gmail.com with ESMTPSA id l6-20020a656806000000b0051b71e8f633sm2956011pgt.92.2023.04.21.13.06.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Apr 2023 13:06:45 -0700 (PDT) Message-ID: Date: Fri, 21 Apr 2023 13:06:43 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 3/5] scsi: ufs: core: Fix mcq nr_hw_queues Content-Language: en-US To: Po-Wen Kao , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Alim Akhtar , Avri Altman , "James E.J. Bottomley" , "Martin K. Petersen" , Matthias Brugger Cc: wsd_upstream@mediatek.com, peter.wang@mediatek.com, stanley.chu@mediatek.com, alice.chao@mediatek.com, naomi.chu@mediatek.com, chun-hung.wu@mediatek.com, cc.chou@mediatek.com, eddie.huang@mediatek.com, mason.zhang@mediatek.com, chaotian.jing@mediatek.com, jiajie.hao@mediatek.com References: <20230307065448.15279-1-powen.kao@mediatek.com> <20230307065448.15279-4-powen.kao@mediatek.com> From: Bart Van Assche In-Reply-To: <20230307065448.15279-4-powen.kao@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/6/23 22:54, Po-Wen Kao wrote: > Since MAXQ is 0 based value, add one to obtain number of hardware queue. > > Signed-off-by: Po-Wen Kao > Reviewed-by: Bean Huo > Reviewed-by: Manivannan Sadhasivam > Reviewed-by: Bart Van Assche > Reviewed-by: Stanley Chu > --- > drivers/ufs/core/ufs-mcq.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/ufs/core/ufs-mcq.c b/drivers/ufs/core/ufs-mcq.c > index a39746b2a8be..c7b807f58dca 100644 > --- a/drivers/ufs/core/ufs-mcq.c > +++ b/drivers/ufs/core/ufs-mcq.c > @@ -150,7 +150,8 @@ static int ufshcd_mcq_config_nr_queues(struct ufs_hba *hba) > u32 hba_maxq, rem, tot_queues; > struct Scsi_Host *host = hba->host; > > - hba_maxq = FIELD_GET(MAX_QUEUE_SUP, hba->mcq_capabilities); > + /* maxq is 0 based value */ > + hba_maxq = FIELD_GET(MAX_QUEUE_SUP, hba->mcq_capabilities) + 1; > > tot_queues = UFS_MCQ_NUM_DEV_CMD_QUEUES + read_queues + poll_queues + > rw_queues; Please resend this patch. Thanks, Bart.