From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CA28C25B67 for ; Thu, 26 Oct 2023 17:44:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231842AbjJZRoc (ORCPT ); Thu, 26 Oct 2023 13:44:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230456AbjJZRob (ORCPT ); Thu, 26 Oct 2023 13:44:31 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F99B90; Thu, 26 Oct 2023 10:44:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=0ii19rHf1nVXOp2vxSgggOhtMlDBC1vSwB607a85mgs=; b=PYqPs59rvYM2eqEkI3vDx5DCGx oknhVcsrdnrkXXM/PQ0bfmjVz5h3GI/m8ivHGNpFWyIkZpRKTyGKgrmVccnicd2vFh8XkUl2qXS+u Aym2fDgvgo5t/avhCSOxh3Z6wdfVFh6i+TYchr+0AFpGqnhY1XW24VUGI8+hfBQdiMcI=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1qw4PA-000Gqe-Tu; Thu, 26 Oct 2023 19:44:24 +0200 Date: Thu, 26 Oct 2023 19:44:24 +0200 From: Andrew Lunn To: Elad Nachman Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, pali@kernel.org, mrkiko.rs@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, cyuval@marvell.com Subject: Re: [PATCH v3 2/3] dt-bindings: arm64: dts: add dt-bindings for ac5x rd carrier Message-ID: References: <20231026084735.3595944-1-enachman@marvell.com> <20231026084735.3595944-3-enachman@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231026084735.3595944-3-enachman@marvell.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 26, 2023 at 11:47:34AM +0300, Elad Nachman wrote: > From: Elad Nachman > > Add dt bindings for AC5X RD COM Express Type 7 carrier board. > This board will Accept a CN9131 COM Express Type 7 CPU module. > > Signed-off-by: Elad Nachman > --- > .../devicetree/bindings/arm/marvell/armada-7k-8k.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml > index 52d78521e412..71bc94047d1b 100644 > --- a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml > +++ b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml > @@ -60,4 +60,12 @@ properties: > - const: marvell,armada-ap807-quad > - const: marvell,armada-ap807 > > + - description: AC5X RD COM Express Carrier for Armada CN9131 SoC with one external CP This description is i think technically wrong. You have the combination of the carrier and the module. > + items: > + - const: marvell,ac5x_rd_carrier > + - const: marvell,cn9131 > + - const: marvell,cn9130 > + - const: marvell,armada-ap807-quad > + - const: marvell,armada-ap807 Andrew