From: Kishon Vijay Abraham I <kishon@ti.com>
To: Axel Haslam <ahaslam@baylibre.com>, <khilman@kernel.org>,
<nsekhar@ti.com>, <david@lechnology.com>,
<gregkh@linuxfoundation.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>
Subject: Re: [PATCH 2/3] phy: da8xx-usb: rename the ohci device to ohci-da8xx
Date: Thu, 3 Nov 2016 22:20:01 +0530 [thread overview]
Message-ID: <fd6b848d-9740-70ef-6850-7f6a64e66bfb@ti.com> (raw)
In-Reply-To: <20161102124435.31777-3-ahaslam@baylibre.com>
On Wednesday 02 November 2016 06:14 PM, Axel Haslam wrote:
> There is only one ohci on the da8xx series of chips,
> so remove the ".0" when creating the phy. Also add
> the "-da8xx" postfix to be consistent across davinci
> usb drivers.
>
> Signed-off-by: Axel Haslam <ahaslam@baylibre.com>
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> drivers/phy/phy-da8xx-usb.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/phy-da8xx-usb.c b/drivers/phy/phy-da8xx-usb.c
> index 32ae78c..c85fb0b 100644
> --- a/drivers/phy/phy-da8xx-usb.c
> +++ b/drivers/phy/phy-da8xx-usb.c
> @@ -198,7 +198,8 @@ static int da8xx_usb_phy_probe(struct platform_device *pdev)
> } else {
> int ret;
>
> - ret = phy_create_lookup(d_phy->usb11_phy, "usb-phy", "ohci.0");
> + ret = phy_create_lookup(d_phy->usb11_phy, "usb-phy",
> + "ohci-da8xx");
> if (ret)
> dev_warn(dev, "Failed to create usb11 phy lookup\n");
> ret = phy_create_lookup(d_phy->usb20_phy, "usb-phy",
> @@ -216,7 +217,7 @@ static int da8xx_usb_phy_remove(struct platform_device *pdev)
>
> if (!pdev->dev.of_node) {
> phy_remove_lookup(d_phy->usb20_phy, "usb-phy", "musb-da8xx");
> - phy_remove_lookup(d_phy->usb11_phy, "usb-phy", "ohci.0");
> + phy_remove_lookup(d_phy->usb11_phy, "usb-phy", "ohci-da8xx");
> }
>
> return 0;
>
next prev parent reply other threads:[~2016-11-03 16:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-02 12:44 [PATCH 0/3] fix ohci phy name Axel Haslam
2016-11-02 12:44 ` [PATCH 1/3] ARM: davinci: da8xx: Fix ohci driver name Axel Haslam
2016-11-02 21:38 ` David Lechner
2016-11-02 12:44 ` [PATCH 2/3] phy: da8xx-usb: rename the ohci device to ohci-da8xx Axel Haslam
2016-11-02 21:41 ` David Lechner
2016-11-03 16:50 ` Kishon Vijay Abraham I [this message]
2016-11-04 5:34 ` Sekhar Nori
2016-11-04 21:04 ` Kishon Vijay Abraham I
2016-11-02 12:44 ` [PATCH 3/3] usb: ohci-da8xx: rename driver " Axel Haslam
2016-11-02 21:44 ` David Lechner
2016-11-03 11:56 ` Sekhar Nori
2016-11-03 12:19 ` Axel Haslam
2016-11-03 8:24 ` [PATCH 0/3] fix ohci phy name Axel Haslam
2016-11-03 12:00 ` Sekhar Nori
2016-11-03 13:58 ` Axel Haslam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd6b848d-9740-70ef-6850-7f6a64e66bfb@ti.com \
--to=kishon@ti.com \
--cc=ahaslam@baylibre.com \
--cc=david@lechnology.com \
--cc=gregkh@linuxfoundation.org \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®