From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Finn Thain <fthain@telegraphics.com.au>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Michael Schmitz <schmitzmic@gmail.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi/NCR5380: Avoid compiler warning when -Wimplicit-fallthrough is enabled
Date: Mon, 8 Apr 2019 18:44:47 -0500 [thread overview]
Message-ID: <fd71e91a-92e4-9e96-7d5a-4d9a58f7128f@embeddedor.com> (raw)
In-Reply-To: <4e853f171366e040818346def7fb043347670662.1551995342.git.fthain@telegraphics.com.au>
Hi all,
Friendly ping:
Who can take this?
Thanks
On 3/7/19 3:49 PM, Finn Thain wrote:
> Adjust comments accordingly.
>
> Cc: Gustavo A. R. Silva <gustavo@embeddedor.com>
> Cc: Michael Schmitz <schmitzmic@gmail.com>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
> ---
> drivers/scsi/NCR5380.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c
> index 7fed9bb72784..fe0535affc14 100644
> --- a/drivers/scsi/NCR5380.c
> +++ b/drivers/scsi/NCR5380.c
> @@ -1932,13 +1932,13 @@ static void NCR5380_information_transfer(struct Scsi_Host *instance)
> if (!hostdata->connected)
> return;
>
> - /* Fall through to reject message */
> -
> + /* Reject message */
> + /* Fall through */
> + default:
> /*
> * If we get something weird that we aren't expecting,
> - * reject it.
> + * log it.
> */
> - default:
> if (tmp == EXTENDED_MESSAGE)
> scmd_printk(KERN_INFO, cmd,
> "rejecting unknown extended message code %02x, length %d\n",
>
next prev parent reply other threads:[~2019-04-08 23:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 21:49 Finn Thain
2019-03-19 18:19 ` Martin K. Petersen
2019-04-08 23:44 ` Gustavo A. R. Silva [this message]
2019-04-09 0:22 ` Finn Thain
2019-04-09 22:28 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd71e91a-92e4-9e96-7d5a-4d9a58f7128f@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=fthain@telegraphics.com.au \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®