From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E769BC06513 for ; Thu, 4 Jul 2019 10:31:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C1C2A2189E for ; Thu, 4 Jul 2019 10:31:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727593AbfGDKbs (ORCPT ); Thu, 4 Jul 2019 06:31:48 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:55818 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727303AbfGDKbs (ORCPT ); Thu, 4 Jul 2019 06:31:48 -0400 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id F1DF11997EE06086CD30; Thu, 4 Jul 2019 18:31:45 +0800 (CST) Received: from [10.151.23.176] (10.151.23.176) by smtp.huawei.com (10.3.19.213) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 4 Jul 2019 18:31:38 +0800 Subject: Re: [PATCH RESEND v3] staging: erofs: remove unsupported ->datamode check in fill_inline_data() To: Yue Hu , Greg KH CC: , , , , References: <20190702025601.7976-1-zbestahu@gmail.com> <20190703162038.GA31307@kroah.com> <20190704095903.0000565e.zbestahu@gmail.com> <20190704052649.GA7454@kroah.com> <20190704180207.0000374e.zbestahu@gmail.com> From: Gao Xiang Message-ID: Date: Thu, 4 Jul 2019 18:31:33 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20190704180207.0000374e.zbestahu@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.151.23.176] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/7/4 18:02, Yue Hu wrote: > On Thu, 4 Jul 2019 07:26:49 +0200 > Greg KH wrote: > >> On Thu, Jul 04, 2019 at 09:59:03AM +0800, Yue Hu wrote: >>> On Wed, 3 Jul 2019 18:20:38 +0200 >>> Greg KH wrote: >>> >>>> On Tue, Jul 02, 2019 at 10:56:01AM +0800, Yue Hu wrote: >>>>> From: Yue Hu >>>>> >>>>> Already check if ->datamode is supported in read_inode(), no need to check >>>>> again in the next fill_inline_data() only called by fill_inode(). >>>>> >>>>> Signed-off-by: Yue Hu >>>>> Reviewed-by: Gao Xiang >>>>> Reviewed-by: Chao Yu >>>>> --- >>>>> no change >>>>> >>>>> drivers/staging/erofs/inode.c | 2 -- >>>>> 1 file changed, 2 deletions(-) >>>> >>>> This is already in my tree, right? >>> >>> Seems not, i have received notes about other 2 patches below mergerd: >>> >>> ```note1 >>> This is a note to let you know that I've just added the patch titled >>> >>> staging: erofs: don't check special inode layout >>> >>> to my staging git tree which can be found at >>> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git >>> in the staging-next branch. >>> ``` >>> >>> ```note2 >>> This is a note to let you know that I've just added the patch titled >>> >>> staging: erofs: return the error value if fill_inline_data() fails >>> >>> to my staging git tree which can be found at >>> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git >>> in the staging-next branch. >>> ``` >>> >>> No this patch in below link checked: >>> >>> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/log/drivers/staging/erofs?h=staging-testing >> >> Then if it is not present, it needs to be rebased as it does not apply. >> >> Please do so and resend it. > > Hm, no need to resend since it's included in another patch below. > > ec8c244 staging: erofs: add compacted ondisk compression indexes. Yes, it seems it was modified by the following patch occasionally months ago. https://lore.kernel.org/lkml/20190614181619.64905-2-gaoxiang25@huawei.com/ Anyway, thanks for your patch. :) Thanks, Gao Xiang > > Thanks. > >> >> thanks, >> >> greg k-h > > _______________________________________________ > devel mailing list > devel@linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel >